Date: Wed, 27 Sep 2006 08:24:50 -0700
From: Randy Dunlap <rdunlap@xenotime.net>
To: Joe Perches <joe@perches.com>
Cc: Greg KH <greg@kroah.com>, Jesper Juhl <jesper.juhl@gmail.com>,
       Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: Tiny error in printk output for clocksource : a3:<6>Time:
 acpi_pm clocksource has been installed.
Message-Id: <20060927082450.d6de0f4f.rdunlap@xenotime.net>
In-Reply-To: <1159334393.13196.9.camel@localhost>
References: <9a8748490609261722g557eaeeayc148b5f5d910874d@mail.gmail.com>
	<20060926173347.04fd66dd.rdunlap@xenotime.net>
	<200609270236.58148.jesper.juhl@gmail.com>
	<20060926205415.98b8d95d.rdunlap@xenotime.net>
	<20060927043239.GA32082@kroah.com>
	<20060926215235.16c987c0.rdunlap@xenotime.net>
	<20060926215622.f128d9fa.rdunlap@xenotime.net>
	<1159333843.13196.6.camel@localhost>
	<20060926221718.7e20613e.rdunlap@xenotime.net>
	<1159334393.13196.9.camel@localhost>
Organization: YPO4
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1254
Lines: 31

On Tue, 26 Sep 2006 22:19:53 -0700 Joe Perches wrote:

> On Tue, 2006-09-26 at 22:17 -0700, Randy Dunlap wrote:
> > > > so it does break the printk()s up itself.
> > > Changing all of those MAC address printks to a single function
> > > could prevent this.
> > > http://www.uwsg.iu.edu/hypermail/linux/net/0602.1/0002.html
> > True enough.  Thanks for the patch.
> > However, in this case, the single-printed MAC address still needs
> > a \n, with the IRQ on a separate line (wasting vertical screen space),
> > or it needs a custom printk() that is all done at one time.
> > Probably the latter IMO.  Oh, it looks like your patch
> > has a way to handle that too.  Good.
> > What happened to your patch?
> 
> I sent it as an RFC with samples and such.
> It's out of date and it went comment free.
> I could bring it forward if anyone wants it.

I think that it's needed, but it's really up to the netdev
people.  If you do resend it, please note this problem
(that Jesper posted) as well.

Thanks,
---
~Randy
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/