Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: (.text.ks8851_probe_common+0x370): undefined reference to
 `__this_module'
To:     kernel test robot <lkp@intel.com>, Marek Vasut <marex@denx.de>,
        arnd@arndb.de
Cc:     kbuild-all@lists.01.org, linux-kernel@vger.kernel.org,
        Andrew Lunn <andrew@lunn.ch>
References: <202102221437.vHlLwHmG-lkp@intel.com>
From:   Randy Dunlap <rdunlap@infradead.org>
Message-ID: <33c7cb1f-b6c0-24bf-0e6c-23d5472e4c29@infradead.org>
Date:   Tue, 23 Feb 2021 18:38:49 -0800
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.7.0
MIME-Version: 1.0
In-Reply-To: <202102221437.vHlLwHmG-lkp@intel.com>
Content-Type: text/plain; charset=windows-1252; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 2/21/21 10:12 PM, kernel test robot wrote:
> Hi Marek,
> 
> FYI, the error/warning still remains.
> 
> tree:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
> head:   31caf8b2a847214be856f843e251fc2ed2cd1075
> commit: ef3631220d2b3d8d14cf64464760505baa60d6ac net: ks8851: Register MDIO bus and the internal PHY
> date:   7 weeks ago
> config: parisc-randconfig-r034-20210222 (attached as .config)
> compiler: hppa-linux-gcc (GCC) 9.3.0
> reproduce (this is a W=1 build):
>          wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
>          chmod +x ~/bin/make.cross
>          # https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=ef3631220d2b3d8d14cf64464760505baa60d6ac
>          git remote add linus https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
>          git fetch --no-tags linus master
>          git checkout ef3631220d2b3d8d14cf64464760505baa60d6ac
>          # save the attached .config to linux build tree
>          COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=parisc
> 
> If you fix the issue, kindly add following tag as appropriate
> Reported-by: kernel test robot <lkp@intel.com>
> 
> All errors (new ones prefixed by >>):
> 
>     hppa-linux-ld: drivers/net/ethernet/micrel/ks8851_common.o: in function `ks8851_probe_common':
>>> (.text.ks8851_probe_common+0x370): undefined reference to `__this_module'
>>> hppa-linux-ld: (.text.ks8851_probe_common+0x374): undefined reference to `__this_module'

Hey Arnd-

I wanted to see if you had any ideas about this problem.

CONFIG_KS8851=y
CONFIG_KS8851_MLL=m

The problem is that 2 drivers share some common code, but in one case
the shared code is builtin and for the other driver it is a loadable
module. The common code is first built as builtin, so it does not have
the "__this_module" symbol.

Thanks.