Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
IronPort-SDR: oxHJWItd9exxrIy8ki+6b8gzcrQFEynPLqFj2Nna1tc0Twk51i01eW6/8KAgHQesq8rfIMcJzK
 wbrZK5WDp5hPVVwHueXJNDm7HLv26OfyMsihECCS+CI0Tmfu39C6D7jpCdEZYPQJC3jQ0hg5Rq
 RMFfNODLxfbvzZpDRauMsGfQIq4Q5kgGUl44LHnTu5hgbyEX9Puprl2vjIi6tGOjV3U+kp+UN2
 wUh20bLN+tjk3gQQSZb7aGQqAYUGjEtod0I7hib9pYgZyudkBZmp8iEm8T3qukf2ydE6VqTzwl
 fKA=
From:   Chaitanya Kulkarni <Chaitanya.Kulkarni@wdc.com>
To:     Stephen Rothwell <sfr@canb.auug.org.au>
CC:     Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        Linux Next Mailing List <linux-next@vger.kernel.org>
Subject: Re: linux-next: build warning after merge of the block tree
Thread-Topic: linux-next: build warning after merge of the block tree
Thread-Index: AQHXClUzpjkXmk4Idkajps6jemEJ+A==
Date:   Wed, 24 Feb 2021 05:25:49 +0000
Message-ID: <BYAPR04MB49653608E4E792BCC8804616869F9@BYAPR04MB4965.namprd04.prod.outlook.com>
References: <20210224133140.5f02fa0e@canb.auug.org.au>
Accept-Language: en-US
Content-Language: en-US
wdcipoutbound: EOP-TRUE
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: b07fb1c8-a559-4b4d-3806-08d8d884a537
X-MS-Exchange-CrossTenant-originalarrivaltime: 24 Feb 2021 05:25:49.0908
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: b61c8803-16f3-4c35-9b17-6f65f441df86
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: eMNQ+ZvV/10YPxPawgaOGFHVMm0hSmkoEDxXo4Ux62Go2jcmjgJvRkTYGzoZfY6HyuvR8LCjyg4q/edoQTLNY1itP13Nl/JtXQL3jRHsMGA=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR04MB7680
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Stephen,=0A=
=0A=
On 2/23/21 18:31, Stephen Rothwell wrote:=0A=
> Hi all,=0A=
>=0A=
> After merging the block tree, today's linux-next build (htmldocs)=0A=
> produced this warning:=0A=
>=0A=
> kernel/trace/blktrace.c:1878: warning: Function parameter or member 'rwbs=
' not described in 'blk_fill_rwbs'`=0A=
>=0A=
> Introduced by commit=0A=
>=0A=
>   1f83bb4b4914 ("blktrace: add blk_fill_rwbs documentation comment")=0A=
>=0A=
> -- Cheers, Stephen Rothwell=0A=
I've failed to understand this warning as rwbs is present in the doc header=
=0A=
and in the function parameter :-=0A=
=0A=
/**                                                                        =
                           =0A=
=0A=
 * blk_fill_rwbs - Fill the buffer rwbs by mapping op to character string.=
=0A=
 * @rwbs        buffer to be filled=0A=
 * @op:         REQ_OP_XXX for the tracepoint=0A=
 *=0A=
 * Description:=0A=
 *     Maps the REQ_OP_XXX to character and fills the buffer provided by th=
e=0A=
 *     caller with resulting string.=0A=
 *=0A=
 **/=0A=
void blk_fill_rwbs(char *rwbs, unsigned int op)=0A=
{=0A=
        int i =3D 0;=0A=
=0A=
        if (op & REQ_PREFLUSH)=0A=
                rwbs[i++] =3D 'F';=0A=
=0A=
        switch (op & REQ_OP_MASK) {=0A=
        case REQ_OP_WRITE:=0A=
        case REQ_OP_WRITE_SAME:=0A=
                rwbs[i++] =3D 'W';=0A=
                break;=0A=
        case REQ_OP_DISCARD:=0A=
                rwbs[i++] =3D 'D';=0A=
                break;=0A=
        case REQ_OP_SECURE_ERASE:=0A=
                rwbs[i++] =3D 'D';=0A=
                rwbs[i++] =3D 'E';=0A=
                break;=0A=
        case REQ_OP_FLUSH:=0A=
                rwbs[i++] =3D 'F';=0A=
                break;=0A=
        case REQ_OP_READ:=0A=
                rwbs[i++] =3D 'R';=0A=
                break;=0A=
        default:=0A=
                rwbs[i++] =3D 'N';=0A=
        }=0A=
=0A=
        if (op & REQ_FUA)=0A=
                rwbs[i++] =3D 'F';=0A=
        if (op & REQ_RAHEAD)=0A=
                rwbs[i++] =3D 'A';=0A=
        if (op & REQ_SYNC)=0A=
                rwbs[i++] =3D 'S';=0A=
        if (op & REQ_META)=0A=
                rwbs[i++] =3D 'M';=0A=
=0A=
        rwbs[i] =3D '\0';=0A=
}=0A=
EXPORT_SYMBOL_GPL(blk_fill_rwbs);=0A=
=0A=