Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Content-Type: text/plain;
        charset=utf-8
Mime-Version: 1.0 (Mac OS X Mail 14.0 \(3654.60.0.2.21\))
Subject: Re: [PATCH] nand: brcmnand: fix OOB R/W with Hamming ECC
From:   =?utf-8?Q?=C3=81lvaro_Fern=C3=A1ndez_Rojas?= <noltari@gmail.com>
In-Reply-To: <32837cb2-f7ba-d59e-de66-051019b21e89@gmail.com>
Date:   Wed, 24 Feb 2021 08:16:58 +0100
Cc:     Brian Norris <computersforpeace@gmail.com>,
        Kamal Dasu <kdasu.kdev@gmail.com>,
        Miquel Raynal <miquel.raynal@bootlin.com>,
        Richard Weinberger <richard@nod.at>,
        Vignesh Raghavendra <vigneshr@ti.com>,
        linux-mtd@lists.infradead.org,
        bcm-kernel-feedback-list@broadcom.com, linux-kernel@vger.kernel.org
Content-Transfer-Encoding: quoted-printable
Message-Id: <0670B343-C39E-4610-8061-A7F81F90B9F4@gmail.com>
References: <20210222201655.32361-1-noltari@gmail.com>
 <32837cb2-f7ba-d59e-de66-051019b21e89@gmail.com>
To:     Florian Fainelli <f.fainelli@gmail.com>
Precedence: bulk

Hi Florian,

> El 24 feb 2021, a las 4:46, Florian Fainelli <f.fainelli@gmail.com> =
escribi=C3=B3:
>=20
>=20
>=20
> On 2/22/2021 12:16 PM, =C3=81lvaro Fern=C3=A1ndez Rojas wrote:
>> Hamming ECC doesn't cover the OOB data, so reading or writing OOB =
shall
>> always be done without ECC enabled.
>> This is a problem when adding JFFS2 cleanmarkers to erased blocks. If =
JFFS2
>> clenmarkers are added to the OOB with ECC enabled, OOB bytes will be =
changed
>> from ff ff ff to 00 00 00, reporting incorrect ECC errors.
>>=20
>> Signed-off-by: =C3=81lvaro Fern=C3=A1ndez Rojas <noltari@gmail.com>
>=20
> Should there be a Fixes: tag provided here for back porting to stable =
trees?

I think so, but the fixed commit would be the first one, right?
27c5b17cd1b10564fa36f8f51e4b4b41436ecc32

> --=20
> Florian

Best regards,
=C3=81lvaro.=