Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Wed, 24 Feb 2021 17:20:21 +0900
From:   William Breathitt Gray <vilhelm.gray@gmail.com>
To:     Oleksij Rempel <o.rempel@pengutronix.de>
Cc:     devicetree@vger.kernel.org, Ahmad Fatoum <a.fatoum@pengutronix.de>,
        linux-iio@vger.kernel.org,
        Robin van der Gracht <robin@protonic.nl>,
        Linus Walleij <linus.walleij@linaro.org>,
        linux-kernel@vger.kernel.org, Rob Herring <robh+dt@kernel.org>,
        Pengutronix Kernel Team <kernel@pengutronix.de>,
        David Jander <david@protonic.nl>,
        Jonathan Cameron <jic23@kernel.org>
Subject: Re: [PATCH v5 2/2] counter: add IRQ or GPIO based event counter
Message-ID: <YDYMRVgC3BrjISKU@shinobu>
References: <20210208135347.18494-1-o.rempel@pengutronix.de>
 <20210208135347.18494-3-o.rempel@pengutronix.de>
 <YCjlPhEtyH+vfSi4@shinobu>
 <20210215091737.fx6dwiz7tt56wbkr@pengutronix.de>
 <YDMMJJ985Zq9oEOv@shinobu>
 <20210223100656.efbshsh5bz66uhj5@pengutronix.de>
 <20210223174516.wjlh7hnrd5qe5s6w@pengutronix.de>
 <YDW7Hihg0gGQh8UR@shinobu>
 <20210224073506.GA24260@pengutronix.de>
 <YDYKF7zdyjZX30gX@shinobu>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="/BAJX8Q7j9z0hddt"
Content-Disposition: inline
In-Reply-To: <YDYKF7zdyjZX30gX@shinobu>
Precedence: bulk


--/BAJX8Q7j9z0hddt
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Wed, Feb 24, 2021 at 05:11:03PM +0900, William Breathitt Gray wrote:
> On Wed, Feb 24, 2021 at 08:35:06AM +0100, Oleksij Rempel wrote:
> > On Wed, Feb 24, 2021 at 11:34:06AM +0900, William Breathitt Gray wrote:
> > > Alternatively, we can take a more generic approach: ignore the GPIO
> > > names and focus solely on the IRQ lines; because the GPIO lines will
> > > always be tied to respective IRQ lines here, using the IRQ as the bas=
is
> > > of the name should always be valid. The "name" member of the struct
> > > irq_chip can work for this. I haven't tested this, but I think someth=
ing
> > > like this would work:
> > >=20
> > > 	cnt_signals[0].name =3D irq_get_chip(priv->irq)->name;
> >=20
> > ok, i'll take a look at it.
>=20
> If that doesn't work, then use devm_kasprintf() to generate the name
> based on the IRQ line number. The idea here is that the user should be
> able to identify that the Signal component for this Count is the
> respective IRQ.
>=20
> William Breathitt Gray

I realized that these irq_chip names are often just the device name
which isn't very useful either. :-(

In that case, I suppose we really are just left with generating the name
based on the IRQ line number then. This should be fine then:

	cnt_signals[0].name =3D devm_kasprintf(dev, GFP_KERNEL, "IRQ %d",
					     priv->irq);
	if (!cnt_signals[0].name)
		return -ENOMEM;

I think this would make it clear to the user that this Signal is the
respective IRQ (whether sourced from GPIO or not).

William Breathitt Gray

--/BAJX8Q7j9z0hddt
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEk5I4PDJ2w1cDf/bghvpINdm7VJIFAmA2DEUACgkQhvpINdm7
VJImuA/9FhUJFLm1+UOrQJ31XDXZ018AgRi2LO5elphbM52xgMdV8e7bpkn9Ujbt
Wacl5jV5XAZ6QHF5kKi/L1GCwblG4KH7yKaFOPG2Us0WuIE+AvokiW5sSEwIZSs1
LOnEvgOlH1vtiFKwCQ4sTyOSp+yUciOYYmZcEbcdejkzzdEJktt15d7aVrMsDTFT
eR/7RyXpgGoxVjTz2kEzhXbBLVpvOBniPtewd74CueFfy3vpm+PddALnQRp4loCF
WT8Tl9f8rhk8QG5uhWxkmxTJtlbp0x8cygbNIdn3goi2B0U/K9KviUNHfw+ERbLs
OlGGh3mewT+uyaiElAvRgsePIUmaZyEC8WB/bT7F7bK0D2WeQvbwQ8wcUi2otDC0
P/HonFa93IBmQ775f60so+f1Vx51VWWO+zt8/1D//Nvdx4owBsYJXTE5TACL+Byc
nmdWiwlKk2M0njyizP9s1awc/gCEPXvgFfCnZcSXrJvo+uaSHJTAVt8rujVn1Nry
O4FIiC5EkoTcO/GX6+6xx958Ac2Og8Ky8tXT0+l7xlFrK4ILxs/kXq3159Hws2SV
DTyrlU0zbQtssS2brBydYIAaREokYrM2hMHqzfusvZ1qnkBX+XMYvM/iWcyCBYNm
OrjJ/tgh1evtkFRK6164sJRvr+obpOOZke5v/o36z80nCZKMIVA=
=FZy6
-----END PGP SIGNATURE-----

--/BAJX8Q7j9z0hddt--