Received: by 2002:a05:6a10:8c0a:0:0:0:0 with SMTP id go10csp253626pxb; Wed, 24 Feb 2021 00:48:59 -0800 (PST) X-Google-Smtp-Source: ABdhPJzjm7sScouegc+2NzBOm2aPY4MAFhJXh8+J5hTwYrDnsuKNP6IwjQPvcC36c18DB4gMZ87q X-Received: by 2002:a17:906:ae14:: with SMTP id le20mr24398782ejb.231.1614156539023; Wed, 24 Feb 2021 00:48:59 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1614156539; cv=none; d=google.com; s=arc-20160816; b=Uia/qtFJzliCVBsX0mMo+WkJVMd1JokIvsxRoNtb/Q6qzknx0x8Hfm8MUkREvyPVDn 4TKLP7Tvnxc1iKib9a2a39hZP2C2quWUb6QQ4pkDk8GO/uFSXnWVuw/IAQWJsOdO0yPS xeDrEHp7mEB4qfeMxiLmws1JyEM6UzkTXOLDPTs+SOWqit90vL+1BG3FFqWjplHqYjuK S0SFwSOGGpKkRBTVm4frLfyNjH4vzEQH7qb/fqZ0geJf2TQb7s3pb/Oh3wPLaweSR5Cg z5H8MOkPA+qXcH88WkJqkvFnsi6r5TvEFEve+MzLF6AaavouR2ZD5c45SU+IqhhikwSJ bI2w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=NVOivrQkbhUYYYcVGD6e4aORmI1x2sDphQp+U9sGHXA=; b=eljpBGfAUoGMjKJPSqSjz0kLjKi8JmfFiDS9NHuECaHhZGsZSSVqK/T5/aH47MOigU izGp6vBy/BihgNRbhNeTCF8gxIH6noo9iPNYYMYEWML1XbM8OmAAmL+0Dp6/7PWzMWv6 seA9BVzM3tOVlUFdrSWONDXcA9dJ43H3C098AfGcmADvozZ4WMbo7Nxahc88RWeFYWS3 qrV72egkY4mYVAfpPI18msUZaXbTnB83JZem6QvgjS5g4LNxSr7s4EQ+GTaQiipOWzFN fwxESHbK/DfsoNVjg8sNJUX+sHL16WtsMM6BnqdBm9bHIVrnGoVEYv2mRQWZWs0R7aVK pQWA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=F9+tRs+D; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id z2si715183edp.392.2021.02.24.00.48.24; Wed, 24 Feb 2021 00:48:59 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=F9+tRs+D; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234525AbhBXIrL (ORCPT + 99 others); Wed, 24 Feb 2021 03:47:11 -0500 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:59331 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234170AbhBXIoq (ORCPT ); Wed, 24 Feb 2021 03:44:46 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1614156199; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=NVOivrQkbhUYYYcVGD6e4aORmI1x2sDphQp+U9sGHXA=; b=F9+tRs+DVtxq94MecSunsk7kXVDBdIC7nGvfShJtoED/2bkFkAn/rxVB/Uh9JuoTSVydmo hbQnpn7536gQa5YpO7coRqdrgCGTihFtki26NGAS2Jdjc+W/aQ+SKeHvNihFNumOxiEUAW ipVwRdPKe/Vi7lxFPrTDubRLM1bC4Hk= Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-533-2_TAnItdOHSxO8nsN6OIyw-1; Wed, 24 Feb 2021 03:43:18 -0500 X-MC-Unique: 2_TAnItdOHSxO8nsN6OIyw-1 Received: by mail-wm1-f71.google.com with SMTP id r21so108129wmq.7 for ; Wed, 24 Feb 2021 00:43:17 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=NVOivrQkbhUYYYcVGD6e4aORmI1x2sDphQp+U9sGHXA=; b=DXSS/kjBAu40amIvy7TFzUJwhFf3AUb3NFkfCRxEA/Aokj9pnoA4rJ8Ad1w9BO2XwV dFF/PjH98yySC2ss9vpk/jTG44voNSP0F2y8kDV5CKdR0Aatys8ojFxqjMYNSWZ3M45f jRhjQ1NrXfg29tOfE5tulLXYlMiy9VDx6Mz1ESh41BHNU1b1q/qZzfyV6G1W9s3ptBy0 UIEf/nhZeKVhBLJAmHhj4jSHOAh2buJmyjloyB6g9JJqeOFUUFKaNA0KMXx+PV7FsfRg 4Q9w9vheVQvpKx3gRh0UiNEOFkU4uVk5krMSDE1HdhOsaa03LGsLwfX3+wlT13c1uNxn Isvg== X-Gm-Message-State: AOAM533cMWFMzLXvCQIbSCdIMa9YK0tMh1SKBswLqENIOf0dvZzu/wvs vOb/J9u3TwSEp7ZgX9lF014qVldsFUs+XlAxfpy7sPqk+XvonDMsstVB/8jPInlLIYt5Lw3kcHA lMxepzWZy3QR2EQ7dZl8tml1+ X-Received: by 2002:a7b:cc0c:: with SMTP id f12mr2668465wmh.111.1614156196959; Wed, 24 Feb 2021 00:43:16 -0800 (PST) X-Received: by 2002:a7b:cc0c:: with SMTP id f12mr2668455wmh.111.1614156196796; Wed, 24 Feb 2021 00:43:16 -0800 (PST) Received: from redhat.com (bzq-79-180-2-31.red.bezeqint.net. [79.180.2.31]) by smtp.gmail.com with ESMTPSA id q20sm1614382wmc.14.2021.02.24.00.43.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 24 Feb 2021 00:43:16 -0800 (PST) Date: Wed, 24 Feb 2021 03:43:13 -0500 From: "Michael S. Tsirkin" To: Jason Wang Cc: Si-Wei Liu , elic@nvidia.com, linux-kernel@vger.kernel.org, virtualization@lists.linux-foundation.org, netdev@vger.kernel.org Subject: Re: [PATCH] vdpa/mlx5: set_features should allow reset to zero Message-ID: <20210224034240-mutt-send-email-mst@kernel.org> References: <22fe5923-635b-59f0-7643-2fd5876937c2@oracle.com> <20210223082536-mutt-send-email-mst@kernel.org> <3ff5fd23-1db0-2f95-4cf9-711ef403fb62@oracle.com> <20210224000057-mutt-send-email-mst@kernel.org> <0559fd8c-ff44-cb7a-8a74-71976dd2ee33@redhat.com> <20210224014232-mutt-send-email-mst@kernel.org> <20210224021222-mutt-send-email-mst@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Feb 24, 2021 at 04:26:43PM +0800, Jason Wang wrote: > Basically on first guest access QEMU would tell kernel whether > guest is using the legacy or the modern interface. > E.g. virtio_pci_config_read/virtio_pci_config_write will call ioctl(ENABLE_LEGACY, 1) > while virtio_pci_common_read will call ioctl(ENABLE_LEGACY, 0) > > > But this trick work only for PCI I think? > > Thanks ccw has a revision it can check. mmio does not have transitional devices at all. -- MST