From: Arnd Bergmann <arnd@arndb.de>
To: Robin Getz <rgetz@blackfin.uclinux.org>
Subject: Re: [PATCH 1/4] Blackfin: arch patch for 2.6.18
Date: Wed, 27 Sep 2006 18:41:13 +0200
User-Agent: KMail/1.9.4
Cc: luke Yang <luke.adi@gmail.com>, Andrew Morton <akpm@osdl.org>,
       linux-kernel@vger.kernel.org
References: <6.1.1.1.0.20060927121508.01ecea90@ptg1.spd.analog.com>
In-Reply-To: <6.1.1.1.0.20060927121508.01ecea90@ptg1.spd.analog.com>
MIME-Version: 1.0
Content-Type: text/plain;
  charset="iso-8859-1"
Content-Transfer-Encoding: 8BIT
Content-Disposition: inline
Message-Id: <200609271841.14135.arnd@arndb.de>
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 934
Lines: 23

On Wednesday 27 September 2006 18:25, Robin Getz wrote:
> +#define idle_with_irq_disabled() do { ? \
> + ? ? ? ?__asm__ __volatile__ ( ? ? ? ? ?\
> + ? ? ? ? ? ? ? ?"nop; nop;\n" ? ? ? ? ? \
> + ? ? ? ? ? ? ? ?".align 8;\n" ? ? ? ? ? \
> + ? ? ? ? ? ? ? ?"sti %0; idle;\n" ? ? ? \
> + ? ? ? ? ? ? ? ?::"d" (irq_flags)); ? ? \
> +} while (0)
> 

The irq_flags are not declared anywhere in the code you just posted,
I guess you could simply declare a local variable in this macro.

It would also be better to convert macros like this one to inline
functions in general. The rule is: if you can use either a macro
or an inline function with the same effect, use an inline function.

	Arnd <><
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/