Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Message-ID: <6d60d9b35012d970b7a2f60792ef45ec6b1bd4c7.camel@cyberfiber.eu>
Subject: Re: problems with memory allocation and the alignment check
From:   "Michael J. Baars" <mjbaars1977.gcc@cyberfiber.eu>
To:     Andrew Pinski <pinskia@gmail.com>
Cc:     GCC Mailing List <gcc@gcc.gnu.org>,
        LKML <linux-kernel@vger.kernel.org>
Date:   Wed, 24 Feb 2021 08:05:42 +0100
In-Reply-To: <CA+=Sn1kR6jV2j2cOLhC-GBDS_NSxsw0m=K+VghBmqBSB4c2gqw@mail.gmail.com>
References: <80753cbc54ef69b4fc136f791666197fc8b1f8bb.camel@cyberfiber.eu>
         <CA+=Sn1njFZ-XZRHJdmjzOyvXvcMXg+oBao=wK8w3RXN_Ji=fLA@mail.gmail.com>
         <d9a2cdcf116ed32874ed02bd6fa60ad899ce5f50.camel@cyberfiber.eu>
         <CA+=Sn1kR6jV2j2cOLhC-GBDS_NSxsw0m=K+VghBmqBSB4c2gqw@mail.gmail.com>
Content-Type: multipart/mixed; boundary="=-gDqG88XF5HWMvyn7IRbU"
User-Agent: Evolution 3.36.5 (3.36.5-2.fc32) 
MIME-Version: 1.0
Precedence: bulk


--=-gDqG88XF5HWMvyn7IRbU
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit

On Mon, 2021-02-22 at 01:41 -0800, Andrew Pinski wrote:
> On Mon, Feb 22, 2021 at 1:37 AM Michael J. Baars
> <mjbaars1977.gcc@cyberfiber.eu> wrote:
> > On Mon, 2021-02-22 at 01:29 -0800, Andrew Pinski wrote:
> > > On Mon, Feb 22, 2021 at 1:17 AM Michael J. Baars
> > > <mjbaars1977.gcc@cyberfiber.eu> wrote:
> > > > Hi,
> > > > 
> > > > I just wrote this little program to demonstrate a possible flaw in both malloc and calloc.
> > > > 
> > > > If I allocate a the simplest memory region from main(), one out of three optimization flags fail.
> > > > If I allocate the same region from a function, three out of three optimization flags fail.
> > > > 
> > > > Does someone know if this really is a flaw, and if so, is it a gcc or a kernel flaw?
> > > 
> > > There is no flaw.  GCC (kernel, glibc) all assume unaligned accesses
> > > on x86 will not cause an exception.
> > 
> > Is this just an assumption or more like a fact? I agree with you that byte aligned is more or less the same as unaligned.
> 
> It is an assumption that is even made inside GCC.  You can modify GCC
> not to assume that but you need to recompile all libraries and even
> check the assembly code that is included with most programs.
> Why are you enabling the alignment access check anyways?  What are you
> trying to do?
> If you are looking into a performance issue with unaligned accesses,
> may I suggest you look into perf to see if you can see unaligned
> accesses?

Next to performance and correctness, I always try to keep in mind that every clock cycle will eventually end up on the energy bill, to avoid that computers cost
ten times more on the energy bill then they do in the store.

If you look at the power consumption of the Playstation 1 vs that of the Playstation 3 for example, you will see that the Playstation 1 uses (10 W / 240 V
= 0.041666667 A max, while the Playstation 3 consumes 240 V * 1.7 A = 408 W. More than 40 times as much energy!!!

Code and style always go hand in hand. Try to keep you code as sleek as possible and you will see that even an old computer can do a lot more than you ever
thought possible :)

Thanks,
Mischa.

> Thanks,
> Andrew
> 
> > > Thanks,
> > > Andrew
> > > 
> > > > Regards,
> > > > Mischa.

--=-gDqG88XF5HWMvyn7IRbU
Content-Disposition: attachment; filename="compression.c"
Content-Type: text/x-csrc; name="compression.c"; charset="UTF-8"
Content-Transfer-Encoding: base64

I2luY2x1ZGUJPHN0ZGludC5oPgoKI2luY2x1ZGUJImNvbXByZXNzaW9uLmgiCgp1aW50OF90CWRh
dGFfc1syNTZdICAgICA9CXsKCQkJCTB4MDAsIDB4MDEsIDB4MDIsIDB4MDMsIDB4MDQsIDB4MDUs
IDB4MDYsIDB4MDcsIDB4MDgsIDB4MDksIDB4MEEsIDB4MEIsIDB4MEMsIDB4MEQsIDB4MEUsIDB4
MEYsIDB4MTAsIDB4MTEsIDB4MTIsIDB4MTMsIDB4MTQsIDB4MTUsIDB4MTYsIDB4MTcsIDB4MTgs
IDB4MTksIDB4MUEsIDB4MUIsIDB4MUMsIDB4MUQsIDB4MUUsIDB4MUYsCgkJCQkweDIwLCAweDIx
LCAweDIyLCAweDIzLCAweDI0LCAweDI1LCAweDI2LCAweDI3LCAweDI4LCAweDI5LCAweDJBLCAw
eDJCLCAweDJDLCAweDJELCAweDJFLCAweDJGLCAweDMwLCAweDMxLCAweDMyLCAweDMzLCAweDM0
LCAweDM1LCAweDM2LCAweDM3LCAweDM4LCAweDM5LCAweDNBLCAweDNCLCAweDNDLCAweDNELCAw
eDNFLCAweDNGLAoJCQkJMHg0MCwgMHg0MSwgMHg0MiwgMHg0MywgMHg0NCwgMHg0NSwgMHg0Niwg
MHg0NywgMHg0OCwgMHg0OSwgMHg0QSwgMHg0QiwgMHg0QywgMHg0RCwgMHg0RSwgMHg0RiwgMHg1
MCwgMHg1MSwgMHg1MiwgMHg1MywgMHg1NCwgMHg1NSwgMHg1NiwgMHg1NywgMHg1OCwgMHg1OSwg
MHg1QSwgMHg1QiwgMHg1QywgMHg1RCwgMHg1RSwgMHg1RiwKCQkJCTB4NjAsIDB4NjEsIDB4NjIs
IDB4NjMsIDB4NjQsIDB4NjUsIDB4NjYsIDB4NjcsIDB4NjgsIDB4NjksIDB4NkEsIDB4NkIsIDB4
NkMsIDB4NkQsIDB4NkUsIDB4NkYsIDB4NzAsIDB4NzEsIDB4NzIsIDB4NzMsIDB4NzQsIDB4NzUs
IDB4NzYsIDB4NzcsIDB4NzgsIDB4NzksIDB4N0EsIDB4N0IsIDB4N0MsIDB4N0QsIDB4N0UsIDB4
N0YsCgkJCQkweDgwLCAweDgxLCAweDgyLCAweDgzLCAweDg0LCAweDg1LCAweDg2LCAweDg3LCAw
eDg4LCAweDg5LCAweDhBLCAweDhCLCAweDhDLCAweDhELCAweDhFLCAweDhGLCAweDkwLCAweDkx
LCAweDkyLCAweDkzLCAweDk0LCAweDk1LCAweDk2LCAweDk3LCAweDk4LCAweDk5LCAweDlBLCAw
eDlCLCAweDlDLCAweDlELCAweDlFLCAweDlGLAoJCQkJMHhBMCwgMHhBMSwgMHhBMiwgMHhBMywg
MHhBNCwgMHhBNSwgMHhBNiwgMHhBNywgMHhBOCwgMHhBOSwgMHhBQSwgMHhBQiwgMHhBQywgMHhB
RCwgMHhBRSwgMHhBRiwgMHhCMCwgMHhCMSwgMHhCMiwgMHhCMywgMHhCNCwgMHhCNSwgMHhCNiwg
MHhCNywgMHhCOCwgMHhCOSwgMHhCQSwgMHhCQiwgMHhCQywgMHhCRCwgMHhCRSwgMHhCRiwKCQkJ
CTB4QzAsIDB4QzEsIDB4QzIsIDB4QzMsIDB4QzQsIDB4QzUsIDB4QzYsIDB4QzcsIDB4QzgsIDB4
QzksIDB4Q0EsIDB4Q0IsIDB4Q0MsIDB4Q0QsIDB4Q0UsIDB4Q0YsIDB4RDAsIDB4RDEsIDB4RDIs
IDB4RDMsIDB4RDQsIDB4RDUsIDB4RDYsIDB4RDcsIDB4RDgsIDB4RDksIDB4REEsIDB4REIsIDB4
REMsIDB4REQsIDB4REUsIDB4REYsCgkJCQkweEUwLCAweEUxLCAweEUyLCAweEUzLCAweEU0LCAw
eEU1LCAweEU2LCAweEU3LCAweEU4LCAweEU5LCAweEVBLCAweEVCLCAweEVDLCAweEVELCAweEVF
LCAweEVGLCAweEYwLCAweEYxLCAweEYyLCAweEYzLCAweEY0LCAweEY1LCAweEY2LCAweEY3LCAw
eEY4LCAweEY5LCAweEZBLCAweEZCLCAweEZDLCAweEZELCAweEZFLCAweEZGCgkJCX07Ci8qCjAw
MDAwMDAwMDAwMDAwMDAgPGNvbXByZXNzaW9uX2VuY29kZV9wcmVwYXJlMT46CiAgIDA6CTQ4IDg5
IGY5ICAgICAgICAgICAgIAltb3YgICAgJXJkaSwlcmN4CiAgIDM6CTMxIGQyICAgICAgICAgICAg
ICAgIAl4b3IgICAgJWVkeCwlZWR4CiAgIDU6CWI4IDAwIDAwIDAwIDAxICAgICAgIAltb3YgICAg
JDB4MTAwMDAwMCwlZWF4CiAgIGE6CTY2IDBmIDFmIDQ0IDAwIDAwICAgIAlub3B3ICAgMHgwKCVy
YXgsJXJheCwxKQogIDEwOgk0OCA4MyBlOCAwMSAgICAgICAgICAJc3ViICAgICQweDEsJXJheAog
IDE0Ogk3NSBmYSAgICAgICAgICAgICAgICAJam5lICAgIDEwIDxjb21wcmVzc2lvbl9lbmNvZGVf
cHJlcGFyZTErMHgxMD4KICAxNjoJODggMTEgICAgICAgICAgICAgICAgCW1vdiAgICAlZGwsKCVy
Y3gpCiAgMTg6CTQ4IDgzIGMyIDAxICAgICAgICAgIAlhZGQgICAgJDB4MSwlcmR4CiAgMWM6CTQ4
IDgzIGMxIDAxICAgICAgICAgIAlhZGQgICAgJDB4MSwlcmN4CiAgMjA6CTQ4IDgxIGZhIDAwIDAx
IDAwIDAwIAljbXAgICAgJDB4MTAwLCVyZHgKICAyNzoJNzUgZGMgICAgICAgICAgICAgICAgCWpu
ZSAgICA1IDxjb21wcmVzc2lvbl9lbmNvZGVfcHJlcGFyZTErMHg1PgogIDI5OgljMyAgICAgICAg
ICAgICAgICAgICAJcmV0cSAgIAogIDJhOgk2NiAwZiAxZiA0NCAwMCAwMCAgICAJbm9wdyAgIDB4
MCglcmF4LCVyYXgsMSkKKi8KCnZvaWQJY29tcHJlc3Npb25fZW5jb2RlX3ByZXBhcmUxCShzdHJ1
Y3QgY29tcHJlc3Npb24qIGMpCnsKCWZvcgkodWludDY0X3QgaiA9IDA7IGogPCAoMSA8PCAyNCk7
IGorKykKCWZvcgkodWludDY0X3QgaSA9IDA7IGkgPCAyNTY7IGkrKykKCXsKCQljLT5kYXRhX3Rb
aV0gICAgPQlpOwoJfQp9Cgp2b2lkCWNvbXByZXNzaW9uX2VuY29kZV9wcmVwYXJlMgkoc3RydWN0
IGNvbXByZXNzaW9uKiBjKQp7Cglmb3IJKHVpbnQ2NF90IGogPSAwOyBqIDwgKDEgPDwgMjQpOyBq
KyspCglhc20Jdm9sYXRpbGUJCQkJCVwKCSgJCQkJCQlcCgkiCWxlYQkJJTAgICAsICUlcmRpCVxu
IglcCgkiCWxlYQkJJTEgICAsICUlcnNpCVxuIglcCgkiCW1vdgkJJDB4MjAsICUlcmN4CVxuIglc
CgkiCXJlcAkJbW92c3EJCVxuIglcCgkJOiAiPW0iCQkoYy0+ZGF0YV90KQkJXAoJCTogIm0iCQko
ICAgZGF0YV9zKQkJXAoJCTogIiVyY3giLCAiJXJzaSIsICIlcmRpIgkJCVwKCSk7Cn0KCg==


--=-gDqG88XF5HWMvyn7IRbU
Content-Disposition: attachment; filename="compression.h"
Content-Type: text/x-chdr; name="compression.h"; charset="UTF-8"
Content-Transfer-Encoding: base64

I2lmbmRlZglfX0NPTVBSRVNTSU9OX0hfXwojZGVmaW5lCV9fQ09NUFJFU1NJT05fSF9fCgojaW5j
bHVkZQk8c3RkaW50Lmg+CgpzdHJ1Y3QJY29tcHJlc3Npb24KewoJdWludDhfdAlkYXRhX3RbMjU2
XTsJLy8gY29tcHJlc3Npb24gdHJlZSBpbmRpY2VzCn07CgpleHRlcm4Jdm9pZAljb21wcmVzc2lv
bl9lbmNvZGVfcHJlcGFyZTEJKHN0cnVjdCBjb21wcmVzc2lvbiogYyk7CmV4dGVybgl2b2lkCWNv
bXByZXNzaW9uX2VuY29kZV9wcmVwYXJlMgkoc3RydWN0IGNvbXByZXNzaW9uKiBjKTsKCiNlbmRp
ZgoK


--=-gDqG88XF5HWMvyn7IRbU
Content-Disposition: attachment; filename="main.c"
Content-Type: text/x-csrc; name="main.c"; charset="UTF-8"
Content-Transfer-Encoding: base64

I2luY2x1ZGUJPHN0ZGludC5oPgojaW5jbHVkZQk8c3RkaW8uaD4KI2luY2x1ZGUJPHRpbWUuaD4K
CiNpbmNsdWRlCSJjb21wcmVzc2lvbi5oIgoKaW50CW1haW4oKQp7CgljbG9ja190CXRpYywgdG9j
OwoJCglzdHJ1Y3QJY29tcHJlc3Npb24JYzsKCQoJdGljICAgID0JY2xvY2soKTsKCgkJCQljb21w
cmVzc2lvbl9lbmNvZGVfcHJlcGFyZTEJKCZjKTsKCQkJCQkKCXRvYyAgICA9CWNsb2NrKCk7CgkK
CWZvcgkodWludDY0X3QgaSA9IDA7IGkgPCAyNTY7IGkrKykgcHJpbnRmKCIlMDJoaFggIiwgYy5k
YXRhX3RbaV0pOyBwcmludGYoIlxuIik7CgkKCXByaW50ZigiZWxhcHNlZCBjb21wcmVzc2lvbiAm
IGVuY3J5cHRpb246ICVmc1xuIiwgKGRvdWJsZSkgKHRvYyAtIHRpYykgLyAoZG91YmxlKSBDTE9D
S1NfUEVSX1NFQyk7CQoJCgl0aWMgICAgPQljbG9jaygpOwoKCQkJCWNvbXByZXNzaW9uX2VuY29k
ZV9wcmVwYXJlMgkoJmMpOwoJCQkJCQoJdG9jICAgID0JY2xvY2soKTsKCQoJZm9yCSh1aW50NjRf
dCBpID0gMDsgaSA8IDI1NjsgaSsrKSBwcmludGYoIiUwMmhoWCAiLCBjLmRhdGFfdFtpXSk7IHBy
aW50ZigiXG4iKTsKCQoJcHJpbnRmKCJlbGFwc2VkIGNvbXByZXNzaW9uICYgZW5jcnlwdGlvbjog
JWZzXG4iLCAoZG91YmxlKSAodG9jIC0gdGljKSAvIChkb3VibGUpIENMT0NLU19QRVJfU0VDKTsJ
Cn0K


--=-gDqG88XF5HWMvyn7IRbU
Content-Disposition: attachment; filename="makefile"
Content-Type: text/x-makefile; name="makefile"; charset="UTF-8"
Content-Transfer-Encoding: base64

YWxsOgoKCWdjYyAtT2Zhc3QgLWMgLWcgLW8gY29tcHJlc3Npb24ubyBjb21wcmVzc2lvbi5jCgln
Y2MgLU9mYXN0IC1jIC1nIC1vIG1haW4ubyAgICAgICAgbWFpbi5jCglnY2MgLU9mYXN0ICAgIC1n
IC1vIG1haW4gICAgICAgICAgbWFpbi5vIGNvbXByZXNzaW9uLm8K


--=-gDqG88XF5HWMvyn7IRbU--