Message-Id: <6.1.1.1.0.20060927132022.01ed0450@ptg1.spd.analog.com>
Date: Wed, 27 Sep 2006 13:47:16 -0400
To: Randy Dunlap <dunlap@xenotime.net>
From: Robin Getz <rgetz@blackfin.uclinux.org>
Subject: Re: [PATCH 1/4] Blackfin: arch patch for 2.6.18
Cc: arnd Bergmann <arnd@arndb.de>, luke Yang <luke.adi@gmail.com>,
       Andrew Morton <akpm@osdl.org>, linux-kernel@vger.kernel.org
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"; format=flowed
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 754
Lines: 24

Randy wrote:

>except for coding style nits.  E.g., the patch above:
>a.  uses spaces instead of tabs for indentation

yeah - my copy/paste/mailer is broken - when it copies tabs, it pastes 
space into the mailer.

>b.  has an extra (unwanted) space in:
> > +               if (likely( !need_resched()))
>                              ^

There are still lots of places where we need to fix up broken white space 
in our patches.

Does anyone have a script that identifies white space problems?

Thanks
-Robin 
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/