Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <1612697823-8073-1-git-send-email-tanxiaofei@huawei.com>
In-Reply-To: <1612697823-8073-1-git-send-email-tanxiaofei@huawei.com>
From:   Geert Uytterhoeven <geert@linux-m68k.org>
Date:   Wed, 24 Feb 2021 10:41:19 +0100
Message-ID: <CAMuHMdXwmjq_MPr=R9twkYRoun2buuSrPDbLo6zdkGFb7XQHoQ@mail.gmail.com>
Subject: Re: [PATCH for-next 00/32] spin lock usage optimization for SCSI drivers
To:     Xiaofei Tan <tanxiaofei@huawei.com>
Cc:     "James E.J. Bottomley" <jejb@linux.ibm.com>,
        "Martin K. Petersen" <martin.petersen@oracle.com>,
        scsi <linux-scsi@vger.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        linuxarm@openeuler.org
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

Hi Xiaofei,

On Sun, Feb 7, 2021 at 12:46 PM Xiaofei Tan <tanxiaofei@huawei.com> wrote:
> Replace spin_lock_irqsave with spin_lock in hard IRQ of SCSI drivers.
> There are no function changes, but may speed up if interrupt happen
> too often.

I'll bite: how much does this speed up interrupt processing?
What's the typical cost of saving/disabling, and restoring interrupt
state?  Is removing this cost worth the risk of introducing subtle
regressions on platforms you cannot test yourself?

BTW, how many of these legacy SCSI controllers do you have access to?

Thanks for your answers!

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds