Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH v2 0/2] leds: bcm63x8: improve read and write functions
To:     =?UTF-8?Q?=c3=81lvaro_Fern=c3=a1ndez_Rojas?= <noltari@gmail.com>
Cc:     Jonas Gorski <jonas.gorski@gmail.com>, Pavel Machek <pavel@ucw.cz>,
        Dan Murphy <dmurphy@ti.com>, linux-leds@vger.kernel.org,
        linux-kernel@vger.kernel.org
References: <20210224101110.20179-1-noltari@gmail.com>
 <a9a9fb30-2d90-33ff-9b80-af9d03b69c69@gmail.com>
 <B9E7BB0F-00E7-40CC-9571-E17E574E1C3F@gmail.com>
From:   Florian Fainelli <f.fainelli@gmail.com>
Message-ID: <f94b922f-b720-1ea1-e1d1-405e7bb475de@gmail.com>
Date:   Wed, 24 Feb 2021 09:43:08 -0800
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101
 Firefox/78.0 Thunderbird/78.7.1
MIME-Version: 1.0
In-Reply-To: <B9E7BB0F-00E7-40CC-9571-E17E574E1C3F@gmail.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 8bit
Precedence: bulk


On 2/24/2021 7:54 AM, Álvaro Fernández Rojas wrote:
> Hi Florian,
> 
>> El 24 feb 2021, a las 16:45, Florian Fainelli <f.fainelli@gmail.com> escribió:
>>
>>
>>
>> On 2/24/2021 2:11 AM, Álvaro Fernández Rojas wrote:
>>> This code is proven to work in BMIPS BE/LE and ARM BE/LE.
>>> See bcm2835-rng and bcmgenet.c:
>>> https://github.com/torvalds/linux/blob/3b9cdafb5358eb9f3790de2f728f765fef100731/drivers/char/hw_random/bcm2835-rng.c#L42-L60
>>> https://github.com/torvalds/linux/blob/3b9cdafb5358eb9f3790de2f728f765fef100731/drivers/net/ethernet/broadcom/genet/bcmgenet.c#L71-L88
>>
>> What is the motivation for doing this? bcm2835-rng and bcmgenet are used
>> across MIPS and ARM platforms therefore they need to be compatible with
>> both, but these two LEDs drivers are super specialized, are you working
>> on porting the 6328 LED driver to the newer ARM-based DSL SoCs such as
>> 63138 and 63148?
> 
> I just wanted to have all bmips drivers in line (at least regarding read/write).
> If I remember correctly someone told me that this controller was also present on some little endian SoCs, but you can confirm that :).
> Unfortunately I haven’t got any devices with ARM-based DSL SoCs, so the answer is no.

The 6328 LED controller could be utilized on the ARM-based DSL SoCs,
however 6358 will not, so changing the I/O accessors for that driver
sounds like just code churn to me.
-- 
Florian