Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Wed, 24 Feb 2021 12:12:33 -0600
From:   Josh Poimboeuf <jpoimboe@redhat.com>
To:     Peter Zijlstra <peterz@infradead.org>
Cc:     x86@kernel.org, linux-kernel@vger.kernel.org,
        Ivan Babrou <ivan@cloudflare.com>,
        Steven Rostedt <rostedt@goodmis.org>
Subject: Re: [PATCH 2/2] x86/unwind/orc: Silence warnings caused by missing
 ORC data
Message-ID: <20210224181233.f5q2scq43e2j372j@treble>
References: <cover.1612534649.git.jpoimboe@redhat.com>
 <06d02c4bbb220bd31668db579278b0352538efbb.1612534649.git.jpoimboe@redhat.com>
 <YDZoEehURLLI/lWq@hirez.programming.kicks-ass.net>
 <20210224151805.zrujocamlb5pxf7m@treble>
 <YDaV47Cw8AEzsnkg@hirez.programming.kicks-ass.net>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <YDaV47Cw8AEzsnkg@hirez.programming.kicks-ass.net>
Precedence: bulk

On Wed, Feb 24, 2021 at 07:07:31PM +0100, Peter Zijlstra wrote:
> On Wed, Feb 24, 2021 at 09:18:05AM -0600, Josh Poimboeuf wrote:
> > On Wed, Feb 24, 2021 at 03:52:01PM +0100, Peter Zijlstra wrote:
> > > On Fri, Feb 05, 2021 at 08:24:03AM -0600, Josh Poimboeuf wrote:
> > > > The ORC unwinder attempts to fall back to frame pointers when ORC data
> > > > is missing for a given instruction.  It sets state->error, but then
> > > > tries to keep going as a best-effort type of thing.  That may result in
> > > > further warnings if the unwinder gets lost.
> > > > 
> > > > Until we have some way to register generated code with the unwinder,
> > > > missing ORC will be expected, and occasionally going off the rails will
> > > > also be expected.  So don't warn about it.
> > > 
> > > I recently ran into another variant of missing ORC data, some files are
> > > simply not processed by objtool, eg. arch/x86/realmode/init.c. Would it
> > > make sense to have the vmlinux pass (when it isn't used to generate orc
> > > in the first place) also check that all code it finds has ORC data?
> > > 
> > > It's not fool proof, but it should help find files we're missing for
> > > some raisin.
> > 
> > Doesn't validate_reachable_instructions() basically already do that?
> 
> Nope, I'm talking about the case where we generate ORC for each .o file
> (and 'forget' to run objtool on some of them). And then run objtool
> again on vmlinux to validate (things like noinstr).
> 
> At that point it might make sense to also check that all code does
> indeed have an ORC to double check our initial (per translation unit)
> invocation didn't accidentally miss someone.

What I meant was, validate_reachable_instructions() should already be
able to report that situation, if it were called on vmlinux.  Right now
I think noinstr avoids calling it.

I'm already working on some vmlinux rework which will enable that
checking.  Then we'll have to go through the unreachable warnings and
try to fix them.

-- 
Josh