Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Sender: bbhatt=codeaurora.org@mg.codeaurora.org
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII;
 format=flowed
Content-Transfer-Encoding: 7bit
Date:   Wed, 24 Feb 2021 10:55:17 -0800
From:   Bhaumik Bhatt <bbhatt@codeaurora.org>
To:     Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
Cc:     linux-arm-msm@vger.kernel.org, hemantk@codeaurora.org,
        jhugo@codeaurora.org, linux-kernel@vger.kernel.org,
        loic.poulain@linaro.org
Subject: Re: [PATCH v6 8/8] bus: mhi: core: Do not clear channel context more
 than once
Organization: Qualcomm Innovation Center, Inc.
Reply-To: bbhatt@codeaurora.org
Mail-Reply-To: bbhatt@codeaurora.org
In-Reply-To: <20210224101013.GV27945@work>
References: <1612470486-10440-1-git-send-email-bbhatt@codeaurora.org>
 <1612470486-10440-9-git-send-email-bbhatt@codeaurora.org>
 <20210224101013.GV27945@work>
Message-ID: <e18295810c7ef7d2a0932f42351e542d@codeaurora.org>
User-Agent: Roundcube Webmail/1.3.9
Precedence: bulk

On 2021-02-24 02:10 AM, Manivannan Sadhasivam wrote:
> On Thu, Feb 04, 2021 at 12:28:06PM -0800, Bhaumik Bhatt wrote:
>> Clearing a channel context can happen twice if the client driver
>> unprepares and reset the channels from the remove() callback from
>> a controller requested MHI power down sequence. If there are
>> multiple attempts at calling the mhi_free_coherent() API, we see
>> kernel warnings such as "trying to free invalid coherent area".
>> Example for one such client is the QRTR MHI driver. Avoid these
>> warnings by skipping mhi_deinit_chan_ctxt() API call and prevent
>> extra work from MHI as the channels are already disabled.
>> 
>> Signed-off-by: Bhaumik Bhatt <bbhatt@codeaurora.org>
> 
> Is this patch still valid? We merged a similar fix from Loic for v5.11.
> 
Yes, both the patches work to solve the same problem. This one just does 
it
sooner and relies on internal state variable rather than context being 
NULL.
> Thanks,
> Mani
> 
>> ---
>>  drivers/bus/mhi/core/init.c | 1 +
>>  1 file changed, 1 insertion(+)
>> 
>> diff --git a/drivers/bus/mhi/core/init.c b/drivers/bus/mhi/core/init.c
>> index 30eef19..272f350 100644
>> --- a/drivers/bus/mhi/core/init.c
>> +++ b/drivers/bus/mhi/core/init.c
>> @@ -1314,6 +1314,7 @@ static int mhi_driver_remove(struct device *dev)
>> 
>>  		if ((ch_state[dir] == MHI_CH_STATE_ENABLED ||
>>  		     ch_state[dir] == MHI_CH_STATE_STOP) &&
>> +		    mhi_chan->ch_state != MHI_CH_STATE_DISABLED &&
>>  		    !mhi_chan->offload_ch)
>>  			mhi_deinit_chan_ctxt(mhi_cntrl, mhi_chan);
>> 
>> --
>> The Qualcomm Innovation Center, Inc. is a member of the Code Aurora 
>> Forum,
>> a Linux Foundation Collaborative Project
>> 

Thanks,
Bhaumik
---
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora 
Forum,
a Linux Foundation Collaborative Project