Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Wed, 24 Feb 2021 13:32:40 -0700
From:   Mathieu Poirier <mathieu.poirier@linaro.org>
To:     Yang Li <yang.lee@linux.alibaba.com>
Cc:     ohad@wizery.com, bjorn.andersson@linaro.org,
        linux-remoteproc@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] remoteproc: pru: Replace DEFINE_SIMPLE_ATTRIBUTE with
 DEFINE_DEBUGFS_ATTRIBUTE
Message-ID: <20210224203240.GA3512860@xps15>
References: <1614154829-42461-1-git-send-email-yang.lee@linux.alibaba.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1614154829-42461-1-git-send-email-yang.lee@linux.alibaba.com>
Precedence: bulk

On Wed, Feb 24, 2021 at 04:20:29PM +0800, Yang Li wrote:
> Fix the following coccicheck warning:
> ./drivers/remoteproc/pru_rproc.c:247:0-23: WARNING:
> pru_rproc_debug_ss_fops should be defined with DEFINE_DEBUGFS_ATTRIBUTE
> 
> Reported-by: Abaci Robot <abaci@linux.alibaba.com>
> Signed-off-by: Yang Li <yang.lee@linux.alibaba.com>
> ---
>  drivers/remoteproc/pru_rproc.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/remoteproc/pru_rproc.c b/drivers/remoteproc/pru_rproc.c
> index 2667919..04a9d99 100644
> --- a/drivers/remoteproc/pru_rproc.c
> +++ b/drivers/remoteproc/pru_rproc.c
> @@ -244,7 +244,7 @@ static int pru_rproc_debug_ss_get(void *data, u64 *val)
>  
>  	return 0;
>  }
> -DEFINE_SIMPLE_ATTRIBUTE(pru_rproc_debug_ss_fops, pru_rproc_debug_ss_get,
> +DEFINE_DEBUGFS_ATTRIBUTE(pru_rproc_debug_ss_fops, pru_rproc_debug_ss_get,
>  			pru_rproc_debug_ss_set, "%llu\n");

Reviewed-by: Mathieu Poirier <mathieu.poirier@linaro.org>


>  
>  /*
> -- 
> 1.8.3.1
>