Received: by 2002:a05:6a10:8c0a:0:0:0:0 with SMTP id go10csp704186pxb; Wed, 24 Feb 2021 12:44:28 -0800 (PST) X-Google-Smtp-Source: ABdhPJwvjFnubbMlRaNfUeZWjF59eKoYtY7gPvoaawsT/WoQr+pVJ02mrmRNlZsuzAl8i3ImWxNm X-Received: by 2002:aa7:ca57:: with SMTP id j23mr35778649edt.293.1614199468199; Wed, 24 Feb 2021 12:44:28 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1614199468; cv=none; d=google.com; s=arc-20160816; b=Z8Ek49IIItrODxNBw/wkq+oGAY091Xntsjkmf+KU/UoVm9HPaZ5mKeBJCOpy23P13P Tn4fdUNSKS3FeHDgN3LTY5fZV0ZO+lTWEOCN7JeXYzdSUrk3g6ILOESLF0gdN6a03uSO IG+WFrm1oZzk9LoCJM0S86t2tSHAn2aDS4kWswyA/M2wUUgVurW9Z2DilewOURJHU5Sp y6GevwqBMfDbsG+sz8nG8+LK0M23t2rnyMdoWQmaWNNjBn3M3O4Ce0yeoRuJmVWgA2nC 0K1EtIagmGyMBpkdcvrm2I45f72U7vJg44jf3xvCvWONjUGscB3FgzeldjCqwD2gRpTm iq7Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=VFxShBzJBKwIv3itsmWVkegV7IoKFluKjrJvY+J4Dkw=; b=VaYKkGfb9VpZLsOfmfmthX1egPE0yLvuTEhVX9dii0bCaHR+NJEFhY1/DopibFAaIS peXUeQ3LaCo7EBAj6u4OowxWqxbP+Yj1icz55CM+FvYPbKOz/hF7iM4q7mvn0Wmd2hW9 3x1TQvJinXMdBxARdoTo36vs1pTm8/njTYK1yZZUI8eFAeGHG7zCmCblXhcJ9+WEHtrr c1J9avTnpW2afmET9mqU0aBkdgLYbGBTvE6MXnK1d+6H7ar3irSjya07fQK1ckMFYZ/Z aogqSWG3sTV6qUTIpYLFvWQkDjwsF7a5XzNR2/B7gJr02b/cTkhEszuZT0qPrP7Z93rJ 0+tg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@google.com header.s=20161025 header.b=LshVzGHO; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id g18si1813901edu.193.2021.02.24.12.44.03; Wed, 24 Feb 2021 12:44:28 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@google.com header.s=20161025 header.b=LshVzGHO; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235366AbhBXUlb (ORCPT + 99 others); Wed, 24 Feb 2021 15:41:31 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50682 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235420AbhBXUlX (ORCPT ); Wed, 24 Feb 2021 15:41:23 -0500 Received: from mail-pj1-x1030.google.com (mail-pj1-x1030.google.com [IPv6:2607:f8b0:4864:20::1030]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id EFA14C061786 for ; Wed, 24 Feb 2021 12:40:25 -0800 (PST) Received: by mail-pj1-x1030.google.com with SMTP id d2so2146557pjs.4 for ; Wed, 24 Feb 2021 12:40:25 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=VFxShBzJBKwIv3itsmWVkegV7IoKFluKjrJvY+J4Dkw=; b=LshVzGHOI6rEiOwFaGcmofK3UPPprdyi9CyVz3sxdLCZyw6TRPM+zNYnXY0vqcvpXr a698fRl+hOyA4PMWDtImni2n8GmBHtceKC8vZpulD4lsexTvALuOIDGnoBTg5ISDjor9 sjdRe4sxNy90o9jUU+qhlPpyWyxc1doB5z3E6r0sPS+El3VgDVwA6GHTAt0yRf1OW2BF BX3TD4T1QkP3yBcteJktqVeuI/4N/khDksVMZ7g895dTDNZthKwueuXmPjTbAWprBWwR ozwE1ZZ7/5UAn6BH2LQTTnHKhT+QdGEtbooHSLJvMDUNaIYhTS+8JBQGcXsTBiad3cQ3 cGAA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=VFxShBzJBKwIv3itsmWVkegV7IoKFluKjrJvY+J4Dkw=; b=L0G1Ck1mhaQLihCJCL0ZCFNzl8YpYJZEyjIdMDQr057c3a2LV89v3kOlsSX4Zm935y niLqxvJWept1JJYHzogiROXxWzZlKOsZlwkPF4nN7L+BzXT7liJr65n8wx5Chnk6zEcY xAkAs3Xm01IZbRdLIYdKrpwyjG1JjsiYn9K3Cnz9JoFy5Pyt6SBc4EH3FPtPsqa3ZmsM Qlv0nLawTDfA3o/OXZnCBqM5bNMU4eTOCJK8uiJJ+1fSLB/OjoGjUopTzSx2tae/rcVf LhhUhlZ4LlNBD3YjaAufz+6VKWYjBJqJ7SpS1N1yDwqk2TKjqTYv0VHu/QGfZTvk2Fb+ Qu7Q== X-Gm-Message-State: AOAM531HL45xM0N1YfrN0aRORgjJpAU/QeGUoTQwUdCu1LUJdwKdm4XY drPlu/A65BP25cREzPun0gIUnQ== X-Received: by 2002:a17:90a:9f96:: with SMTP id o22mr6190038pjp.119.1614199225349; Wed, 24 Feb 2021 12:40:25 -0800 (PST) Received: from google.com ([2620:15c:f:10:385f:4012:d20f:26b5]) by smtp.gmail.com with ESMTPSA id u15sm3471033pfk.128.2021.02.24.12.40.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 24 Feb 2021 12:40:24 -0800 (PST) Date: Wed, 24 Feb 2021 12:40:17 -0800 From: Sean Christopherson To: "Liu, Jing2" Cc: Dave Hansen , pbonzini@redhat.com, Vitaly Kuznetsov , Wanpeng Li , Jim Mattson , Joerg Roedel , Thomas Gleixner , Ingo Molnar , Borislav Petkov , x86@kernel.org, "H. Peter Anvin" , kvm@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v1] kvm: x86: Revise guest_fpu xcomp_bv field Message-ID: References: <20210208161659.63020-1-jing2.liu@linux.intel.com> <4e4b37d1-e2f8-6757-003c-d19ae8184088@intel.com> <9d23ae5b-9b85-88d7-a2d7-44fd75a068b9@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <9d23ae5b-9b85-88d7-a2d7-44fd75a068b9@linux.intel.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Feb 23, 2021, Liu, Jing2 wrote: > XCOMP_BV[63] field indicates that the save area is in the > compacted format and XCOMP_BV[62:0] indicates the states that > have space allocated in the save area, including both XCR0 > and XSS bits enable by the host kernel. Use xfeatures_mask_all > for calculating xcomp_bv and reuse XCOMP_BV_COMPACTED_FORMAT > defined by kernel. Works for me, just please wrap at ~73-75 chars, not ~64. Thanks!