Received: by 2002:a05:6a10:8c0a:0:0:0:0 with SMTP id go10csp91554pxb; Wed, 24 Feb 2021 19:26:56 -0800 (PST) X-Google-Smtp-Source: ABdhPJxFLTuTXV+Cko/NapQcSJNAMJsAr7HoaVNsO2sbvXNI3PLesbuH8fdENmpkXVjes5ci5Gj1 X-Received: by 2002:a05:6402:40b:: with SMTP id q11mr934945edv.36.1614223616028; Wed, 24 Feb 2021 19:26:56 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1614223616; cv=none; d=google.com; s=arc-20160816; b=tGubNu9qe0S7RPWOAz0hv91LQd1lMmjvvVm5a5jAQLqqWAXwMwtbT4LPvA1bL09P4k leSEsIRgB+OGJEUpZ7NhvVRUT25/8VOfDKPJdk5lM2bItS9lH4+C8hjH83AkfiualPvU u/YwCORk6IdCPGQXvJsAbTeli0J3aZNWYts18Ry0ilpS+dewRV+srLlHYwpmmHrwdRmh SLcw9hUuYt39CDZO6gSH1Qwp0BHg0CvSYFpbWYmPsGvFokkns+ZoCZLqu46GgHDtE+GA oAOJpAcmxTAPP+kg47f6cTMaDwEOteL1h+E1eB+fcXbnTfL9Inkt5YCrPlddobLQzoMd Ui8A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=EwNM4IQrP65m3pBxQdPq3PIkStWcpBTasxWsf7+C0lo=; b=FX+a/gpXY/ste8cHH3GOKPb654Mbm60PoXYQcI3UDJZ0rTiC68KSdEllfFhmKii3a7 NLTQ8UwKJRapEH9nrdXSpbPiaLp/liPVCuyx/tmiW3g1Wyd9jTTtHEKHggs0c6qYVSlj QDD2WjFjZDMAWTcMS4pO8THljV6Knlt+3QPrL9+UjPRpcG9Z1j/hzwvJwtNtVxGXZzE6 hD4nJoqiYeKyQHLf+l2V4qdFjIIzfH1f42NDcnAUGKUnNjXAFpI/h1QQ6rjESK3oNYW3 +YwPRIOKDDkrA4bXPq9wWYfv71AAFe/s39tvx7x2ys1rLYupdWfFke3LDVN/+PX83O+9 mYmw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@cmpxchg-org.20150623.gappssmtp.com header.s=20150623 header.b=oynA0tAU; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=cmpxchg.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id t18si2590854edd.529.2021.02.24.19.26.32; Wed, 24 Feb 2021 19:26:56 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@cmpxchg-org.20150623.gappssmtp.com header.s=20150623 header.b=oynA0tAU; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=cmpxchg.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235851AbhBXUmo (ORCPT + 99 others); Wed, 24 Feb 2021 15:42:44 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50970 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235781AbhBXUmc (ORCPT ); Wed, 24 Feb 2021 15:42:32 -0500 Received: from mail-qk1-x735.google.com (mail-qk1-x735.google.com [IPv6:2607:f8b0:4864:20::735]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6C209C06174A for ; Wed, 24 Feb 2021 12:41:46 -0800 (PST) Received: by mail-qk1-x735.google.com with SMTP id b14so3625267qkk.0 for ; Wed, 24 Feb 2021 12:41:46 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cmpxchg-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=EwNM4IQrP65m3pBxQdPq3PIkStWcpBTasxWsf7+C0lo=; b=oynA0tAUXRRCGRxkmQGoFtzMRLvf+22xVNOkpXfaZ3ShiECJzsBik78xQsBCe2C7Ey uv/GVxd8ChE9O5nHMvqVZBh+PuvvYDYAENDW5HjbHyecOl9ca+i361mperXkFpE/ckHp AbJGwXquplMfFHdrnYcGkVAYrgUneo/hCd91ApPj9Fe/mDlLz3fNjPoou6lbl+UPqc26 LoT5jV/vczsQTsBXcNmR1HX7Xqu3ITA//sVu5lz8AM1TIivwA9pWY1IrRD+of6J0s4lE SRKdT2CGdxuUGNRCrXK5YBk4EyH3UAVXqS/agvlVNAUqVFt2Q9cT27TzExcL7mR0aJFt je4A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=EwNM4IQrP65m3pBxQdPq3PIkStWcpBTasxWsf7+C0lo=; b=Qby3LWD3AFtDknogADGbatb2uqtXTC/XsozOFwQE52eL+t1TOtjev9ZZd+kZcGW7pp p7cOMqMv8lC7LXtgNqhcIoqvt1wXpqEzjnX4sLJmsI7RKwneDHA9qgggZqBOzv/vyvi3 n/Si1MbU5nRl04CubRVeu9C1edyqtDnLAZZlRpJ4bmTTTYUr+zSq/ejyn8pdUiYEZmKw b+GDNmeA0jpkaQ19gD2Ilf5RAMBfZAxac6F2YppJVZGIMynxXWBMSUu/5DCgcPnaORZE xvHrrZOSRDwm3TL0xKmi6Tt3vueLwnoXYrWYMb3yt4BYA5EcyvsbqtKOjTU7ZcUqWySf +06Q== X-Gm-Message-State: AOAM530656SSYbG9RRDmpstfixoQIHV+O+zcDfy79e4VChGOipkD67dg Y82D519yK+mwjp3epLSdBgC3pZkcivwjUw== X-Received: by 2002:a37:4d09:: with SMTP id a9mr17091263qkb.469.1614199305734; Wed, 24 Feb 2021 12:41:45 -0800 (PST) Received: from localhost (70.44.39.90.res-cmts.bus.ptd.net. [70.44.39.90]) by smtp.gmail.com with ESMTPSA id l128sm2315474qkf.68.2021.02.24.12.41.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 24 Feb 2021 12:41:45 -0800 (PST) Date: Wed, 24 Feb 2021 15:41:44 -0500 From: Johannes Weiner To: Shakeel Butt Cc: Roman Gushchin , Michal Hocko , Andrew Morton , cgroups@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] memcg: cleanup root memcg checks Message-ID: References: <20210223205625.2792891-1-shakeelb@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210223205625.2792891-1-shakeelb@google.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Feb 23, 2021 at 12:56:25PM -0800, Shakeel Butt wrote: > Replace the implicit checking of root memcg with explicit root memcg > checking i.e. !css->parent with mem_cgroup_is_root(). > > Signed-off-by: Shakeel Butt Acked-by: Johannes Weiner