Received: by 2002:a05:6a10:8c0a:0:0:0:0 with SMTP id go10csp93225pxb; Wed, 24 Feb 2021 19:30:52 -0800 (PST) X-Google-Smtp-Source: ABdhPJxn23v11msDO9tD5mbUQ/kXOAlaqZRtEiswdCm7cF6q5PUqhit2xR0aIDThAHJ0qez1J6ae X-Received: by 2002:a17:906:25c4:: with SMTP id n4mr721025ejb.359.1614223852662; Wed, 24 Feb 2021 19:30:52 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1614223852; cv=none; d=google.com; s=arc-20160816; b=Se6uPhnWFlu9RUfQ3Kle1T+7XzXTIveHqGk9JtRsiy9Ipc9RNuSDirJEEFZdOHB+MU pZvzsshqyCNWRjO8w++jJEZe1pX19BM2hZv5PgoxkFPAJWNly3mzzeWD87SSfvkx2cbU Hw5wT9C3eXdcdctRh4dpH5SjSiOLPg5oEBTIFvLTE49HPXBvu1c96J8UnXyL/5qy50+Q f+bizsj59NZOy0stK82v0yzjZiuF45kt1/3leNJayUDdZhJgk2BVEzJqXulbxBvGDgE7 FODeXqmCHh20gsjZK2vQUsAZmmZpw4KrhFbCnonAdlsisoxfPdqQbQDOKREPFju1ZYD2 /LwA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:cc:to:subject :message-id:date:from:in-reply-to:references:mime-version :dkim-signature; bh=oNOJCv96V2W2oiF3R22dF2MhqbWN/9wIBc5R81MAbG8=; b=wjlKF5sdYP74SPcmBeJBFMsticLZGnP6eS1E/4J7/3Y0PNKTfT5nUCV+7IusecLJv0 /UWeWoYGKJQf9nuRzgg8+gBuiSSGBiIKnfTCi/My7eRucdCWebhG3lzo1m4wAqumK0D0 G/6qhX+nBW5iSn73iRzDnzxKMFAXDICK1OpVbKjXsgxkcfTQ+ex0esywJcLGG4Ezwk1A LIG+XHtAUy47FM+NvHEKQWrtg7KhPiNQ3XJoGaT6At5P3KuGveHyQNuJ4AuQBRIKr81U xb0AdZz8oLV1M0Mbei4d91cjQdAGu9CDEt2vYqcODJctL1ix+DvUs9kcQP3bQ13xm1VA DkMA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=Oj66rqmF; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id ss21si2628670ejb.338.2021.02.24.19.30.30; Wed, 24 Feb 2021 19:30:52 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=Oj66rqmF; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233016AbhBXVCF (ORCPT + 99 others); Wed, 24 Feb 2021 16:02:05 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55164 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232623AbhBXVCF (ORCPT ); Wed, 24 Feb 2021 16:02:05 -0500 Received: from mail-yb1-xb2c.google.com (mail-yb1-xb2c.google.com [IPv6:2607:f8b0:4864:20::b2c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id EA6CBC061574 for ; Wed, 24 Feb 2021 13:01:24 -0800 (PST) Received: by mail-yb1-xb2c.google.com with SMTP id p186so3253652ybg.2 for ; Wed, 24 Feb 2021 13:01:24 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=oNOJCv96V2W2oiF3R22dF2MhqbWN/9wIBc5R81MAbG8=; b=Oj66rqmFCj1oZG5mcctMLdE8WopD4kxLQzOMCysvpcWagEg/435Upf00UDNpJpepTz TKxck5a6VqwGKlDBLhND1QrqqxHD8RHFF8Gzw3SrmKThy/yBtNSowzjAQTDpYGl4XEv1 ohV/Gt+75AoO7McrARs4e4Foe8DoRodOysovwG23+HRqM/w1UamueJX4gsPdORMeNzDu Nw0vCHVdUttZ2u0L3mY/Vze+ZohwTykVT64Fq+J2CFgFI6izKiogt2asRmJFnKzZF2VR LQ+cTS+UOCLVxA/QFFTp3Aeg/GySGciOZRwxFvB2TZQJ7mn/tbzCzXUbXU+7UtVR0P3j yVXQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=oNOJCv96V2W2oiF3R22dF2MhqbWN/9wIBc5R81MAbG8=; b=bH0t7woqbcxiDyLBTFQ2+kXTGGafpbNjkmvMe24/YSVflEKuCq6A7J8WKNXatRKGMU o0RZ6akqBmS835UpIwfBZljk1hqiTxlHvb7QTbNSQKOJrYzySP/M5gqPZyYyIjE29wog thslodPaywAhiZeWSqU8XyAchlddJ3/Fpo1yxYdzgAlwBqqOoaRxdHE7+SuuWcqvvQqx PIdMJy5lRV6giJ0NPlMI6uIcuyzrzBAzi7TwSTtaP13W7RYWU14bRGjxkOeeeqzxGC5X CNYdbmErvKahHyIC0GZ3R67EXqZQfGKELlGiJBpgOeHRwh7NHvzE483VVfxGBlWn5T8L WJcw== X-Gm-Message-State: AOAM530tUC8KnQVLtzS+5f2DVA/JaPtECxh4p5ylff6mJcjOmcooiIAL xcWB8JOhHFOYXzhPhcPfE/fqFkzEpkihIgLdV+0= X-Received: by 2002:a25:d94b:: with SMTP id q72mr47291810ybg.135.1614200484280; Wed, 24 Feb 2021 13:01:24 -0800 (PST) MIME-Version: 1.0 References: <20210222201655.32361-1-noltari@gmail.com> <20210224080210.23686-1-noltari@gmail.com> In-Reply-To: <20210224080210.23686-1-noltari@gmail.com> From: Brian Norris Date: Wed, 24 Feb 2021 13:01:13 -0800 Message-ID: Subject: Re: [PATCH v2] nand: brcmnand: fix OOB R/W with Hamming ECC To: =?UTF-8?B?w4FsdmFybyBGZXJuw6FuZGV6IFJvamFz?= Cc: Florian Fainelli , Kamal Dasu , Miquel Raynal , Richard Weinberger , Vignesh Raghavendra , linux-mtd@lists.infradead.org, bcm-kernel-feedback-list , Linux Kernel Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Feb 24, 2021 at 12:02 AM =C3=81lvaro Fern=C3=A1ndez Rojas wrote: > Fixes: 27c5b17cd1b1 ("mtd: nand: add NAND driver "library" for Broadcom S= TB NAND controller") FWIW, I could believe this was broken. We weren't testing Hamming ECC (nor JFFS2) at the time, so it could easily have obvious bugs like this. And since I got this far, and I'm still in MAINTAINERS, I guess: Acked-by: Brian Norris