Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Wed, 24 Feb 2021 16:44:30 -0800
From:   "Paul E. McKenney" <paulmck@kernel.org>
To:     Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
Cc:     josh@joshtriplett.org, rostedt@goodmis.org,
        mathieu.desnoyers@efficios.com, jiangshanlai@gmail.com,
        joel@joelfernandes.org, rcu@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH] rcu: make nocb_nobypass_lim_per_jiffy static
Message-ID: <20210225004430.GA9420@paulmck-ThinkPad-P72>
Reply-To: paulmck@kernel.org
References: <1614155429-64546-1-git-send-email-jiapeng.chong@linux.alibaba.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1614155429-64546-1-git-send-email-jiapeng.chong@linux.alibaba.com>
User-Agent: Mutt/1.9.4 (2018-02-28)
Precedence: bulk

On Wed, Feb 24, 2021 at 04:30:29PM +0800, Jiapeng Chong wrote:
> Fix the following sparse warning:
> 
> kernel/rcu/tree_plugin.h:1497:5: warning: symbol
> 'nocb_nobypass_lim_per_jiffy' was not declared. Should it be static?
> 
> Reported-by: Abaci Robot <abaci@linux.alibaba.com>
> Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>

Queued with Frederic's ack (given offlist), thank you both!

						Thanx, Paul

> ---
>  kernel/rcu/tree_plugin.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/kernel/rcu/tree_plugin.h b/kernel/rcu/tree_plugin.h
> index 2d60377..8ff8cf8 100644
> --- a/kernel/rcu/tree_plugin.h
> +++ b/kernel/rcu/tree_plugin.h
> @@ -1494,7 +1494,7 @@ static int __init parse_rcu_nocb_poll(char *arg)
>   * After all, the main point of bypassing is to avoid lock contention
>   * on ->nocb_lock, which only can happen at high call_rcu() rates.
>   */
> -int nocb_nobypass_lim_per_jiffy = 16 * 1000 / HZ;
> +static int nocb_nobypass_lim_per_jiffy = 16 * 1000 / HZ;
>  module_param(nocb_nobypass_lim_per_jiffy, int, 0);
>  
>  /*
> -- 
> 1.8.3.1
>