Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
IronPort-SDR: dcHnqP8ZhpsSHKcqG9WVXhvJZs+6wCnLp8gM/A9G5oEwXV3N92N496jng/wFidZsB4RfnA5C9g
 +7dufUOt9nwg==
IronPort-SDR: YOAAxv/VPQMb8k0UAuMjlTPE/mMIrCB9QshiZaeenDxclCZ5pjuacKNoquEI6xPOVIZ+CThEPL
 ykzEfnlEtBWA==
Subject: Re: [PATCH v1] kvm: x86: Revise guest_fpu xcomp_bv field
To:     Sean Christopherson <seanjc@google.com>
Cc:     Dave Hansen <dave.hansen@intel.com>, pbonzini@redhat.com,
        Vitaly Kuznetsov <vkuznets@redhat.com>,
        Wanpeng Li <wanpengli@tencent.com>,
        Jim Mattson <jmattson@google.com>,
        Joerg Roedel <joro@8bytes.org>,
        Thomas Gleixner <tglx@linutronix.de>,
        Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
        x86@kernel.org, "H. Peter Anvin" <hpa@zytor.com>,
        kvm@vger.kernel.org, linux-kernel@vger.kernel.org
References: <20210208161659.63020-1-jing2.liu@linux.intel.com>
 <4e4b37d1-e2f8-6757-003c-d19ae8184088@intel.com>
 <YCFzztFESzcnKRqQ@google.com>
 <c33335d3-abbe-04e0-2fa1-47f57ad154ac@linux.intel.com>
 <YDPWn70DTA64psQb@google.com>
 <9d23ae5b-9b85-88d7-a2d7-44fd75a068b9@linux.intel.com>
 <YDa5saYSU+Zrr8e+@google.com>
From:   "Liu, Jing2" <jing2.liu@linux.intel.com>
Message-ID: <acf225f2-5783-8a2d-a060-e58aad28e8de@linux.intel.com>
Date:   Thu, 25 Feb 2021 10:02:26 +0800
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101
 Thunderbird/78.6.0
MIME-Version: 1.0
In-Reply-To: <YDa5saYSU+Zrr8e+@google.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
Content-Language: en-US
Precedence: bulk


On 2/25/2021 4:40 AM, Sean Christopherson wrote:
> On Tue, Feb 23, 2021, Liu, Jing2 wrote:
>> XCOMP_BV[63] field indicates that the save area is in the
>> compacted format and XCOMP_BV[62:0] indicates the states that
>> have space allocated in the save area, including both XCR0
>> and XSS bits enable by the host kernel. Use xfeatures_mask_all
>> for calculating xcomp_bv and reuse XCOMP_BV_COMPACTED_FORMAT
>> defined by kernel.
> Works for me, just please wrap at ~73-75 chars, not ~64.
>
> Thanks!
Sure, let me update v2.

BRs,
Jing