Received: by 2002:a05:6a10:8c0a:0:0:0:0 with SMTP id go10csp179365pxb; Wed, 24 Feb 2021 22:45:16 -0800 (PST) X-Google-Smtp-Source: ABdhPJySMgDcmeqWqJNhAKwwc5nPH/76DeuBHd+73VSt6olyQiJ0kTNT36/mee4t0b5+2AxmORB6 X-Received: by 2002:aa7:d9d0:: with SMTP id v16mr1471989eds.104.1614235516292; Wed, 24 Feb 2021 22:45:16 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1614235516; cv=none; d=google.com; s=arc-20160816; b=ffzOMRQmInE7VOUC5FcNiXCz8aP1lehRNBDIPslX4dvbZNFcFQSci+c4A25D+tIeT1 NEV+/JvnlHMuw88QeJGyPm5zuaFxzmwsJfkuv8TklmYguYWlqqZ/kGmq81mDvrzBAnXP EKPJb58fgRmqclW/EnMwHWRZy0IxONpsDljbl0efDUkF07SEoWjhCSHjL+FfkOBKH9Li G5vklumpNhgcN7mwOxzMqrAHgYkhPuqkrwsVsSfXBDsa9Medex3wnaZAw+wEDUTwzGBz VtzpzOJd7GJ6x3GKUB+dCEhHIPZe6zaHUGXQdx2OkjiXyqIx/ERUxLDCxffh6vzJRb47 h4xg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:from:subject:mime-version:message-id:date :sender:dkim-signature; bh=z+YFQ8HagpnlAfp5aFAoRDrk8fWVpmZPjNGOPeSjUH4=; b=u7DztQ5h+GE+VQnj7g47mho7a1r6MIarBP4f2LclIvQa0nNugH7AS1ih6y+cM1EA5W CmdmkdqygL3W7+qgSxcTJTYQFbyNfGMlGv0p6GTqsmPSxbDJFRVyyCW2BVq0nw835XRb 7SstJ2k26TB3IIRF5BpIAgQo5bHfqjNeXtWmKCKDiahtHhrVSQRc0Y3/23PTmKDZcvNc hua3frW4pGMYrbDQmqbQXfyVcRBgg2PvIEgaJRftS+s8KP7IKHxTrPjFoD5XkfPavBdR sumC0dDC0EY6XXCsqwwiXJVK9JAfMOSi1H1JzHWf/h2TB5Vs9J6wt2Z8syi81LLFGPvb e3vA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@google.com header.s=20161025 header.b=OV2OjTao; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id v15si2991284ede.1.2021.02.24.22.44.52; Wed, 24 Feb 2021 22:45:16 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@google.com header.s=20161025 header.b=OV2OjTao; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233257AbhBYFcw (ORCPT + 99 others); Thu, 25 Feb 2021 00:32:52 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51410 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233153AbhBYFcu (ORCPT ); Thu, 25 Feb 2021 00:32:50 -0500 Received: from mail-pj1-x1049.google.com (mail-pj1-x1049.google.com [IPv6:2607:f8b0:4864:20::1049]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4B74CC061574 for ; Wed, 24 Feb 2021 21:32:10 -0800 (PST) Received: by mail-pj1-x1049.google.com with SMTP id w34so402189pjj.7 for ; Wed, 24 Feb 2021 21:32:10 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=sender:date:message-id:mime-version:subject:from:to:cc; bh=z+YFQ8HagpnlAfp5aFAoRDrk8fWVpmZPjNGOPeSjUH4=; b=OV2OjTao0PVH28OXYDYfDv6MreJftrYMFoC6ZTED6et/JTHsUKThG77gqbJLkK8DDs BJJA7AlwfQ99/T3vINsQLA/VQI65YbJOuwBkRmrVGUA2Bs3WoScBQeqflQ8BKGZNaSqM aVNMtyEmsoSpe1F5vODV1t443LC+f2SGJhyBJWC38TKcxCP0JiJP48UHT12ltuia3R5A scvlMggMlAgNFFJSrwE31Wuty98x5XVrCwkP78kZv50AGeZShy6MnPZaV/bPUwx62/VZ bg/iFdrtH3ShTB6DBPVUrasbZj6TLkHvvrXTP1norLYq6Uo5CdUtAkPbig8mkDxFVrHW vF9w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:date:message-id:mime-version:subject:from :to:cc; bh=z+YFQ8HagpnlAfp5aFAoRDrk8fWVpmZPjNGOPeSjUH4=; b=k95jxdQJ+leN/aG0A02lU3cDwi7Oc0uJIqyP4F0IWFrAsDBy/ccm4YhehrnAJ8nl0m DjgAhrcNc/J6Zijhq+RMJ4rFERBvxlMHNfmqN6ftAkhKMeEkTQRII1tTftS1mPyemGU9 +bwmFro9fQbKOWaDqyz7SgbL1KQIMYVesd5/poYr2ak/BSEgCk21Ys6iERKZgE/3EtOp 5uvc0FjcjjI2MNnU2NAtOJXXYX2WcijZbUsMv6HnyHVccfy2IRvb5x3K5qLw6lmGf7ZC vABnSGbuFgsXclo4XUTdYXQa8jg/rL6H8XkeSivQMqkD0xtlKMzYjVnoEqBNN6yaX9xN 8zbA== X-Gm-Message-State: AOAM533+DYNW4b2bDdm0uaCAvLylCZPUoPPyI52sGR4TYrVnDEio3Gxi CZfaw4irzpUtIBTMnvOdzw0JZlLT Sender: "lzye via sendgmr" X-Received: from lzye2.c.googlers.com ([fda3:e722:ac3:10:24:72f4:c0a8:6713]) (user=lzye job=sendgmr) by 2002:a05:6a00:148c:b029:1eb:aa7d:b1b4 with SMTP id v12-20020a056a00148cb02901ebaa7db1b4mr1627224pfu.8.1614231129182; Wed, 24 Feb 2021 21:32:09 -0800 (PST) Date: Thu, 25 Feb 2021 05:32:04 +0000 Message-Id: <20210225053204.697951-1-lzye@google.com> Mime-Version: 1.0 X-Mailer: git-send-email 2.30.0.617.g56c4b15f3c-goog Subject: [PATCH] [v2] Input: Add "Share" button to Microsoft Xbox One controller. From: Chris Ye To: "=?UTF-8?q?=C5=81ukasz=20Patron=20?=" , Benjamin Valentin , Chris Ye , Lee Jones , "=?UTF-8?q?Olivier=20Cr=C3=AAte=20?=" , Sanjay Govind , Andrzej Pietrasiewicz Cc: linux-input@vger.kernel.org, linux-kernel@vger.kernel.org, trivial@kernel.org, kernel-team@android.com Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Add "Share" button input capability and input event mapping for Microsoft Xbox One controller. Fixed Microsoft Xbox One controller share button not working under USB connection. Signed-off-by: Chris Ye --- drivers/input/joystick/xpad.c | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/drivers/input/joystick/xpad.c b/drivers/input/joystick/xpad.c index 9f0d07dcbf06..0c3374091aff 100644 --- a/drivers/input/joystick/xpad.c +++ b/drivers/input/joystick/xpad.c @@ -79,6 +79,7 @@ #define MAP_DPAD_TO_BUTTONS (1 << 0) #define MAP_TRIGGERS_TO_BUTTONS (1 << 1) #define MAP_STICKS_TO_NULL (1 << 2) +#define MAP_SHARE_BUTTON (1 << 3) #define DANCEPAD_MAP_CONFIG (MAP_DPAD_TO_BUTTONS | \ MAP_TRIGGERS_TO_BUTTONS | MAP_STICKS_TO_NULL) @@ -130,6 +131,7 @@ static const struct xpad_device { { 0x045e, 0x02e3, "Microsoft X-Box One Elite pad", 0, XTYPE_XBOXONE }, { 0x045e, 0x02ea, "Microsoft X-Box One S pad", 0, XTYPE_XBOXONE }, { 0x045e, 0x0719, "Xbox 360 Wireless Receiver", MAP_DPAD_TO_BUTTONS, XTYPE_XBOX360W }, + { 0x045e, 0x0b12, "Microsoft X-Box One X pad", MAP_SHARE_BUTTON, XTYPE_XBOXONE }, { 0x046d, 0xc21d, "Logitech Gamepad F310", 0, XTYPE_XBOX360 }, { 0x046d, 0xc21e, "Logitech Gamepad F510", 0, XTYPE_XBOX360 }, { 0x046d, 0xc21f, "Logitech Gamepad F710", 0, XTYPE_XBOX360 }, @@ -862,6 +864,8 @@ static void xpadone_process_packet(struct usb_xpad *xpad, u16 cmd, unsigned char /* menu/view buttons */ input_report_key(dev, BTN_START, data[4] & 0x04); input_report_key(dev, BTN_SELECT, data[4] & 0x08); + if (xpad->mapping & MAP_SHARE_BUTTON) + input_report_key(dev, KEY_RECORD, data[22] & 0x01); /* buttons A,B,X,Y */ input_report_key(dev, BTN_A, data[4] & 0x10); @@ -1669,9 +1673,12 @@ static int xpad_init_input(struct usb_xpad *xpad) /* set up model-specific ones */ if (xpad->xtype == XTYPE_XBOX360 || xpad->xtype == XTYPE_XBOX360W || - xpad->xtype == XTYPE_XBOXONE) { + xpad->xtype == XTYPE_XBOXONE) { for (i = 0; xpad360_btn[i] >= 0; i++) input_set_capability(input_dev, EV_KEY, xpad360_btn[i]); + if (xpad->mapping & MAP_SHARE_BUTTON) { + input_set_capability(input_dev, EV_KEY, KEY_RECORD); + } } else { for (i = 0; xpad_btn[i] >= 0; i++) input_set_capability(input_dev, EV_KEY, xpad_btn[i]); -- 2.30.0.617.g56c4b15f3c-goog