Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Content-Type: text/plain;
        charset=utf-8
Mime-Version: 1.0 (Mac OS X Mail 14.0 \(3654.60.0.2.21\))
Subject: Re: [PATCH v2] nand: brcmnand: fix OOB R/W with Hamming ECC
From:   =?utf-8?Q?=C3=81lvaro_Fern=C3=A1ndez_Rojas?= <noltari@gmail.com>
In-Reply-To: <20210225084838.34bbdbff@xps13>
Date:   Thu, 25 Feb 2021 08:54:09 +0100
Cc:     Brian Norris <computersforpeace@gmail.com>,
        Florian Fainelli <f.fainelli@gmail.com>,
        Kamal Dasu <kdasu.kdev@gmail.com>,
        Richard Weinberger <richard@nod.at>,
        Vignesh Raghavendra <vigneshr@ti.com>,
        linux-mtd@lists.infradead.org,
        bcm-kernel-feedback-list <bcm-kernel-feedback-list@broadcom.com>,
        Linux Kernel <linux-kernel@vger.kernel.org>
Content-Transfer-Encoding: quoted-printable
Message-Id: <4DF5654C-1412-4E89-BF21-60C649EEDF4F@gmail.com>
References: <20210222201655.32361-1-noltari@gmail.com>
 <20210224080210.23686-1-noltari@gmail.com>
 <CAN8TOE_Eg6zYqy8wLtrNcTiCQdcihM7wGM5JHw=bh4=b1CL-_A@mail.gmail.com>
 <20210225084838.34bbdbff@xps13>
To:     Miquel Raynal <miquel.raynal@bootlin.com>
Precedence: bulk

Hi Miquel,

> El 25 feb 2021, a las 8:48, Miquel Raynal <miquel.raynal@bootlin.com> =
escribi=C3=B3:
>=20
> Hi =C3=81lvaro,
>=20
> Brian Norris <computersforpeace@gmail.com> wrote on Wed, 24 Feb 2021
> 13:01:13 -0800:
>=20
>> On Wed, Feb 24, 2021 at 12:02 AM =C3=81lvaro Fern=C3=A1ndez Rojas
>> <noltari@gmail.com> wrote:
>>> Fixes: 27c5b17cd1b1 ("mtd: nand: add NAND driver "library" for =
Broadcom STB NAND controller") =20
>>=20
>> FWIW, I could believe this was broken. We weren't testing Hamming ECC
>> (nor JFFS2) at the time, so it could easily have obvious bugs like
>> this.
>=20
> Right, you should probably limit the backport to the time when raw
> accessors got introduced/fixed.

What do you mean?
Those accessors have been there since the first commit =
(27c5b17cd1b10564fa36f8f51e4b4b41436ecc32):
=
https://github.com/torvalds/linux/blob/27c5b17cd1b10564fa36f8f51e4b4b41436=
ecc32/drivers/mtd/nand/brcmnand/brcmnand.c#L1896-L1899

>=20
> Thanks,
> Miqu=C3=A8l

Best regards,
=C3=81lvaro.=