Received: by 2002:a05:6a10:8c0a:0:0:0:0 with SMTP id go10csp271172pxb; Thu, 25 Feb 2021 01:58:02 -0800 (PST) X-Google-Smtp-Source: ABdhPJzyUlJ40GXiiK70Ge9d92Ayx+zYf/wd1owao0gvN0eqUlUx3AODxjV2sX1vLkMYrZv0FnoC X-Received: by 2002:a17:907:2d10:: with SMTP id gs16mr1943349ejc.0.1614247082376; Thu, 25 Feb 2021 01:58:02 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1614247082; cv=none; d=google.com; s=arc-20160816; b=k9h6ZW/oY69C+FpXrLi2qTuepNBcdhkGtY4sRxsRoZVr1qgE6dCg8RiJr8oN7VhQU7 /FHLlDdEr4X80Jb8YEyXwbFp2AbHe7mA6LyUG+4j7lz5CJBMmcwelhE/CWY6ATPRKJeZ frvFkyias2oeZiI/nE/sYvofcpeqhmc9iqfyVlagVi6MAg1hST2Kk6uswaw55+/oF2uL WTkY4eNvZNLwOyak63pOawFMyotcPa7/XRn83rHk1vYJb2Hp/JWS5LnG3OOwe96S46wE IpxkV38Q9XG3poxBnw/b6C7rb3uRWceng+VN43+iB8jDEq5MZPCVxIYUSaYSastvG2m1 fhAQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:message-id:date:subject:cc:to:from; bh=lMH6PsKM6paCiLG2DWMXtGqh4v3M/lZEGEQtLFdFzpM=; b=Fb8jOzjQDYIxtNEMhsa6zLjbNIcQsNC1sg/8KFDcV5zgU5w+WnzuQ6HeVMAUnVGfyc lC8XMW3HxhsJy3TpiU+v1LJ+UrkMK7/b0VQEUjpxAbItsWyogRt+4RHtPx+M2c6moiSh a92hUGm36jfLsvay+rvHkSbAZHB1xSRxrAuEUPzwZXnGwOuD0T2W9Rj4vH/pbGslEjFg vCr7Qwyn5z/tckdNk5ufW3ioSUp9TVw6wJT9IrY2mAzX89Vbj2z5DopqkFxKz6Yu2Qom ic0FcMmjKUnXW3CwwF4hR87G6lEjA9HVVqSBbaZbysoE/+AYRbkvOs5YeQtPYjgRZKU3 UAZQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=alibaba.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id t5si3351575edt.292.2021.02.25.01.57.39; Thu, 25 Feb 2021 01:58:02 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=alibaba.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232296AbhBYIzl (ORCPT + 99 others); Thu, 25 Feb 2021 03:55:41 -0500 Received: from out30-133.freemail.mail.aliyun.com ([115.124.30.133]:51532 "EHLO out30-133.freemail.mail.aliyun.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230091AbhBYIzf (ORCPT ); Thu, 25 Feb 2021 03:55:35 -0500 X-Alimail-AntiSpam: AC=PASS;BC=-1|-1;BR=01201311R661e4;CH=green;DM=||false|;DS=||;FP=0|-1|-1|-1|0|-1|-1|-1;HT=e01e04426;MF=yang.lee@linux.alibaba.com;NM=1;PH=DS;RN=8;SR=0;TI=SMTPD_---0UPX1XWK_1614243292; Received: from j63c13417.sqa.eu95.tbsite.net(mailfrom:yang.lee@linux.alibaba.com fp:SMTPD_---0UPX1XWK_1614243292) by smtp.aliyun-inc.com(127.0.0.1); Thu, 25 Feb 2021 16:54:52 +0800 From: Yang Li To: bcousson@baylibre.com Cc: paul@pwsan.com, tony@atomide.com, linux@armlinux.org.uk, linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Yang Li Subject: [PATCH] ARM: OMAP2+: add missing call to of_node_put() Date: Thu, 25 Feb 2021 16:54:50 +0800 Message-Id: <1614243290-47105-1-git-send-email-yang.lee@linux.alibaba.com> X-Mailer: git-send-email 1.8.3.1 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org In one of the error paths of the for_each_child_of_node() loop, add missing call to of_node_put(). Fix the following coccicheck warning: ./arch/arm/mach-omap2/omap_hwmod.c:2132:1-23: WARNING: Function "for_each_child_of_node" should have of_node_put() before return around line 2140. Reported-by: Abaci Robot Signed-off-by: Yang Li --- arch/arm/mach-omap2/omap_hwmod.c | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/arm/mach-omap2/omap_hwmod.c b/arch/arm/mach-omap2/omap_hwmod.c index 2310cd5..007e91e 100644 --- a/arch/arm/mach-omap2/omap_hwmod.c +++ b/arch/arm/mach-omap2/omap_hwmod.c @@ -2137,6 +2137,7 @@ static int of_dev_hwmod_lookup(struct device_node *np, if (res == 0) { *found = fc; *index = i; + of_node_put(np0); return 0; } } -- 1.8.3.1