Received: by 2002:a05:6a10:8c0a:0:0:0:0 with SMTP id go10csp271490pxb; Thu, 25 Feb 2021 01:58:46 -0800 (PST) X-Google-Smtp-Source: ABdhPJz/klxNtQ6ijwPBOcZBtMnMARKTKE9fK7N2mvEJaHaMeJA5j/mWz2z3D89T2viz7ozQrow1 X-Received: by 2002:a17:906:f74d:: with SMTP id jp13mr1922605ejb.287.1614247125805; Thu, 25 Feb 2021 01:58:45 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1614247125; cv=none; d=google.com; s=arc-20160816; b=wY3UQywI3lO4jA0Rm+/9TlFVPi9S66tQADGvpebqR7eu6hOw3TyJSm7B/7FHbpGc5m eoOHC+Z2xh4CVBSlGb7k3Ha/dKIbLJ0lvqwwxcAIaQ8ngIjhRKafPskELfBWeNaDuwTa T8F95KHDdOeMFrYoaM7sLzxNaed/qm5A0N2iYndtAvnyR1+SP0vACck6I6yKOvofL04j epu0UFS+2xBz7GNLy5Kq+fE+WUmCyHQfxnQno0V8DTHYcVRqFYZzQe0HXh8SrIKDI8HT rPZFhstJn7He27UHtByYFrf9znoC+108kqdu4scZqitwk7TYgqusK/GaaxEX7P8+Kdsn 0cGg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:message-id:date:subject:cc:to:from; bh=/UaIsJmJ8z+/YeHJLLKz/LpoezEKuShkFYohM2RUZLk=; b=WofGu9Lx1CpaDVql8PuENiuWnU8lVpP7CHjEuZFL4zbLtTDhOoRTSeFX2/q+djD/E4 +7DKV2pjTafgHW14nMlB1OsLEv5Cv/g+wOHKi+XZjj2ITtpJdIB8nan3Ld9OfXshKrVh tRDUTdIq+saf5tVbDwmlr6iD107rH2+Ysz0RGbc/MCqhPB8qksyjag28d4JgJuJ6adDI zYrprL8fdtepcyXI+oyvw8PsEQYKnmsyrlUyq+iGknpnu6sDA+hvvkkgvDyB6BZu9R/G i8247fy2imQkixJC5/JpUt3RE6QWu8tKbNUDY83Q9acbGKrsjFKa5bQxbM9n3yfC+JLZ RKcA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=alibaba.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id w4si3153667ejz.337.2021.02.25.01.58.23; Thu, 25 Feb 2021 01:58:45 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=alibaba.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236045AbhBYJGH (ORCPT + 99 others); Thu, 25 Feb 2021 04:06:07 -0500 Received: from out30-132.freemail.mail.aliyun.com ([115.124.30.132]:53648 "EHLO out30-132.freemail.mail.aliyun.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235387AbhBYJEn (ORCPT ); Thu, 25 Feb 2021 04:04:43 -0500 X-Alimail-AntiSpam: AC=PASS;BC=-1|-1;BR=01201311R621e4;CH=green;DM=||false|;DS=||;FP=0|-1|-1|-1|0|-1|-1|-1;HT=alimailimapcm10staff010182156082;MF=yang.lee@linux.alibaba.com;NM=1;PH=DS;RN=8;SR=0;TI=SMTPD_---0UPXQxE4_1614243838; Received: from j63c13417.sqa.eu95.tbsite.net(mailfrom:yang.lee@linux.alibaba.com fp:SMTPD_---0UPXQxE4_1614243838) by smtp.aliyun-inc.com(127.0.0.1); Thu, 25 Feb 2021 17:03:58 +0800 From: Yang Li To: mchehab@kernel.org Cc: s.nawrocki@samsung.com, krzk@kernel.org, linux-media@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org, Yang Li Subject: [PATCH] media: exynos4-is: add missing call to of_node_put() Date: Thu, 25 Feb 2021 17:03:56 +0800 Message-Id: <1614243836-54718-1-git-send-email-yang.lee@linux.alibaba.com> X-Mailer: git-send-email 1.8.3.1 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org In one of the error paths of the for_each_child_of_node() loop in fimc_md_parse_one_endpoint, add missing call to of_node_put(). Fix the following coccicheck warning: ./drivers/media/platform/exynos4-is/media-dev.c:489:1-23: WARNING: Function "for_each_child_of_node" should have of_node_put() before return around line 492. Reported-by: Abaci Robot Signed-off-by: Yang Li --- drivers/media/platform/exynos4-is/media-dev.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/media/platform/exynos4-is/media-dev.c b/drivers/media/platform/exynos4-is/media-dev.c index 8e1e892..467bc69 100644 --- a/drivers/media/platform/exynos4-is/media-dev.c +++ b/drivers/media/platform/exynos4-is/media-dev.c @@ -489,6 +489,7 @@ static int fimc_md_parse_port_node(struct fimc_md *fmd, for_each_child_of_node(port, ep) { ret = fimc_md_parse_one_endpoint(fmd, ep); if (ret < 0) + of_node_put(ep); return ret; } -- 1.8.3.1