Received: by 2002:a05:6a10:8c0a:0:0:0:0 with SMTP id go10csp271954pxb; Thu, 25 Feb 2021 01:59:47 -0800 (PST) X-Google-Smtp-Source: ABdhPJwPvRgSkJnIy1dztB2d5t+qJmkp5xCz+BjF8qnTxa8OsTB3vFnlripm0swAHLGPGX2CVB54 X-Received: by 2002:a17:906:b2c3:: with SMTP id cf3mr1819781ejb.133.1614247187763; Thu, 25 Feb 2021 01:59:47 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1614247187; cv=none; d=google.com; s=arc-20160816; b=tpfTr8O5HXYE1uAtbeE6nf/8CoDDlUtamxlbu6faXfCLtW/gALxgSWB0MIIOY24Btc RhmJ+RcvBDZYujamAkK1UbezgzAfG2YaEeIJPRZJ3yiVZQ0FRn4xjZ+EtxBknp8Hs0ip q5pzwzQO0iJCpy5OaKEbwbBxaUAc2dVxZdtSdu+e51H9jNXehdr4yiBpEhOhXgdnfS1w qDZZt2GzL7zQZbvIR2nMWY8hogdSyGL5bVH8Z3WdVJF4uAP2qu8iOnkYV5ixNvs3lnQ/ 0LptKdBLHcv8jze26QusZh7C8pyobnTDY42ppJMmiPh+da+RwhFOueY+m8kAni0/pniH MoJw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:message-id:date:subject:cc:to:from; bh=3VTtSwkKKzDTUoWhOuTbQ2mE+sFlVl5rcmnqVZgWtxk=; b=HmkK7bdl8Kbv/qd8W7mfq5Ty94tgK730wpV2yWD6UCg4+G5T4kGtcHaDnFNY0PE+j9 QqY684kmpR59zopg5KXsdca4ds1eyMcEQTNYcflwbgZ96S9bETK1Ehwfs5yoXrbgam72 YY6S3dKLkdwVkoA6w9qC8BjY0BKLZEsYqlkyFUy+cwWLFpwXBuwJ9/Owyw23IOH/+r03 uBjv+5PJxnlcCHYPu1NG0pdbo/tOfstG4jM2rh5kR58QHEPu5nDoDVHPqUQNhUmTVJLr cfD4Tc44jXEVVm01VJBWSYNfiMvKsxnA/Ha2EFI7QPtOb61um4f6Gu3cG4TKsg9DlU/5 oTyQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=alibaba.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id lf27si2835061ejc.530.2021.02.25.01.59.24; Thu, 25 Feb 2021 01:59:47 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=alibaba.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234614AbhBYJFn (ORCPT + 99 others); Thu, 25 Feb 2021 04:05:43 -0500 Received: from out30-133.freemail.mail.aliyun.com ([115.124.30.133]:34800 "EHLO out30-133.freemail.mail.aliyun.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234606AbhBYJCz (ORCPT ); Thu, 25 Feb 2021 04:02:55 -0500 X-Alimail-AntiSpam: AC=PASS;BC=-1|-1;BR=01201311R841e4;CH=green;DM=||false|;DS=||;FP=0|-1|-1|-1|0|-1|-1|-1;HT=alimailimapcm10staff010182156082;MF=yang.lee@linux.alibaba.com;NM=1;PH=DS;RN=11;SR=0;TI=SMTPD_---0UPXLGzZ_1614243730; Received: from j63c13417.sqa.eu95.tbsite.net(mailfrom:yang.lee@linux.alibaba.com fp:SMTPD_---0UPXLGzZ_1614243730) by smtp.aliyun-inc.com(127.0.0.1); Thu, 25 Feb 2021 17:02:10 +0800 From: Yang Li To: airlied@linux.ie Cc: daniel@ffwll.ch, sumit.semwal@linaro.org, alexander.deucher@amd.com, christian.koenig@amd.com, amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, linux-media@vger.kernel.org, linaro-mm-sig@lists.linaro.org, Yang Li Subject: [PATCH] drm/amdgpu: Replace DEFINE_SIMPLE_ATTRIBUTE with DEFINE_DEBUGFS_ATTRIBUTE Date: Thu, 25 Feb 2021 17:02:08 +0800 Message-Id: <1614243728-52952-1-git-send-email-yang.lee@linux.alibaba.com> X-Mailer: git-send-email 1.8.3.1 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Fix the following coccicheck warning: ./drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c:1589:0-23: WARNING: fops_ib_preempt should be defined with DEFINE_DEBUGFS_ATTRIBUTE ./drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c:1592:0-23: WARNING: fops_sclk_set should be defined with DEFINE_DEBUGFS_ATTRIBUTE Reported-by: Abaci Robot Signed-off-by: Yang Li --- drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c index 0a25fec..52ef488 100644 --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c @@ -1586,10 +1586,10 @@ static int amdgpu_debugfs_sclk_set(void *data, u64 val) return 0; } -DEFINE_SIMPLE_ATTRIBUTE(fops_ib_preempt, NULL, +DEFINE_DEBUGFS_ATTRIBUTE(fops_ib_preempt, NULL, amdgpu_debugfs_ib_preempt, "%llu\n"); -DEFINE_SIMPLE_ATTRIBUTE(fops_sclk_set, NULL, +DEFINE_DEBUGFS_ATTRIBUTE(fops_sclk_set, NULL, amdgpu_debugfs_sclk_set, "%llu\n"); int amdgpu_debugfs_init(struct amdgpu_device *adev) -- 1.8.3.1