Received: by 2002:a05:6a10:8c0a:0:0:0:0 with SMTP id go10csp272277pxb; Thu, 25 Feb 2021 02:00:30 -0800 (PST) X-Google-Smtp-Source: ABdhPJyox5OTYKCGexBx3c+7QACB3Gkxr2NNBPB+RIHapFTe7SU4hWV1HWTpsI34F+QjhdgWDwX9 X-Received: by 2002:aa7:d816:: with SMTP id v22mr2039063edq.37.1614247230329; Thu, 25 Feb 2021 02:00:30 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1614247230; cv=none; d=google.com; s=arc-20160816; b=faYJ69A0fjYhfY3+Cb4NlsOrXumh+tti2ORpQqJ+eyHl7LiLYUqvNCVcR4/HJSHTxz UZG/6kCT8MVQVewvPc//xIuvZMQ0Tnm8Yj3fBRx+wm7pYopn5/Urc7Al5w9grQsq8Ca6 BAL5h/49URwtz5Dcry0xHxn0w69Op5vDTdrh29oPm6tKJ4nURls+enadUHZGHvwULxnB thDQI4Jnope3bT26VVUjNUiu1qODARcM3d4WKoHpNIO/+rygBp7+G5hM9F+DPmReuhZW DTd44HHEBrlU4/DZXe6wBtLyyqyLqVJSbiZoEFfjKhK+3S2hI2gQta1OOZ+piV5lczWZ Fvsw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:message-id:date:subject:cc:to:from; bh=X0qbkyTO7qldRqqg+Gm+dxk5vZMqw2Lgwwza8BOxYOk=; b=MxyYythwf7O8zjiew694KW0iAmNf4oo2obaYARONL1Thj9cVq8aZYvoO+OywZWXWUI T3zhqYDW6MvOos4yZwhGlS7+SkLosS8DhmBUqAk5yHExGZDv7Sx57Gxb26jGFWTj5bnX /ivdnlfGcIHmSKGG9BxYTKQnb4ZX5WXi0D9aaVAjPMHi22bGQNe19riQo0jjVnNeR67w bdWmG/7DvC5zLgaGfdMB/8OB7ITRbR2PfNae/G53Oho8pWVuDj2xkLOl8KoaOhE0r1H/ pZJ4MYUKbCSVHxb0TZRpXQBBHcWyO4xvNtPu5bn5wnX/NB5/n3Oxuhm9PL8tXK4CIU9j 965w== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=alibaba.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id z19si3054014edr.437.2021.02.25.02.00.07; Thu, 25 Feb 2021 02:00:30 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=alibaba.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235387AbhBYJT3 (ORCPT + 99 others); Thu, 25 Feb 2021 04:19:29 -0500 Received: from out30-132.freemail.mail.aliyun.com ([115.124.30.132]:57035 "EHLO out30-132.freemail.mail.aliyun.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235525AbhBYJQH (ORCPT ); Thu, 25 Feb 2021 04:16:07 -0500 X-Alimail-AntiSpam: AC=PASS;BC=-1|-1;BR=01201311R211e4;CH=green;DM=||false|;DS=||;FP=0|-1|-1|-1|0|-1|-1|-1;HT=e01e04394;MF=yang.lee@linux.alibaba.com;NM=1;PH=DS;RN=6;SR=0;TI=SMTPD_---0UPXLIzy_1614244524; Received: from j63c13417.sqa.eu95.tbsite.net(mailfrom:yang.lee@linux.alibaba.com fp:SMTPD_---0UPXLIzy_1614244524) by smtp.aliyun-inc.com(127.0.0.1); Thu, 25 Feb 2021 17:15:24 +0800 From: Yang Li To: paul@crapouillou.net Cc: linus.walleij@linaro.org, linux-mips@vger.kernel.org, linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, Yang Li Subject: [PATCH] pinctrl: ingenic: add missing call to of_node_put() Date: Thu, 25 Feb 2021 17:15:22 +0800 Message-Id: <1614244522-64464-1-git-send-email-yang.lee@linux.alibaba.com> X-Mailer: git-send-email 1.8.3.1 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org In one of the error paths of the for_each_child_of_node() loop in ingenic_gpio_probe, add missing call to of_node_put(). Fix the following coccicheck warning: ./drivers/pinctrl/pinctrl-ingenic.c:2485:1-23: WARNING: Function "for_each_child_of_node" should have of_node_put() before return around line 2489. Reported-by: Abaci Robot Signed-off-by: Yang Li --- drivers/pinctrl/pinctrl-ingenic.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/pinctrl/pinctrl-ingenic.c b/drivers/pinctrl/pinctrl-ingenic.c index f274612..b7294a2 100644 --- a/drivers/pinctrl/pinctrl-ingenic.c +++ b/drivers/pinctrl/pinctrl-ingenic.c @@ -2486,6 +2486,7 @@ static int __init ingenic_pinctrl_probe(struct platform_device *pdev) if (of_match_node(ingenic_gpio_of_match, node)) { err = ingenic_gpio_probe(jzpc, node); if (err) + of_node_put(node); return err; } } -- 1.8.3.1