Received: by 2002:a05:6a10:8c0a:0:0:0:0 with SMTP id go10csp273271pxb; Thu, 25 Feb 2021 02:02:10 -0800 (PST) X-Google-Smtp-Source: ABdhPJzN1Uq8CcWAsoU44Qim8VndRIsspu4DFbyibJf/rrS6X0BK0jRi+4Cl86jzQfM9+vJW9p2g X-Received: by 2002:a05:6402:c9a:: with SMTP id cm26mr2001220edb.133.1614247330479; Thu, 25 Feb 2021 02:02:10 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1614247330; cv=none; d=google.com; s=arc-20160816; b=yDND/8Cv6sL29jPfNqHbEDsNi8LVDgEeOumudwuK/fpkTZr6o5sCnocZTkG+eg1qYC ITYNAutaE9Rrqz2DG43raRNVDsnap96H4jROwsehBDlXp/qgklanwupaYmE5yWErKh0t G4aTpCU4tfFMQaODQ+f+Q5OyPMduKNYfClZvABZqkCzknuO1ijM0NBGbz/R9eLgiD6DR /b1C6+9FDM1cPdBAqZzx63G9zLM5B3ZonWb6y5aRWZ0iWd1PhXb/E/HG+CRmfE1j+lEF cudO0nu1rt79yVlNdQDIpwx4jBvuaKQpYo5LMqDWyuMNwt/mkFrgNQLP3+D4Tdz23EsE eueA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:message-id:date:subject:cc:to:from; bh=P2qrcE6G2qICdnhhbra5E9KzvKFrMNNICEY+VMoyxyY=; b=uYgYMHhPQnj/w1hRI9ALmFhGSgYoZwVQDQdJE5HPKtyz6VWyMHayMu8fCH3AHULG5Z hcrhCJ13kv1LFMCrPpsFwnU/psuxzcopwPQDoMuAsSNMwVNGS8izhRaC+bV44KQc1EuP 7X/HXllAXhnr6gstVPaWSbYfLUtw0Fpjgt0l53Se5gwRstcsAIgibzwvR+Kdt22aDg3K HWYV7c9lJzJzlkGeWR/MC1pgw7aY7dey9zDWmS4HttkW90KWBz16zDqsFjttElfjHn69 g0SrTaS7zt8MEVeqPgTWJu3+8uhx19xridk5vxKTPCH65/WaXp0ao8EUdc3M7MCB1X9F lJiQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=alibaba.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id o26si2994624edw.74.2021.02.25.02.01.46; Thu, 25 Feb 2021 02:02:10 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=alibaba.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236185AbhBYJU7 (ORCPT + 99 others); Thu, 25 Feb 2021 04:20:59 -0500 Received: from out30-42.freemail.mail.aliyun.com ([115.124.30.42]:57899 "EHLO out30-42.freemail.mail.aliyun.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236307AbhBYJSl (ORCPT ); Thu, 25 Feb 2021 04:18:41 -0500 X-Alimail-AntiSpam: AC=PASS;BC=-1|-1;BR=01201311R501e4;CH=green;DM=||false|;DS=||;FP=0|-1|-1|-1|0|-1|-1|-1;HT=e01e01424;MF=yang.lee@linux.alibaba.com;NM=1;PH=DS;RN=5;SR=0;TI=SMTPD_---0UPXQzEw_1614244675; Received: from j63c13417.sqa.eu95.tbsite.net(mailfrom:yang.lee@linux.alibaba.com fp:SMTPD_---0UPXQzEw_1614244675) by smtp.aliyun-inc.com(127.0.0.1); Thu, 25 Feb 2021 17:17:56 +0800 From: Yang Li To: p.zabel@pengutronix.de Cc: vkoul@kernel.org, kishon@ti.com, linux-kernel@vger.kernel.org, Yang Li Subject: [PATCH] phy: ti: j721e-wiz: add missing call to of_node_put() Date: Thu, 25 Feb 2021 17:17:54 +0800 Message-Id: <1614244674-66556-1-git-send-email-yang.lee@linux.alibaba.com> X-Mailer: git-send-email 1.8.3.1 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org In one of the error paths of the for_each_child_of_node() loop in of_property_read_u32, add missing call to of_node_put(). Fix the following coccicheck warning: ./drivers/phy/ti/phy-j721e-wiz.c:786:1-23: WARNING: Function "for_each_child_of_node" should have of_node_put() before return around line 795. Reported-by: Abaci Robot Signed-off-by: Yang Li --- drivers/phy/ti/phy-j721e-wiz.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/phy/ti/phy-j721e-wiz.c b/drivers/phy/ti/phy-j721e-wiz.c index c9cfafe..448d8d1 100644 --- a/drivers/phy/ti/phy-j721e-wiz.c +++ b/drivers/phy/ti/phy-j721e-wiz.c @@ -789,6 +789,7 @@ static int wiz_get_lane_phy_types(struct device *dev, struct wiz *wiz) ret = of_property_read_u32(subnode, "reg", ®); if (ret) { + of_node_put(subnode); dev_err(dev, "%s: Reading \"reg\" from \"%s\" failed: %d\n", __func__, subnode->name, ret); -- 1.8.3.1