Received: by 2002:a05:6a10:8c0a:0:0:0:0 with SMTP id go10csp273539pxb; Thu, 25 Feb 2021 02:02:37 -0800 (PST) X-Google-Smtp-Source: ABdhPJxdadf5V4Lgj1N7tCur/Qt09wjqjzWWrfIZM2FT0y3D4hhUj9vleN4/FFmlm056a/KZrIQy X-Received: by 2002:a17:906:b001:: with SMTP id v1mr1898412ejy.217.1614247357116; Thu, 25 Feb 2021 02:02:37 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1614247357; cv=none; d=google.com; s=arc-20160816; b=y+FK1D6sFfFzOJ752mxuxbKihzpAaQDgUl2cxXSc3hBvPfHtxmYj6+nj/uUJXnPNcH T4qJ5FcANlPvnnc5fgiVSG/ltB5qUIIQlJnH0WGKETuV+Z4SmLrGXePUCY9zPxVO3xaj zl3LODtg86KgjLgmU5oSZ47k8x9PtumCMIZfPWUKzJ8SwxBOqN9Lv2NcNwHkYPXuvTkQ rsRY8UxTMbNzCOyXZEkshM1TuNpCjjC4mR1f1gHZL8iLB/V7Ngy/eMpNPnj2lu06c0wF /k83/6CURQUz/uEUWf6RkK+A/b8+BuH8AMeCb4BX/r71M55v7ycGlwPPjPDI7tg8TM0S lBkw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=rRc8kqJLiL0cteqcYhIFKGNwREHFOWiYv8Q/pdnFteg=; b=wMTpHJcMLXdacXdP1ternpfC6l3XmTx73Lt5LL1bSSRmq5ZxbaCLSd0L4Je1yHS4EZ vq6GU9OAdkPDTik87DCmNR1lmKAiACRYo1qAZ2Dxw9EsGLGj5QpzzIrxpKU9nQyhlvGL Spr3rqerB94jAjSW6CwQYtDql3t5+DwA0TLor3eTF04c6JnB4+5aZnZZhaylV/lOMQ+o KtXJk4RNzhrzWMfmgy6tFPgN/T7DZelAqPHdNRr7V9zi3NIHmZ40xPJgHLs0ZAbdGS3z Gq84JkkeGEx7b1cAvaozVky1Exw/n4BjFk00cG7nmAb4OpJtxw6k4pPmTnB07yfI+NUC Sj/g== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=AmZ474y7; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id l7si3076486ejq.16.2021.02.25.02.02.08; Thu, 25 Feb 2021 02:02:37 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=AmZ474y7; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234326AbhBYJkp (ORCPT + 99 others); Thu, 25 Feb 2021 04:40:45 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47322 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233291AbhBYJjd (ORCPT ); Thu, 25 Feb 2021 04:39:33 -0500 Received: from mail-pl1-x62f.google.com (mail-pl1-x62f.google.com [IPv6:2607:f8b0:4864:20::62f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 115D5C061A2D; Thu, 25 Feb 2021 01:33:45 -0800 (PST) Received: by mail-pl1-x62f.google.com with SMTP id s16so2869111plr.9; Thu, 25 Feb 2021 01:33:45 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=rRc8kqJLiL0cteqcYhIFKGNwREHFOWiYv8Q/pdnFteg=; b=AmZ474y7XCT4XraclC/jEJxomJg/vBDaJUYqXxEJoefw9gvSG4N8lBO+mxzfF+Xzf4 6ZMxr9k4p30eGwEWBrbnnAS3mHMFjRk1zrb5POjmbNZNG5TyoGVl3U6mXaaZ/4jLOjvs qum8SjWgrmStNpAY2fskdVM0Ei3aEmiKJPSboTMxw6eVx8moQtdVvEU4+TQxbWnRM1IW fdVC7bsySkGjH2U4juVkVWcqah1u6u7WUq0G1+d/lz/B33js5Br/IDo6znUhr+j1VD3v 8sehKoVY8l+AZI/7bQ4oiCc3yqoBSw1sWKwWxugv6M3lLEO9jzKI84Q/i1DreHTlqbbt efEA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=rRc8kqJLiL0cteqcYhIFKGNwREHFOWiYv8Q/pdnFteg=; b=nQePnFomOw1x0u/1nxrGj5gx/rVhkY3Pr4SvBRMVqdt9st7CJRJWiNhVJM2K27GwYS fPgQwOO7ODhLU6OP4FdfUPmhg4xZJZ1hxv/P+4cKh6mXkkXg3WnP8xZLSpGhQM5lbbWD YWIoD+gi29YRcC4ki/NGBRtHzPQbMjg1kpl3iKe37ymMEiXVuWs0rz4FuXYAI8fVgLJ6 /KiuZ9qVXoWeq/SfJOjWYua1Pssf1xZNuY5gmdI9eFaAQAvXnYIaGby2sVXMwXbcGDio Aq6zQLzA/nNVkOtSRm6lLPLkVvxHEUDKlc6xfex0j+9ggHAn9AgM++dLrZAEoRplCBUI 4/CA== X-Gm-Message-State: AOAM5313F0tqYyP6SkwwUX02uWSXJDKH6HS4PsJq9ftBxkzxaAf/ls6E ONnNKeKddj04uEUy94G7OPY= X-Received: by 2002:a17:902:e54e:b029:e1:2817:f900 with SMTP id n14-20020a170902e54eb02900e12817f900mr2139481plf.15.1614245624464; Thu, 25 Feb 2021 01:33:44 -0800 (PST) Received: from localhost.localdomain ([27.122.242.75]) by smtp.gmail.com with ESMTPSA id e129sm5739463pfh.87.2021.02.25.01.33.42 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Thu, 25 Feb 2021 01:33:44 -0800 (PST) From: Hyeongseok Kim To: namjae.jeon@samsung.com, sj1557.seo@samsung.com Cc: linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, Hyeongseok Kim Subject: [PATCH] exfat: fix erroneous discard when clear cluster bit Date: Thu, 25 Feb 2021 18:33:33 +0900 Message-Id: <20210225093333.144829-1-hyeongseok@gmail.com> X-Mailer: git-send-email 2.27.0.83.g0313f36 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org If mounted with discard option, exFAT issues discard command when clear cluster bit to remove file. But the input parameter of cluster-to-sector calculation is abnormally adds reserved cluster size which is 2, leading to discard unrelated sectors included in target+2 cluster. Fixes: 1e49a94cf707 ("exfat: add bitmap operations") Signed-off-by: Hyeongseok Kim --- fs/exfat/balloc.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/fs/exfat/balloc.c b/fs/exfat/balloc.c index 761c79c3a4ba..41a1dfd9d98a 100644 --- a/fs/exfat/balloc.c +++ b/fs/exfat/balloc.c @@ -186,8 +186,7 @@ void exfat_clear_bitmap(struct inode *inode, unsigned int clu, bool sync) int ret_discard; ret_discard = sb_issue_discard(sb, - exfat_cluster_to_sector(sbi, clu + - EXFAT_RESERVED_CLUSTERS), + exfat_cluster_to_sector(sbi, clu), (1 << sbi->sect_per_clus_bits), GFP_NOFS, 0); if (ret_discard == -EOPNOTSUPP) { -- 2.27.0.83.g0313f36