Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1031086AbWI0WCl (ORCPT ); Wed, 27 Sep 2006 18:02:41 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1031090AbWI0WCk (ORCPT ); Wed, 27 Sep 2006 18:02:40 -0400 Received: from mx1.redhat.com ([66.187.233.31]:49382 "EHLO mx1.redhat.com") by vger.kernel.org with ESMTP id S1031088AbWI0WCh (ORCPT ); Wed, 27 Sep 2006 18:02:37 -0400 Message-ID: <451AF4B5.1090607@sandeen.net> Date: Wed, 27 Sep 2006 17:01:25 -0500 From: Eric Sandeen User-Agent: Thunderbird 1.5.0.7 (X11/20060913) MIME-Version: 1.0 To: Andrew Morton CC: Dave Kleikamp , Jan Kara , Badari Pulavarty , Anton Altaparmakov , sct@redhat.com, linux-fsdevel , lkml , ext4 Subject: Re: [RFC][PATCH] set_page_buffer_dirty should skip unmapped buffers References: <20060901101801.7845bca2.akpm@osdl.org> <1157472702.23501.12.camel@dyn9047017100.beaverton.ibm.com> <20060906124719.GA11868@atrey.karlin.mff.cuni.cz> <1157555559.23501.25.camel@dyn9047017100.beaverton.ibm.com> <20060906153449.GC18281@atrey.karlin.mff.cuni.cz> <1157559545.23501.30.camel@dyn9047017100.beaverton.ibm.com> <20060906162723.GA14345@atrey.karlin.mff.cuni.cz> <1157563016.23501.39.camel@dyn9047017100.beaverton.ibm.com> <20060906172733.GC14345@atrey.karlin.mff.cuni.cz> <1157641877.7725.13.camel@dyn9047017100.beaverton.ibm.com> <20060907223048.GD22549@atrey.karlin.mff.cuni.cz> <1158179120.11112.2.camel@kleikamp.austin.ibm.com> <20060913203817.b6711381.akpm@osdl.org> In-Reply-To: <20060913203817.b6711381.akpm@osdl.org> Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 600 Lines: 18 Andrew Morton wrote: > On Wed, 13 Sep 2006 15:25:19 -0500 > Dave Kleikamp wrote: > >>> +void journal_do_submit_data(struct buffer_head **wbuf, int bufs) >> Is there any reason this couldn't be static? > > Nope. With this change, journal_brelse_array can also be made static in recovery.c, and removed from jbd.h, I think. -Eric - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/