Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH 3/7] regulator: qcom-rpmh: Correct the pmic5_hfsmps515
 buck
To:     satya priya <skakit@codeaurora.org>,
        Andy Gross <agross@kernel.org>,
        Bjorn Andersson <bjorn.andersson@linaro.org>
Cc:     Liam Girdwood <lgirdwood@gmail.com>,
        Mark Brown <broonie@kernel.org>,
        Rob Herring <robh+dt@kernel.org>, rnayak@codeaurora.org,
        linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org,
        devicetree@vger.kernel.org, kgunda@codeaurora.org,
        linux-arm-msm <linux-arm-msm@vger.kernel.org>
References: <1614155592-14060-1-git-send-email-skakit@codeaurora.org>
 <1614155592-14060-4-git-send-email-skakit@codeaurora.org>
From:   Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
Message-ID: <50151f4b-298c-f0ee-a88f-7bdd945ad249@linaro.org>
Date:   Thu, 25 Feb 2021 14:09:58 +0300
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.7.1
MIME-Version: 1.0
In-Reply-To: <1614155592-14060-4-git-send-email-skakit@codeaurora.org>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-GB
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 24/02/2021 11:33, satya priya wrote:
> Correct the REGULATOR_LINEAR_RANGE and n_voltges for
> pmic5_hfsmps515 buck.
> 
> Signed-off-by: satya priya <skakit@codeaurora.org>
> ---
>   drivers/regulator/qcom-rpmh-regulator.c | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/regulator/qcom-rpmh-regulator.c b/drivers/regulator/qcom-rpmh-regulator.c
> index 79a554f..36542c3 100644
> --- a/drivers/regulator/qcom-rpmh-regulator.c
> +++ b/drivers/regulator/qcom-rpmh-regulator.c
> @@ -726,8 +726,8 @@ static const struct rpmh_vreg_hw_data pmic5_ftsmps510 = {
>   static const struct rpmh_vreg_hw_data pmic5_hfsmps515 = {
>   	.regulator_type = VRM,
>   	.ops = &rpmh_regulator_vrm_ops,
> -	.voltage_range = REGULATOR_LINEAR_RANGE(2800000, 0, 4, 16000),
> -	.n_voltages = 5,
> +	.voltage_range = REGULATOR_LINEAR_RANGE(320000, 0, 235, 16000),
> +	.n_voltages = 236,

I've checked the docs for pm8009, the chip which also uses hfsmps515 
regulators. The pdf clearly states that the 'Output voltage operating 
range' is from 2.8 V to 2.85 V.

So we'd probably need to define different versions of HFS515 regulator 
data (like I had to create for pm8009-1).


>   	.pmic_mode_map = pmic_mode_map_pmic5_smps,
>   	.of_map_mode = rpmh_regulator_pmic4_smps_of_map_mode,
>   };
> 


-- 
With best wishes
Dmitry