Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <1614243836-54718-1-git-send-email-yang.lee@linux.alibaba.com>
In-Reply-To: <1614243836-54718-1-git-send-email-yang.lee@linux.alibaba.com>
From:   Krzysztof Kozlowski <krzk@kernel.org>
Date:   Thu, 25 Feb 2021 15:41:58 +0100
Message-ID: <CAJKOXPdyZQfJNKVpga3yw7yxwK0WvMitN51+e-YgOHHJAMkvsw@mail.gmail.com>
Subject: Re: [PATCH] media: exynos4-is: add missing call to of_node_put()
To:     Yang Li <yang.lee@linux.alibaba.com>
Cc:     mchehab@kernel.org, Sylwester Nawrocki <s.nawrocki@samsung.com>,
        linux-media@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
        "linux-samsung-soc@vger.kernel.org" 
        <linux-samsung-soc@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Thu, 25 Feb 2021 at 10:04, Yang Li <yang.lee@linux.alibaba.com> wrote:
>
> In one of the error paths of the for_each_child_of_node() loop in
> fimc_md_parse_one_endpoint, add missing call to of_node_put().
>
> Fix the following coccicheck warning:
> ./drivers/media/platform/exynos4-is/media-dev.c:489:1-23: WARNING:
> Function "for_each_child_of_node" should have of_node_put() before
> return around line 492.
>
> Reported-by: Abaci Robot <abaci@linux.alibaba.com>

Please make the reports public. Otherwise the actual credits should go
to Coccinelle not to some hidden/unknown tool...

> Signed-off-by: Yang Li <yang.lee@linux.alibaba.com>
> ---
>  drivers/media/platform/exynos4-is/media-dev.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/drivers/media/platform/exynos4-is/media-dev.c b/drivers/media/platform/exynos4-is/media-dev.c
> index 8e1e892..467bc69 100644
> --- a/drivers/media/platform/exynos4-is/media-dev.c
> +++ b/drivers/media/platform/exynos4-is/media-dev.c
> @@ -489,6 +489,7 @@ static int fimc_md_parse_port_node(struct fimc_md *fmd,
>         for_each_child_of_node(port, ep) {
>                 ret = fimc_md_parse_one_endpoint(fmd, ep);
>                 if (ret < 0)
> +                       of_node_put(ep);

This is wrong...

Best regards,
Krzysztof