Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH net-next v3 2/3] net: ethernet: rmnet: Support for
 downlink MAPv5 checksum offload
To:     Jakub Kicinski <kuba@kernel.org>,
        Sharath Chandra Vurukala <sharathv@codeaurora.org>
Cc:     davem@davemloft.net, elder@kernel.org, cpratapa@codeaurora.org,
        subashab@codeaurora.org, netdev@vger.kernel.org,
        linux-kernel@vger.kernel.org
References: <1614110571-11604-1-git-send-email-sharathv@codeaurora.org>
 <1614110571-11604-3-git-send-email-sharathv@codeaurora.org>
 <20210224102307.4a484568@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
From:   Alex Elder <elder@ieee.org>
Message-ID: <866808f2-d6aa-f887-a11d-8d9ec741188d@ieee.org>
Date:   Thu, 25 Feb 2021 09:29:16 -0600
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.7.1
MIME-Version: 1.0
In-Reply-To: <20210224102307.4a484568@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 2/24/21 12:23 PM, Jakub Kicinski wrote:
> On Wed, 24 Feb 2021 01:32:50 +0530 Sharath Chandra Vurukala wrote:
>> +/* MAP CSUM headers */
>> +struct rmnet_map_v5_csum_header {
>> +#if defined(__LITTLE_ENDIAN_BITFIELD)
>> +	u8  next_hdr:1;
>> +	u8  header_type:7;
>> +	u8  hw_reserved:7;
>> +	u8  csum_valid_required:1;
>> +#elif defined(__BIG_ENDIAN_BITFIELD)
>> +	u8  header_type:7;
>> +	u8  next_hdr:1;
>> +	u8  csum_valid_required:1;
>> +	u8  hw_reserved:7;
>> +#else
>> +#error	"Please fix <asm/byteorder.h>"
>> +#endif
>> +	__be16 reserved;
>> +} __aligned(1);
> 
> This seems to be your first contribution so let me spell it out.
> 
> In Linux when maintainers ask you to do something you are expected
> to do it.
> 
> You can leave the existing bitfields for later, but don't add another.

As I offered, I will implement changes to the existing
code to use masks in place of these C bit-fields.

I will try complete this within the next week.  If it
looks good it could serve as an example of how to go
about it.

					-Alex