Received: by 2002:a05:6a10:8c0a:0:0:0:0 with SMTP id go10csp501860pxb; Thu, 25 Feb 2021 07:55:20 -0800 (PST) X-Google-Smtp-Source: ABdhPJweUE4iIXdqm8EYc+ce0l41NsYNC5L8NnvchL8VpqydXhNwm0yHogO+DmY2WB9oU24kWeEr X-Received: by 2002:a05:6402:34c1:: with SMTP id w1mr3657340edc.147.1614268520809; Thu, 25 Feb 2021 07:55:20 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1614268520; cv=none; d=google.com; s=arc-20160816; b=u0P1T0rN2kOo4D8xjOH0wA3Thg3rGCjJzf+N5Nu2flNbwhslCsR6ezHUqjkfzENCPc ebboyEoelMp2AK+aJbhrgR7g5BaqRx10yauThj7gcx9x/gF0xEcv/5ObK4oao/aXt4Wa Mwc7E0oRbBH97CvxRYTSFPE2yWNEju7IOlks9OgSaVjT1yT33L1hbSvpVsTCbBpaNH+z l5DhArZzwN6n1ajIDv1U5RunmXPtMGJqXEhZWFq7zM5h2APsOjOIGkH1bpNRwnCWA//R Ef3v4K83lMIZSh8e0SgnWJ7/BwT0WWO4cOMCsIxjbI3YnKLij+RlAoJKkgUjEptgKoTB BCFg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:subject:message-id:date:from:in-reply-to :references:mime-version:dkim-signature; bh=WsCApT+0OPFoE3ROrRo+DSU87MH0YEGSL+XXuxp8A9c=; b=b2ScybCckoa0SmHq3t5U/FmNyj5IHxRsyAa0ftN26N8rzTEpZ81JM0BX+o+qF+rJfc NqroTPFKJPniDgHsYxxI26iSXjOLWVLwajURlVx6AiUkmZf9W1ZDORx3ZhzOLltpXwVn S800ITp/tVXpwBo0J1tyVBia8a03y0NzY0YdSjsPMyqJxOzf1D5bdnCR76VPIhypWGq6 1I/9lWv6FpY0A1lcRZjYwUlvjL52jrkMj513RNEbZUWIb80/kdxtpMmustLwELkuOoGK 835VTKsOAVcqNNjAyxCXmL3sj2m7BE8fRzLRmCET6oJrLuZFdc6NPhl3i6G5W5HwhP/o TS8g== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=mgv1TpTR; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id o9si3513388edh.236.2021.02.25.07.54.57; Thu, 25 Feb 2021 07:55:20 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=mgv1TpTR; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232403AbhBYPxd (ORCPT + 99 others); Thu, 25 Feb 2021 10:53:33 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43290 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230201AbhBYPxa (ORCPT ); Thu, 25 Feb 2021 10:53:30 -0500 Received: from mail-il1-x136.google.com (mail-il1-x136.google.com [IPv6:2607:f8b0:4864:20::136]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3CCF6C061574; Thu, 25 Feb 2021 07:52:49 -0800 (PST) Received: by mail-il1-x136.google.com with SMTP id d5so5327124iln.6; Thu, 25 Feb 2021 07:52:49 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=WsCApT+0OPFoE3ROrRo+DSU87MH0YEGSL+XXuxp8A9c=; b=mgv1TpTReZh9GJn/RTX5tz9dYXg0uGIIww+Mqex2jJ+dwIler9r6R0KH0Phg5kF4W1 1HJ3D+8NuIx8QDA9B8J7RlgErDasp+z7vrTDF22fMsWTK3ckVwNwbjeqvDFr+eEVliPv oFqRAfoWWvvs/WmgjY9nXfp1A20u8bZp2jdEq+4vUgSVwUsRGqaqL7zkSoMmk6i9wyH0 qVSTvdaVzdgt/rrFm/ehS6b9yDWpzSkklmMywV2a1fMsd5p3PrJHGa1BJFCUjiPhtVQd +wwdsycODpqATxEMd69r9yWYl6Z9V5YGZmY+1Jlg1edo47lKhl7AgT2PmJu8wlZo/un9 5NKw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=WsCApT+0OPFoE3ROrRo+DSU87MH0YEGSL+XXuxp8A9c=; b=HjVvJguvLuFqYB8wuo3d855ttha0geneW64kFV5LEwfXPEbcSGFtblNinERY/rfBTA sGmGgP7alzwq137jEAmGEaVtHihNbX4okcFwI215h9TdbrTvo0qkAJqP+Zxnrgyl8MHu D22Y/eJOV1eqg/8gTO0ehZ5k1VbvNe33oLoIxuKERF6kXTyssTkpsIOvRjWWPygCugyh W27Bkw6/kEFGa0tcqI9vOJRzIYSUbyvW7AmQFSXtB39FSXROxSjhestfzm9HygM7d954 B1a1f+bIM20EK3wcg8VsYktOsUxgXIWV440oBWVlq+LP6gKTlrrQvSEnNkAJx2pkUoCw 8GoQ== X-Gm-Message-State: AOAM530S0GTXmoQem3KrPYZdDIcqbXGOom7KrJS5Ktl/RuVHua3+wVAu zgEwnRHyIrZxVs9pObHHx7wc5ZBKws7PouTF8Ik= X-Received: by 2002:a92:cda4:: with SMTP id g4mr3049862ild.20.1614268368748; Thu, 25 Feb 2021 07:52:48 -0800 (PST) MIME-Version: 1.0 References: <20210225143910.3964364-1-arnd@kernel.org> <20210225143910.3964364-3-arnd@kernel.org> In-Reply-To: <20210225143910.3964364-3-arnd@kernel.org> From: DENG Qingfang Date: Thu, 25 Feb 2021 23:52:40 +0800 Message-ID: Subject: Re: [PATCH 3/3] net: dsa: mt7530: add GPIOLIB dependency To: Arnd Bergmann Cc: Andrew Lunn , Vivien Didelot , Florian Fainelli , Vladimir Oltean , "David S. Miller" , Jakub Kicinski , Linus Walleij , Arnd Bergmann , Landen Chao , Sean Wang , netdev , linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Arnd, On Thu, Feb 25, 2021 at 10:40 PM Arnd Bergmann wrote: > > From: Arnd Bergmann > > The new gpio support may be optional at runtime, but it requires > building against gpiolib: > > ERROR: modpost: "gpiochip_get_data" [drivers/net/dsa/mt7530.ko] undefined! > ERROR: modpost: "devm_gpiochip_add_data_with_key" [drivers/net/dsa/mt7530.ko] undefined! > > Add a Kconfig dependency to enforce this. I think wrapping the GPIO code block with #ifdef CONFIG_GPIOLIB ... #endif may be a better idea. > > Fixes: 429a0edeefd8 ("net: dsa: mt7530: MT7530 optional GPIO support") > Signed-off-by: Arnd Bergmann