Received: by 2002:a05:6a10:8c0a:0:0:0:0 with SMTP id go10csp707804pxb; Thu, 25 Feb 2021 13:01:09 -0800 (PST) X-Google-Smtp-Source: ABdhPJwcBjoqYYJl0+mEKewl/BDFmGLEq39q9raKo/giRTzlzyDe+RcN1xW77z40Uq0es3FH39bA X-Received: by 2002:a17:906:4f96:: with SMTP id o22mr4495046eju.511.1614286869717; Thu, 25 Feb 2021 13:01:09 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1614286869; cv=none; d=google.com; s=arc-20160816; b=dfo4SPekKS5D1J5LQzmmRGc+9dwfSwZt5xRpalLAYh2pnJNX8Aql1zz+roVoPlNVDQ 36RVqnEIzSF0ujAC3iv8AB9HCaOa0udZ2LKaVox5kMFjbVKsuKiiTWCBhrXQVRjsUOIy yUSbwHcEudHx45elBaz3igWUAbrlYwZLG5Ygpvv+vMAgEXE8kmvyE8TXhzUdpnJCVobX jV8ndVhD0vsXAGA2VUhXiTSCEifp4QIcTWZXppIxtOwp4s83ZYNjbEei23pQmQeZQGSJ F9PzlcnjEaDfEWdJDtOi76q9JeoUu5sZBcjx1dopb4IKG/i/1yKnF2x83Hy7SJQmMU+p KiPw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:from:subject:references:mime-version :message-id:in-reply-to:date:reply-to:sender:dkim-signature; bh=3dJX6PNMOpcnlHjtSKGQWdqsgIFYjgow6196OCl7MyI=; b=DwxAdhpEZAG9coYNMwqQm2kTwZ3oBdlsT5DpDQTcPe7ZA2V42/dc5Op7e2Ab1rJj6h TorRl7ZzTZvfF3dKZvCNEe6dfMahU87oxmkJwXRf2x9NowoTKymZMOwOd4cRalv+0FDw y2/GFlPp6slisbDKVIZkPtdvzBASoLLT6iNm2p/6d5i/yfHHX2G2q5w4MjpaQ/Tf7jgS nbtIbnmarv0GvC98i7wPfv+LoxYPxfc01GYpHMHAjEKX1ddXQBX1RSHJMVHZMDzlzgPw wPTQXM9+SUPZkHjHcaL/F6ndzKYasQFLPzD809wtZqcMnylxUJHWYyUjK1GDAik46fw2 wNJg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@google.com header.s=20161025 header.b="RY/+cgnB"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id hs7si4268012ejc.349.2021.02.25.13.00.46; Thu, 25 Feb 2021 13:01:09 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@google.com header.s=20161025 header.b="RY/+cgnB"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235279AbhBYU6S (ORCPT + 99 others); Thu, 25 Feb 2021 15:58:18 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50572 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234165AbhBYUuK (ORCPT ); Thu, 25 Feb 2021 15:50:10 -0500 Received: from mail-qv1-xf49.google.com (mail-qv1-xf49.google.com [IPv6:2607:f8b0:4864:20::f49]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id F1712C061225 for ; Thu, 25 Feb 2021 12:48:27 -0800 (PST) Received: by mail-qv1-xf49.google.com with SMTP id er16so5187076qvb.22 for ; Thu, 25 Feb 2021 12:48:27 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=sender:reply-to:date:in-reply-to:message-id:mime-version:references :subject:from:to:cc; bh=3dJX6PNMOpcnlHjtSKGQWdqsgIFYjgow6196OCl7MyI=; b=RY/+cgnBFr699vd/bgYh3VMSoW0aWmYd5U1FT3PNuuKefp5rnFrYcoUcX8rYTpRvhs glQbsL/36w91AWnajZorhypk/30W1X/Tkxb+ykpNSk7IqCRM9wCPbF3y7MgBoy/Usdri fHIQDGUfDRCskexycPUbHMo3WVZi80WW3Rn5RssXXP40un3H3H4L/WJ0PtH0jtlLvCmJ WAP8RbhUeRxlxI82KgYcqTludxwM7NoP2AvbLs71+PtABjc759aEWJjYAtINK0nZvQxB GynmqnhT1836myMc2SYzx+6hMr0btJXwnLl2xdl0JUfzxtib//nHn2yjUILucrvWi/fT jtkg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:reply-to:date:in-reply-to:message-id :mime-version:references:subject:from:to:cc; bh=3dJX6PNMOpcnlHjtSKGQWdqsgIFYjgow6196OCl7MyI=; b=dvvAuLpuqFTV3fLpq/f4n1ShvB7vEBG4btsvnuJvrU6NsMDQWGnrUp7YJgRUmmYg9J KRH2so7g7zruwaGyuptuxC33nSCyliJkIUPZxUFjArSYfe8iRzzG8s7tI7K+F0QColdG vS516uoRAx9N/w4hHKN10Z5vZUzAfuCqNUqUaEeBaGwyHexgtvYOAYCwgplkylziZ9Oj cvisJaRfrpFNZ35fxmqAgsb/zFSCkAXrAMjui4pdlmp/vSxa35x8ebkcQZ+R61WirJ75 bcslE/kOYl4icr7yPS45AAe+FZlaXyrV3h0NMGBqaXszahrK8bq3/IrAcSRLiL+zITuK vxvg== X-Gm-Message-State: AOAM5325HvtZfxh9gVcpWlySWVI94BTPMM4FTw3m1HhC2iBkb2jTNkm3 CBfemZ1IZT2QNuylgloI4QB0qLxQHgU= Sender: "seanjc via sendgmr" X-Received: from seanjc798194.pdx.corp.google.com ([2620:15c:f:10:34c4:7c1d:f9ba:4576]) (user=seanjc job=sendgmr) by 2002:a0c:85c2:: with SMTP id o60mr4568108qva.11.1614286107161; Thu, 25 Feb 2021 12:48:27 -0800 (PST) Reply-To: Sean Christopherson Date: Thu, 25 Feb 2021 12:47:36 -0800 In-Reply-To: <20210225204749.1512652-1-seanjc@google.com> Message-Id: <20210225204749.1512652-12-seanjc@google.com> Mime-Version: 1.0 References: <20210225204749.1512652-1-seanjc@google.com> X-Mailer: git-send-email 2.30.1.766.gb4fecdf3b7-goog Subject: [PATCH 11/24] KVM: x86/mmu: Add module param to disable MMIO caching (for testing) From: Sean Christopherson To: Paolo Bonzini Cc: Sean Christopherson , Vitaly Kuznetsov , Wanpeng Li , Jim Mattson , Joerg Roedel , kvm@vger.kernel.org, linux-kernel@vger.kernel.org, Ben Gardon Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Add a module param to disable MMIO caching so that it's possible to test the related flows without access to the necessary hardware. Using shadow paging with 64-bit KVM and 52 bits of physical address space must disable MMIO caching as there are no reserved bits to be had. Signed-off-by: Sean Christopherson --- arch/x86/kvm/mmu/spte.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/arch/x86/kvm/mmu/spte.c b/arch/x86/kvm/mmu/spte.c index b2379094a8c1..503dec3f8c7a 100644 --- a/arch/x86/kvm/mmu/spte.c +++ b/arch/x86/kvm/mmu/spte.c @@ -17,6 +17,9 @@ #include +static bool __read_mostly enable_mmio_caching = true; +module_param_named(mmio_caching, enable_mmio_caching, bool, 0444); + u64 __read_mostly shadow_nx_mask; u64 __read_mostly shadow_x_mask; /* mutual exclusive with nx_mask */ u64 __read_mostly shadow_user_mask; @@ -251,6 +254,9 @@ void kvm_mmu_set_mmio_spte_mask(u64 mmio_value, u64 mmio_mask, u64 access_mask) BUG_ON((u64)(unsigned)access_mask != access_mask); WARN_ON(mmio_value & shadow_nonpresent_or_rsvd_lower_gfn_mask); + if (!enable_mmio_caching) + mmio_value = 0; + /* * Disable MMIO caching if the MMIO value collides with the bits that * are used to hold the relocated GFN when the L1TF mitigation is -- 2.30.1.766.gb4fecdf3b7-goog