Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Fri, 26 Feb 2021 09:52:37 +0800
From:   Orson Zhai <orsonzhai@gmail.com>
To:     Rob Herring <robh+dt@kernel.org>,
        Baolin Wang <baolin.wang7@gmail.com>,
        Chunyan Zhang <zhang.lyra@gmail.com>,
        Jassi Brar <jassisinghbrar@gmail.com>
Cc:     Mark Brown <broonie@kernel.org>, devicetree@vger.kernel.org,
        linux-kernel@vger.kernel.org, Haidong Yao <yaohaidong369@gmail.com>
Subject: Re: [PATCH v2 0/3] Fixes & a new supplementary feature to SPRD
 mailbox driver
Message-ID: <20210226015237.GA2610@lenovo>
Mail-Followup-To: Rob Herring <robh+dt@kernel.org>,
        Baolin Wang <baolin.wang7@gmail.com>,
        Chunyan Zhang <zhang.lyra@gmail.com>,
        Jassi Brar <jassisinghbrar@gmail.com>,
        Mark Brown <broonie@kernel.org>, devicetree@vger.kernel.org,
        linux-kernel@vger.kernel.org, Haidong Yao <yaohaidong369@gmail.com>
References: <20210213122143.19240-1-orsonzhai@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20210213122143.19240-1-orsonzhai@gmail.com>
User-Agent: Mutt/1.5.24 (2015-08-30)
Precedence: bulk

Hi Baolin,

On Sat, Feb 13, 2021 at 08:21:40PM +0800, Orson Zhai wrote:
> Fix a real problem fot SPRD's mailbox driver in patch 1/3.
> Add supplementary inbox support for newly added sc9863a in patch 3/3 and
> change dt bindings yaml accordingly in patch 2/3.
> 
> Changes Log:
> V2:
> - Change patches order. (Yaml go to the head of dirver)
> - Remove unnecessary initializing refcnt to zero. 
> - Add fix of possible crash caused by NULL of chan->cl. (Actually move from
>   changes to sprd-mailbox.c of patch v1)
> - Remove unnecessary "inline" for do_inbox_isr().
> - Fix yaml errors from Rob's robot checking.
> - Add sc9863a compatible string for real supplementary inbox usage. (sc9860
>   is not supported by supp-inbox)
> - Add more details to supp-inbox in commit messages.

Do you have any comments about this changes to v2?

Thanks,
Orson

> 
> Orson Zhai (3):
>   mailbox: sprd: Introduce refcnt when clients requests/free channels
>   dt-bindings: mailbox: Add interrupt-names to SPRD mailbox
>   mailbox: sprd: Add supplementary inbox support
> 
>  .../bindings/mailbox/sprd-mailbox.yaml        |  18 ++-
>  drivers/mailbox/sprd-mailbox.c                | 135 +++++++++++++-----
>  2 files changed, 117 insertions(+), 36 deletions(-)
> 
> -- 
> 2.17.1
>