Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   "Li, Meng" <Meng.Li@windriver.com>
To:     "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "broonie@kernel.org" <broonie@kernel.org>,
        "rafael@kernel.org" <rafael@kernel.org>
Subject: RE: [PATCH] driver: regmap: set debugfs_name to NULL after it is
 freed
Thread-Topic: [PATCH] driver: regmap: set debugfs_name to NULL after it is
 freed
Thread-Index: AQHXC+VQbKvf23UuvUqged6OHJOU66pps3pQ
Date:   Fri, 26 Feb 2021 02:19:18 +0000
Message-ID: <CO1PR11MB4849153C5E31137CADDD250FF19D9@CO1PR11MB4849.namprd11.prod.outlook.com>
References: <20210226021537.7530-1-Meng.Li@windriver.com>
In-Reply-To: <20210226021537.7530-1-Meng.Li@windriver.com>
Accept-Language: zh-CN, en-US
Content-Language: en-US
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: 3426c9ed-3c2a-4a53-8f96-08d8d9fcebbc
X-MS-Exchange-CrossTenant-originalarrivaltime: 26 Feb 2021 02:19:18.1460
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 8ddb2873-a1ad-4a18-ae4e-4644631433be
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: APPTRLch75dOzydTS8+7Gqs9Py2zIpo4bdSwXQsCTQsl4ygew9Fdn/h7AsSxqrw45iL5V9+gvlY/jLhEXKUHLQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW3PR11MB4555
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Please discard this email. There is a wrong email address in TO list.
I have sent another one.

Thanks,
Limeng

> -----Original Message-----
> From: Li, Meng <Meng.Li@windriver.com>
> Sent: Friday, February 26, 2021 10:16 AM
> To: linux-kernel@vger.kernel.org; broonie@kernel.org;
> regkh@linuxfoundation.org; rafael@kernel.org
> Cc: Li, Meng <Meng.Li@windriver.com>
> Subject: [PATCH] driver: regmap: set debugfs_name to NULL after it is fre=
ed
>=20
> From: Meng Li <Meng.Li@windriver.com>
>=20
> There is a upstream commit cffa4b2122f5("regmap:debugfs:
> Fix a memory leak when calling regmap_attach_dev") that adds a if conditi=
on
> when create name for debugfs_name.
> With below function invoking logical, debugfs_name is freed in
> regmap_debugfs_exit(), but it is not created again because of the if
> condition introduced by above commit.
> regmap_reinit_cache()
> 	regmap_debugfs_exit()
> 	...
> 	regmap_debugfs_init()
> So, set debugfs_name to NULL after it is freed.
>=20
> Fixes: cffa4b2122f5("regmap: debugfs: Fix a memory leak when calling
> regmap_attach_dev")
> Cc: stable@vger.kernel.org
> Signed-off-by: Meng Li <Meng.Li@windriver.com>
> ---
>  drivers/base/regmap/regmap-debugfs.c | 1 +
>  1 file changed, 1 insertion(+)
>=20
> diff --git a/drivers/base/regmap/regmap-debugfs.c
> b/drivers/base/regmap/regmap-debugfs.c
> index 398991381e9a..4f2ff1b2b450 100644
> --- a/drivers/base/regmap/regmap-debugfs.c
> +++ b/drivers/base/regmap/regmap-debugfs.c
> @@ -661,6 +661,7 @@ void regmap_debugfs_exit(struct regmap *map)
>  		regmap_debugfs_free_dump_cache(map);
>  		mutex_unlock(&map->cache_lock);
>  		kfree(map->debugfs_name);
> +		map->debugfs_name =3D NULL;
>  	} else {
>  		struct regmap_debugfs_node *node, *tmp;
>=20
> --
> 2.17.1