Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Mime-Version: 1.0
Subject: RE: Re: [PATCH v24 1/4] scsi: ufs: Introduce HPB feature
Reply-To: daejun7.park@samsung.com
Sender: Daejun Park <daejun7.park@samsung.com>
From:   Daejun Park <daejun7.park@samsung.com>
To:     Bean Huo <huobean@gmail.com>,
        Daejun Park <daejun7.park@samsung.com>,
        Greg KH <gregkh@linuxfoundation.org>,
        "avri.altman@wdc.com" <avri.altman@wdc.com>,
        "jejb@linux.ibm.com" <jejb@linux.ibm.com>,
        "martin.petersen@oracle.com" <martin.petersen@oracle.com>,
        "asutoshd@codeaurora.org" <asutoshd@codeaurora.org>,
        "stanley.chu@mediatek.com" <stanley.chu@mediatek.com>,
        "cang@codeaurora.org" <cang@codeaurora.org>,
        "bvanassche@acm.org" <bvanassche@acm.org>,
        ALIM AKHTAR <alim.akhtar@samsung.com>
CC:     "linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        JinHwan Park <jh.i.park@samsung.com>,
        Javier Gonzalez <javier.gonz@samsung.com>,
        SEUNGUK SHIN <seunguk.shin@samsung.com>,
        Sung-Jun Park <sungjun07.park@samsung.com>,
        yongmyung lee <ymhungry.lee@samsung.com>,
        Jinyoung CHOI <j-young.choi@samsung.com>,
        BoRam Shin <boram.shin@samsung.com>
In-Reply-To: <50f8a0963e887542a467e690b6d406675279a4e5.camel@gmail.com>
Message-ID: <20210226044923epcms2p1fa387ff8d1eaac09a8cce146d63ea205@epcms2p1>
Date:   Fri, 26 Feb 2021 13:49:23 +0900
Content-Transfer-Encoding: 7bit
Content-Type: text/plain; charset="utf-8"
CMS-TYPE: 102P
DLP-Filter: Pass
References: <50f8a0963e887542a467e690b6d406675279a4e5.camel@gmail.com>
        <20210224045323epcms2p66cc6a4b73086621e050da37f12f432f0@epcms2p6>
        <20210224045405epcms2p2d05f8563b1f121d2c2cc79b343e5af77@epcms2p2>
        <CGME20210224045323epcms2p66cc6a4b73086621e050da37f12f432f0@epcms2p1>
Precedence: bulk

> > 
> > +void ufshpb_init(struct ufs_hba *hba)
> > +{
> > +        struct ufshpb_dev_info *hpb_dev_info = &hba->ufshpb_dev;
> > +        int try;
> > +        int ret;
> > +
> > +        if (!ufshpb_is_allowed(hba))
> > +                return;
> > +
>  
> Here it is better to check "dev_info->hpb_enable", if HPB is not
> enabled from UFS device level,  doesn't need to create mempool and take
> other memory resource.

I will add checking dev_info->hpb_enable value.
if (!ufshpb_is_allowed(hba) || !dev_info->hpb_enable)

Thanks,
Daejun

> Bean
>  
>  
>  
>  
>  
>