Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Mime-Version: 1.0
Subject: RE: Re: [PATCH v24 2/4] scsi: ufs: L2P map management for HPB read
Reply-To: daejun7.park@samsung.com
Sender: Daejun Park <daejun7.park@samsung.com>
From:   Daejun Park <daejun7.park@samsung.com>
To:     Bean Huo <huobean@gmail.com>,
        Daejun Park <daejun7.park@samsung.com>,
        Greg KH <gregkh@linuxfoundation.org>,
        "avri.altman@wdc.com" <avri.altman@wdc.com>,
        "jejb@linux.ibm.com" <jejb@linux.ibm.com>,
        "martin.petersen@oracle.com" <martin.petersen@oracle.com>,
        "asutoshd@codeaurora.org" <asutoshd@codeaurora.org>,
        "stanley.chu@mediatek.com" <stanley.chu@mediatek.com>,
        "cang@codeaurora.org" <cang@codeaurora.org>,
        "bvanassche@acm.org" <bvanassche@acm.org>,
        ALIM AKHTAR <alim.akhtar@samsung.com>
CC:     "linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        JinHwan Park <jh.i.park@samsung.com>,
        Javier Gonzalez <javier.gonz@samsung.com>,
        SEUNGUK SHIN <seunguk.shin@samsung.com>,
        Sung-Jun Park <sungjun07.park@samsung.com>,
        yongmyung lee <ymhungry.lee@samsung.com>,
        Jinyoung CHOI <j-young.choi@samsung.com>,
        BoRam Shin <boram.shin@samsung.com>
In-Reply-To: <23b7d59df2b83cdac53fdb4567c41c007257b436.camel@gmail.com>
Message-ID: <20210226045335epcms2p4beca6dda1e809534ac510926362e913c@epcms2p4>
Date:   Fri, 26 Feb 2021 13:53:35 +0900
Content-Transfer-Encoding: 7bit
Content-Type: text/plain; charset="utf-8"
CMS-TYPE: 102P
DLP-Filter: Pass
References: <23b7d59df2b83cdac53fdb4567c41c007257b436.camel@gmail.com>
        <20210224045323epcms2p66cc6a4b73086621e050da37f12f432f0@epcms2p6>
        <20210224045437epcms2p7ed0a41233d899337ddbd3525fddeb042@epcms2p7>
        <CGME20210224045323epcms2p66cc6a4b73086621e050da37f12f432f0@epcms2p4>
Precedence: bulk

> > +static int ufshpb_init_mem_wq(void)
> > +{
> > +       int ret;
> > +       unsigned int pool_size;
> > +
> > +       ufshpb_mctx_cache = kmem_cache_create("ufshpb_mctx_cache",
> > +                                       sizeof(struct
> > ufshpb_map_ctx),
> > +                                       0, 0, NULL);
> > +       if (!ufshpb_mctx_cache) {
> > +               pr_err("ufshpb: cannot init mctx cache\n");
> > +               return -ENOMEM;
> > +       }
> > +
> > +       pool_size = PAGE_ALIGN(ufshpb_host_map_kbytes * 1024) /
> > PAGE_SIZE;
> > +       pr_info("%s:%d ufshpb_host_map_kbytes %u pool_size %u\n",
> > +              __func__, __LINE__, ufshpb_host_map_kbytes,
> > pool_size);
> > +
> 
> I think print function name is not proper while booting.
> And one HPB is associated with one HBA, if there are two UFS
> controllers, how can I differentiate them? 

I will use dev_info instead of pr_info.

Thanks,
Daejun

> Bean
> 
> 
>