Received: by 2002:a05:6a10:8c0a:0:0:0:0 with SMTP id go10csp966867pxb; Thu, 25 Feb 2021 21:56:30 -0800 (PST) X-Google-Smtp-Source: ABdhPJzTfiZGqpTrX3C82IogjuUTI0dKqFGArwhA/fmMD1UFGxO62PY33Q2HcM4GjBXhjJOB7Dq8 X-Received: by 2002:a05:6402:1455:: with SMTP id d21mr1491102edx.192.1614318990457; Thu, 25 Feb 2021 21:56:30 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1614318990; cv=none; d=google.com; s=arc-20160816; b=xAptjP690SLvRb8pcClpI/M9RoeXwcUj4rdC563qoH0lt3WST31x3m9fNe8+TixufV ow7CWekP5cAeE9zr9HSPXL9lzH+Czg4RcNjax1RsViTvkSscTowvzLwT88egTE6tGsTa HkrAeGGsWvEosQdbfZDkh2kpv2Bg2PvFEmBaQOUS3Scs7ZJvFrTgT4zJsxGEB3L2eJ09 pym+0tBQhp+cOQpZmv3+BC0jrcHPgpoSj8qRzses7MiyCTbM9nen5rPg5OJuKhVWeLRR U13WJhlnE9jNCrWAsJG6Wanl3kczEOy2X3lBSeTDjvDIXgyD1dRshahzL0f2GewcpNo/ lWCQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:user-agent:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date; bh=zMzJQ6bAWIKXk6TmatwxS/pIsEMYLiOA18thCObGq/0=; b=TYnK8bJB7ifOvgOIwvVI/yLeSk94eFT5YtZkp/IQCEfqHRlcuH6+BM8fWCmLwpzHwZ jfZbcEl1QjL/2KYS/vaKrRHtdko5Dqc7IUM5PEdo/jnk50H0bWXy9mgPsCm4ZqpmjaCA yi2AQF8bHJvr0vLmOjpjdru6yD0iOxuRz4kRWpHsbmaVRtinY7SaGF62BaGueC6BaVED 16txpHhRrZpn6DuTPQ9zVvx6PTNM4czrz0JHfjZ7fav9I5Ao5R5D0ladtHGnr/W8Fn6d DKOyKFRo/R7l77OdUPw0HSpZD+Pqst6tCme/UIViOvXN1OT/OX7f65gt8LEWL1krJwgC 9g8Q== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id dr8si5112286ejc.138.2021.02.25.21.56.07; Thu, 25 Feb 2021 21:56:30 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229795AbhBZFyh (ORCPT + 99 others); Fri, 26 Feb 2021 00:54:37 -0500 Received: from verein.lst.de ([213.95.11.211]:44552 "EHLO verein.lst.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229586AbhBZFyg (ORCPT ); Fri, 26 Feb 2021 00:54:36 -0500 Received: by verein.lst.de (Postfix, from userid 2407) id EDBE568BEB; Fri, 26 Feb 2021 06:53:52 +0100 (CET) Date: Fri, 26 Feb 2021 06:53:52 +0100 From: Christoph Hellwig To: Alan Stern Cc: Tom Yan , Hans de Goede , Christoph Hellwig , linux-usb , Linux Kernel Mailing List , SCSI development list Subject: Re: [PATCH 2/2] usb-storage: revert from scsi_add_host_with_dma() to scsi_add_host() Message-ID: <20210226055352.GA2996@lst.de> References: <186eb035-4bc4-ff72-ee41-aeb6d81888e3@redhat.com> <20201130172004.GA966032@rowland.harvard.edu> <20201130203618.GB975529@rowland.harvard.edu> <20210225163557.GC1350993@rowland.harvard.edu> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210225163557.GC1350993@rowland.harvard.edu> User-Agent: Mutt/1.5.17 (2007-11-01) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Feb 25, 2021 at 11:35:57AM -0500, Alan Stern wrote: > This thread seems to have fallen through the cracks. Maybe now would be > a good time to address the problem (since we originally planned to fix > it in 5.11!). > > The questions listed below are pretty self-contained, although the rest > of the discussion isn't. But I never received any answers. usb-storage must use scsi_add_host_with_dma to use the right device for DMA mapping and parameters. The calls to set the DMA options on the device are needed so that IOMMU merging doesn't change the imposed requirements. If these requirements slow you down you need to relax them, as apparently the hardware is able to handle bigger limits.