Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Fri, 26 Feb 2021 15:58:36 +0900
From:   William Breathitt Gray <vilhelm.gray@gmail.com>
To:     Oleksij Rempel <o.rempel@pengutronix.de>
Cc:     devicetree@vger.kernel.org, Ahmad Fatoum <a.fatoum@pengutronix.de>,
        linux-iio@vger.kernel.org,
        Robin van der Gracht <robin@protonic.nl>,
        Linus Walleij <linus.walleij@linaro.org>,
        linux-kernel@vger.kernel.org, Rob Herring <robh+dt@kernel.org>,
        Pengutronix Kernel Team <kernel@pengutronix.de>,
        David Jander <david@protonic.nl>,
        Jonathan Cameron <jic23@kernel.org>
Subject: Re: [PATCH v5 2/2] counter: add IRQ or GPIO based event counter
Message-ID: <YDicHHebw9scA7to@shinobu>
References: <YCjlPhEtyH+vfSi4@shinobu>
 <20210215091737.fx6dwiz7tt56wbkr@pengutronix.de>
 <YDMMJJ985Zq9oEOv@shinobu>
 <20210223100656.efbshsh5bz66uhj5@pengutronix.de>
 <20210223174516.wjlh7hnrd5qe5s6w@pengutronix.de>
 <YDW7Hihg0gGQh8UR@shinobu>
 <20210224073506.GA24260@pengutronix.de>
 <YDYKF7zdyjZX30gX@shinobu>
 <YDYMRVgC3BrjISKU@shinobu>
 <20210226064601.io6tznddikhcmvb3@pengutronix.de>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="Pis9j1JpD2v1lmaJ"
Content-Disposition: inline
In-Reply-To: <20210226064601.io6tznddikhcmvb3@pengutronix.de>
Precedence: bulk


--Pis9j1JpD2v1lmaJ
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Fri, Feb 26, 2021 at 07:46:01AM +0100, Oleksij Rempel wrote:
> On Wed, Feb 24, 2021 at 05:20:21PM +0900, William Breathitt Gray wrote:
> > On Wed, Feb 24, 2021 at 05:11:03PM +0900, William Breathitt Gray wrote:
> > > On Wed, Feb 24, 2021 at 08:35:06AM +0100, Oleksij Rempel wrote:
> > > > On Wed, Feb 24, 2021 at 11:34:06AM +0900, William Breathitt Gray wr=
ote:
> > > > > Alternatively, we can take a more generic approach: ignore the GP=
IO
> > > > > names and focus solely on the IRQ lines; because the GPIO lines w=
ill
> > > > > always be tied to respective IRQ lines here, using the IRQ as the=
 basis
> > > > > of the name should always be valid. The "name" member of the stru=
ct
> > > > > irq_chip can work for this. I haven't tested this, but I think so=
mething
> > > > > like this would work:
> > > > >=20
> > > > > 	cnt_signals[0].name =3D irq_get_chip(priv->irq)->name;
> > > >=20
> > > > ok, i'll take a look at it.
> > >=20
> > > If that doesn't work, then use devm_kasprintf() to generate the name
> > > based on the IRQ line number. The idea here is that the user should be
> > > able to identify that the Signal component for this Count is the
> > > respective IRQ.
> > >=20
> > > William Breathitt Gray
> >=20
> > I realized that these irq_chip names are often just the device name
> > which isn't very useful either. :-(
> >=20
> > In that case, I suppose we really are just left with generating the name
> > based on the IRQ line number then. This should be fine then:
> >=20
> > 	cnt_signals[0].name =3D devm_kasprintf(dev, GFP_KERNEL, "IRQ %d",
> > 					     priv->irq);
> > 	if (!cnt_signals[0].name)
> > 		return -ENOMEM;
> >=20
> > I think this would make it clear to the user that this Signal is the
> > respective IRQ (whether sourced from GPIO or not).
>=20
> ack, with one correction. cnt_signals should be allocated, otherwise
> this value will be set per driver not per device.
>=20
> Regards,
> Oleksij
> --=20
> Pengutronix e.K.                           |                             |
> Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
> 31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
> Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

Yes you're right, cnt_signals will need to be allocated then because
these will be different per device.

Thanks,

William Breathitt Gray

--Pis9j1JpD2v1lmaJ
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEk5I4PDJ2w1cDf/bghvpINdm7VJIFAmA4nBwACgkQhvpINdm7
VJKExg//b27mkhYXkMNHzSL6sQeEllxjr3OIkBcSDhPQAzVH5SGVTO1q4Oqeo2YZ
FXLwk3LeKc/gewbqqnE/cBOgWT7iySRUp8ppBtjarqr54ftpKjtV4zaLGzeveoHB
wZpu1FzOr0FZs85CO3xJVzPALZtqdOtSgXkOn4fV3Ee6Oz4DQuHND5Jlqm0gkyFV
FRedDngp7sCN3s8k5y7V/yvaQlrkrNqyn9lqY+hYc+F/uSfg5ODSZlicNPe/L0+8
bPqy2fV0bRr7iCgCadlAMZn9fmv0yPMcrvW5QMbcQaSP9KJZe9oXaE+ockD1mKY8
OlvFMaimQYe2PHVCCIRTqea8YGbB1BUZLMvFKSDG4OvB2yqZWIqWq0vxmcOjhSwN
RIdzDVbvfpGOZDpAizW1Upe3ctgy35Bff7QYob8kHkL8CdxLeNhkteTHWUvJjzMN
qrk0jfboNVNt9BCTP9cpj2kxFet4d4541KFijLqPoQas2+x8qRM0htG1ZpWP5Cve
beR5A8HOd7NXZzYiy42fIO510ySfUvs3iX5YHh1gZRcBYnd8j9sO3ojbQmkyKQ79
U2EUPEVwws3OIfcd6/jMc2QwWtzTsSHq3OU/SP762nv2IO+/P5Il6NYS1cSOAMC8
3xl7WlDVnmvxjQQ6QXR97qgrC4ufBtekqdH3+wqV00MYnxNb9DU=
=MF5Y
-----END PGP SIGNATURE-----

--Pis9j1JpD2v1lmaJ--