Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
IronPort-SDR: qaprJXd/WHT+lyWz4aML0kB8JVH7uyptXHMyVMXdJMrbjpU6ldx+ikr6hF/3Vh4cwLMRtcYGsh
 fwojopqpMUEjj4eJ3liThlSw4ZIwUovKPeXl61pQXMCdxH/vsYDAkTEDMhJRF2GqDj/pA6KEex
 fCM9/2opn0w9pP1t52+lZhH4SDZaBfXp3h0PftPAQ2J+b16XWgL8Bpf5P7QQN6yX2Q/Ps2LHnb
 jfH7Md3qXxNVD/3EiGFrbu/KNqeNvOC1oksNm6fC9r0mO6Eu9Muj+hHHXIF3KQarGpeF1rcR1c
 mVk=
Message-ID: <1f33bcd26589c3a2fd85c195837bdc52c6ec6492.camel@microchip.com>
Subject: Re: [PATCH v6 2/3] reset: mchp: sparx5: add switch reset driver
From:   Steen Hegelund <steen.hegelund@microchip.com>
To:     Alexandre Belloni <alexandre.belloni@bootlin.com>
CC:     Philipp Zabel <p.zabel@pengutronix.de>,
        Andrew Lunn <andrew@lunn.ch>,
        Microchip Linux Driver Support <UNGLinuxDriver@microchip.com>,
        "Gregory Clement" <gregory.clement@bootlin.com>,
        <linux-kernel@vger.kernel.org>,
        <linux-arm-kernel@lists.infradead.org>
Date:   Fri, 26 Feb 2021 09:02:52 +0100
In-Reply-To: <YDgLTczzqTBCwEUY@piout.net>
References: <20210225095005.1510846-1-steen.hegelund@microchip.com>
         <20210225095005.1510846-3-steen.hegelund@microchip.com>
         <YDgLTczzqTBCwEUY@piout.net>
Content-Type: text/plain; charset="UTF-8"
User-Agent: Evolution 3.38.4 
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Precedence: bulk

Hi Alex,

On Thu, 2021-02-25 at 21:40 +0100, Alexandre Belloni wrote:
> EXTERNAL EMAIL: Do not click links or open attachments unless you
> know the content is safe
> 
> Hello,
> 
> > 

...

> > +static int mchp_sparx5_map_io(struct platform_device *pdev, char
> > *name,
> > +                           struct regmap **target)
> > +{
> > +     struct resource *res;
> > +     struct regmap *map;
> > +     void __iomem *mem;
> > +
> > +     res = platform_get_resource_byname(pdev, IORESOURCE_MEM,
> > name);
> > +     if (!res) {
> > +             dev_err(&pdev->dev, "No '%s' resource\n", name);
> > +             return -ENODEV;
> > +     }
> > +     mem = devm_ioremap(&pdev->dev, res->start, res->end - res-
> > >start + 1);
> > +     if (!mem) {
> > +             dev_err(&pdev->dev, "Could not map '%s' resource\n",
> > name);
> > +             return -ENXIO;
> > +     }
> 
> Someone is going to tell you to use
> devm_platform_get_and_ioremap_resource so it may as well be me ;)

Very nice.
Thanks for the info.  I will use that instead.

> 
> --
> Alexandre Belloni, co-owner and COO, Bootlin
> Embedded Linux and Kernel engineering
> https://bootlin.com

-- 
BR
Steen

-=-=-=-=-=-=-=-=-=-=-=-=-=-=
steen.hegelund@microchip.com