Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751602AbWI1FDk (ORCPT ); Thu, 28 Sep 2006 01:03:40 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751601AbWI1FDj (ORCPT ); Thu, 28 Sep 2006 01:03:39 -0400 Received: from mail4.hitachi.co.jp ([133.145.228.5]:14985 "EHLO mail4.hitachi.co.jp") by vger.kernel.org with ESMTP id S1751599AbWI1FDi (ORCPT ); Thu, 28 Sep 2006 01:03:38 -0400 Message-Type: Multiple Part MIME-Version: 1.0 Message-ID: Content-Type: text/plain; charset="us-ascii" To: "Alan Cox" From: Cc: "Jesse Barnes" , , , , , Date: Thu, 28 Sep 2006 14:03:22 +0900 References: <1159359135.11049.341.camel@localhost.localdomain> Importance: normal Subject: Re[2]: [PATCH 2.6.18] IA64: Add pci_fixup_video into IA64 kernel forembedded VGA X400-Content-Identifier: X451B578F00000M X400-MTS-Identifier: [/C=JP/ADMD=HITNET/PRMD=HITACHI/;gmml16060928140311JPK] Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1078 Lines: 29 >Ar Mer, 2006-09-27 am 20:23 +0900, ysgrifennodd >eiichiro.oiwa.nm@hitachi.com: >> I moved pci_fixup_video to generic location (driver/pci/quirks.c). >> I tested generic fixup_video on x86, x86_64 and IA64, and confirmed >> we can read Video BIOS from the sysfs rom with embedded VGA. > >Lots of embedded systems don't have a PCI bios in the usual sense, and >cannot run the x86 code in the ROM firmware either. That doesn't appear >to be a big problem when setting PCI_ROM_SHADOW but those platforms may >not all be able to access the shadow rom if one exists. > >Can you fix the comment in drivers/pci/rom.c to reflect the changes. > >Otherwise looks good. > >Alan > Thank you for some good advise. I changed this subject to appropriate one: [PATCH 2.6.18] PCI: Turn pci_fixup_video into generic for embedded VGA Thanks, Eiichiro - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/