Received: by 2002:a05:6a10:8c0a:0:0:0:0 with SMTP id go10csp1088852pxb; Fri, 26 Feb 2021 02:09:53 -0800 (PST) X-Google-Smtp-Source: ABdhPJxykF/jQifO3y1ByaOsdgLL9aSDiBd2eKmVMBAPgSsDyQ2dCjg3mS+cRdpgl/mVscal2OPr X-Received: by 2002:a17:906:8043:: with SMTP id x3mr2394498ejw.149.1614334193173; Fri, 26 Feb 2021 02:09:53 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1614334193; cv=none; d=google.com; s=arc-20160816; b=b6pgJIKtRuOC7IzU2oKWBLTHQUZnX9tit442fdw1eAfb/paZFDYcnqmDapUsjjxHQV s8viQXXx36R8FubTOlj2z9qxRnMvJUUYc319h9Uk4zCmwv9Yd39SYd/+hfjsLeDVbD4/ BIEWr1SmgHSMB65yG5IPUJr+OShD5XfmylcXbi9T7IFBVjJNwuscnlJVG9H3FlA3pycY GDYF68XrAA4UqBTjAgE1UUuqHtRC7hw9ZrPiMpJ/a9cJHNNZDndIkSa4v3Co5xK6L+kI 8B2qVbQv5BL+T92oFL3/ZwDjRb9Cwjn+vj0bxIHV53q/OapchI0x6cVZX4fy85HtoZyQ R5Eg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:content-language :in-reply-to:mime-version:user-agent:date:message-id:references:cc :to:from:subject; bh=GgFVlPFl7HJYRARXV4TVXC7XTaVXPk7+JnPabBnbU00=; b=bEBllQZt4gCz5OCgkuVHgOMpQHbtf88gSiOVbWVKQOsfw5aAkovuun5Izvi8WfNmSq 5o9O66W8BfsnAy5VBejJ3gDH/FCOBJlckBg2BC2lzg1IZf1GAiQjm/AOZuqVv+A+JOME IwLWgIxqmjrNcp0dqhCzXOqlNDP9iZ61zhCnAq4A1kr3kmVMi5m6Wul/GLxVBlFMpCRk F2lsd/4i8v3HoMTeQurpHYHim2k2ODQdOf5n4SX5RTrJ95b8I/10r/fSLMDKCYrpI/9D +/kYO4p2pUWcLsiRXxGx5PSA62eV1jb+d3m8uFl52YzaP10ZXUwdanYwajQE9FSYbtIs YRnA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id rp21si5742482ejb.563.2021.02.26.02.09.31; Fri, 26 Feb 2021 02:09:53 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230455AbhBZKIH (ORCPT + 99 others); Fri, 26 Feb 2021 05:08:07 -0500 Received: from mx2.suse.de ([195.135.220.15]:60666 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230124AbhBZKEv (ORCPT ); Fri, 26 Feb 2021 05:04:51 -0500 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 6A08BAF3F; Fri, 26 Feb 2021 10:04:09 +0000 (UTC) Subject: Re: [PATCH][RFC] perf annotate: show full line locations with 'k' in UI From: =?UTF-8?Q?Martin_Li=c5=a1ka?= To: Arnaldo Carvalho de Melo Cc: linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org References: <9acb63e0-af38-eeeb-157e-32f6177da557@suse.cz> <20210212203408.GH1398414@kernel.org> <5b59c46e-4907-7ab9-a68d-dd234e988dc7@suse.cz> Message-ID: Date: Fri, 26 Feb 2021 11:04:09 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.7.1 MIME-Version: 1.0 In-Reply-To: <5b59c46e-4907-7ab9-a68d-dd234e988dc7@suse.cz> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org May I please ping this? Thanks On 2/15/21 1:34 PM, Martin Liška wrote: > On 2/12/21 9:34 PM, Arnaldo Carvalho de Melo wrote: >> Another idea is to, when requested, reserve one line at the bottom to >> show what is the source codefile:line  for where the TUI cursor is, i.e. >> you press down/up and the line under the cursor has its sourcefile:line >> shown at the second (from bottom to top) line in the screen. > > Hello. > > I decided to use the footer bar and a full location is displayed when 'l' > hokey is pressed. I think it's quite rare feature, so on demand footer > line usage should be an appropriate place. > > Thoughts? > Thanks, > Martin