Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <1614302920-19505-1-git-send-email-yang.lee@linux.alibaba.com>
In-Reply-To: <1614302920-19505-1-git-send-email-yang.lee@linux.alibaba.com>
From:   Krzysztof Kozlowski <krzk@kernel.org>
Date:   Fri, 26 Feb 2021 11:29:23 +0100
Message-ID: <CAJKOXPf9kqOSng5XULJ8qTADfk3VB273dTqY2qoUA3b+MUPJ+g@mail.gmail.com>
Subject: Re: [PATCH v2] media: exynos4-is: add missing call to of_node_put()
To:     Yang Li <yang.lee@linux.alibaba.com>
Cc:     mchehab@kernel.org, Sylwester Nawrocki <s.nawrocki@samsung.com>,
        linux-media@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
        "linux-samsung-soc@vger.kernel.org" 
        <linux-samsung-soc@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Fri, 26 Feb 2021 at 02:28, Yang Li <yang.lee@linux.alibaba.com> wrote:
>
> In one of the error paths of the for_each_child_of_node() loop in
> fimc_md_parse_one_endpoint, add missing call to of_node_put().
>
> Fix the following coccicheck warning:
> ./drivers/media/platform/exynos4-is/media-dev.c:489:1-23: WARNING:
> Function "for_each_child_of_node" should have of_node_put() before
> return around line 492.
>
> Reported-by: Abaci Robot <abaci@linux.alibaba.com>

You ignored the comment for this. Anyone can run Coccinelle and it
does not equal "Reported-by" credit. Reported by is for reported bugs,
but I asked three times to you guys to share the reports. This is not
an open way of working.

This should be removed.

Best regards,
Krzysztof