Received: by 2002:a05:6a10:8c0a:0:0:0:0 with SMTP id go10csp1106960pxb; Fri, 26 Feb 2021 02:43:55 -0800 (PST) X-Google-Smtp-Source: ABdhPJz/1pwJ6HiC7ntNlIR17sjqjfeOmNqmC0jgJsmbCGPOh+zQwW3g+IMUQES7J3DMU2XctDhL X-Received: by 2002:a17:906:3088:: with SMTP id 8mr2538120ejv.499.1614336235399; Fri, 26 Feb 2021 02:43:55 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1614336235; cv=none; d=google.com; s=arc-20160816; b=p/ZiAKlSmSR/o6CDpf/5TWZX3frTu2SJQfZ/u7PGnfF3kUkrDZeJxNOic5OJaJmv4p ho83hrfYVxLddQSZFMLi4wwHPZdk43qUy//2xvXKbEZ4rvk1co+KqQ83FFr2+EW48DQB S3lTUZLhDHMY0ESkKIFGPQSjbsP/DsMzXJrq5wrWjuoBSaGfHWoBNU0G6pFIMFfpTV7U R6KpXFCO+jp1otKsOBhAzAUYOeE+GU7oM+ppnZF4hivfFsxTLPBdviID+cC43Tidu65x L1VTF//ockoN2Toj2ZV0e8bygAEI6xAVRdRekEOPMMYNrVqrjMsBUU+pD4XwA6S/4B7Q +biw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:cc:to:subject :message-id:date:from:in-reply-to:references:mime-version :dkim-signature; bh=qtsNbxlwWusja+8qgfUIhAWUqV+NaDdmvSMT4ORU/CQ=; b=Tam1u9r7dqGuNpAQXPpQzuJ1+EdPkDMtkzBgshpH/vhGDxVDhB86Ydbn/wbPwwLo4F JsWZzxASigoV2HzPqHEJ8lw/yPv/ATTYdGXCP4SJxje/1CwTEjBX3by5C58XkcBD1c5O NkukqHdwTzwvI58KpYRVhyYlCWTQFND78vhGTBAM/9soQwM2LUMI2CM0s6A9lKyKXAd7 8ByxZ6/UocKWTS4TeEUcwtXVLvpAzLH7cLXcBNkqFIf/2kTps3f+q8brloUrcvJTM5LG naHp8yaEUzywxf0c6yErU73hVLuw8hgBUQktF5HSI8l41/0LtQZB20QyTJw0bKwCvfhe m4pQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=GBkGz5QJ; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id bx28si5185081edb.167.2021.02.26.02.43.33; Fri, 26 Feb 2021 02:43:55 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=GBkGz5QJ; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230490AbhBZKk4 (ORCPT + 99 others); Fri, 26 Feb 2021 05:40:56 -0500 Received: from mail.kernel.org ([198.145.29.99]:51216 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230225AbhBZKky (ORCPT ); Fri, 26 Feb 2021 05:40:54 -0500 Received: by mail.kernel.org (Postfix) with ESMTPSA id 8FF0C64EFA; Fri, 26 Feb 2021 10:40:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1614336013; bh=qtsNbxlwWusja+8qgfUIhAWUqV+NaDdmvSMT4ORU/CQ=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=GBkGz5QJPyHmuazztCt0WheomivNVsz6a+EE6GjVbz7QUGYOl/8tu8D6GSm3l5CfX MmrOTKLmeAUMq3Avcl4vZzY4kr1sbXasCvKE+jK54PsKtftTikuFfG5n78a5sobKfK mCiM+RA4eQ1U2KKuZFIE1m4hLicsMpN9EPVW0F/YZbXk2MkHYCwAiXZfFdmlVboZlo +n0gRZN+6cxq1OVc2KuUN5r/kYAJIrFGMmmQkpgIx6khPvY9X7ka1kiEvYqJFj2t1o njJbGZbGDhKBYatcAAtHyX462FnRRj8pi49OWTqPLFHHvVjjsbUkh/GLkVabtOlPPU P1UaQKYPZlVHw== Received: by mail-ed1-f54.google.com with SMTP id g3so10322678edb.11; Fri, 26 Feb 2021 02:40:13 -0800 (PST) X-Gm-Message-State: AOAM530ZCrBtaqPeGeNmQ1NRnDODpJCiZy2/rN22V/qcfGtYhejPwaAq CmTi5g2HwRgGSMhTiHKBX6RpWBuKQA6Xoaj6qcc= X-Received: by 2002:a05:6402:d05:: with SMTP id eb5mr2500229edb.143.1614336012091; Fri, 26 Feb 2021 02:40:12 -0800 (PST) MIME-Version: 1.0 References: <20210216222538.6427-1-marten.lindahl@axis.com> <20210226103407.GF1014@ninjato> In-Reply-To: <20210226103407.GF1014@ninjato> From: Krzysztof Kozlowski Date: Fri, 26 Feb 2021 11:40:00 +0100 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v2] i2c: exynos5: Preserve high speed master code To: Wolfram Sang Cc: =?UTF-8?Q?M=C3=A5rten_Lindahl?= , kernel@axis.com, =?UTF-8?Q?M=C3=A5rten_Lindahl?= , linux-i2c@vger.kernel.org, linux-arm-kernel@lists.infradead.org, "linux-samsung-soc@vger.kernel.org" , "linux-kernel@vger.kernel.org" Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 26 Feb 2021 at 11:34, Wolfram Sang wrote: > > On Tue, Feb 16, 2021 at 11:25:38PM +0100, M=C3=A5rten Lindahl wrote: > > From: M=C3=A5rten Lindahl > > > > When the driver starts to send a message with the MASTER_ID field > > set (high speed), the whole I2C_ADDR register is overwritten including > > MASTER_ID as the SLV_ADDR_MAS field is set. > > > > This patch preserves already written fields in I2C_ADDR when writing > > SLV_ADDR_MAS. > > > > Signed-off-by: M=C3=A5rten Lindahl > > Looks good. Is there a Fixes-tag we could apply? The first commit, 2013 :) Fixes: 8a73cd4cfa15 ("i2c: exynos5: add High Speed I2C controller driver") Best regards, Krzysztof