Received: by 2002:a05:6a10:8c0a:0:0:0:0 with SMTP id go10csp1161295pxb; Fri, 26 Feb 2021 04:14:25 -0800 (PST) X-Google-Smtp-Source: ABdhPJwK7cywrWjkmk4nyBBviBQ69sANXHDzFLFt+lnuAJdBc1pf4zVEdpCQcvubX+FQpdQiKTr3 X-Received: by 2002:a17:906:e16:: with SMTP id l22mr2234707eji.173.1614341665343; Fri, 26 Feb 2021 04:14:25 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1614341665; cv=none; d=google.com; s=arc-20160816; b=etaZKhaaDPR6rUe76nN03nMD9fQ1kHQvXClB39JBVhdYKcLE2NkIQ/OC6+UfXCyQeL I42oQtt2SWUM5ppMnygGFa8VOCN8re5+33PF+Each1ajRm/AaWK45P7700GrHFxVqfHE tVu7LzK9/xrstdSDT4Wrd8jQvBY5gF3jfH7MT1IeeBy7qvCq+KfH1/5RrKKqsNuM7PFc gknHJKySnGlTqrOYZWj+m/MR7+IvPIknWT6fcaTKG2l7/IYwUpocEjIBZya5zqJU+h43 iMe2/ne/6qEt8LkSLhgQbWLenf84AICm3pp3nNNa659JOvImlbcyruAh9XPByh8khV2T ro7A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=GoPhaTBzxDxDjimRwk9eU6RU03Pf2eUvh8y04g2Kknc=; b=sQlv8iaigRmi4hCJm8G6LAG7qFGMKNZTRyk6LKCA0+6RBdVeFvqeV0gPRskSlbFP/R h9kDpPrziaJ6OGLbaIl+JQ9m/ysZYWSDDuQ96qqKnK/4+NZdCrCVsarXQd+/JDG8+pEJ NRzbRjSMDU8DcCgIpLXQoyZ0C+zQjUrCHmGrHJG00GNQgYyydg5uZV0t0DhouIBM128I bt4xh/F5CJ1cvSkTr2mwTRnuPcAd1Nldx3jymb+dsEYhb5bybDxwOknsKN1isW2fYPg3 h6l8YP+KcGq2GTvjP0RSyKm/cV9550QtSYS+/S/xGOpebjYpK4GUKS8B+R2nfIkOcdFr qWeg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@infradead.org header.s=casper.20170209 header.b=Bknwcnr4; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id oy5si5756417ejb.312.2021.02.26.04.14.02; Fri, 26 Feb 2021 04:14:25 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@infradead.org header.s=casper.20170209 header.b=Bknwcnr4; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230125AbhBZMLf (ORCPT + 99 others); Fri, 26 Feb 2021 07:11:35 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50112 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229989AbhBZMLb (ORCPT ); Fri, 26 Feb 2021 07:11:31 -0500 Received: from casper.infradead.org (casper.infradead.org [IPv6:2001:8b0:10b:1236::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 16A61C06174A; Fri, 26 Feb 2021 04:10:51 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=GoPhaTBzxDxDjimRwk9eU6RU03Pf2eUvh8y04g2Kknc=; b=Bknwcnr4tLLVBaQXp2lILZrLUk UDBrl4PxNZTggDzXjZeOMfsh9YNWwOn7jMizsRsiwWYjKYseEEtcfPJ21vW5EqCdonExNtpGFWTki qUeDUmh1LdflaKmHoUIJhzJfcZIxq8/eUMB2kUkbV62LGBGtvjRc0LpmGjGwAN4SgZEAz+6LFwJge XxI89rki8RYYlWDaN9TeYA1xjThJSKg0mUqkpMjK5iwmObLW0371KXBrHC386qUouVo7hMizZtiPb mkHTT3uxPT7VPePn8sD5/D1GTHJ3dZ4zjLKJQh0VFPEswmOCji6kFhJhejGj/gHOLvOok1sAh+w4c YcNbH/Tw==; Received: from willy by casper.infradead.org with local (Exim 4.94 #2 (Red Hat Linux)) id 1lFbx5-00BxuP-RD; Fri, 26 Feb 2021 12:10:36 +0000 Date: Fri, 26 Feb 2021 12:10:35 +0000 From: Matthew Wilcox To: Xu Wang Cc: viro@zeniv.linux.org.uk, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] fs: Use WARN(1,...) Message-ID: <20210226121035.GA2723601@casper.infradead.org> References: <20210226094949.49372-1-vulab@iscas.ac.cn> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210226094949.49372-1-vulab@iscas.ac.cn> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Feb 26, 2021 at 09:49:49AM +0000, Xu Wang wrote: > Use WARN(1,...) rather than printk followed by WARN_ON(1). This description doesn't match the patch. > - WARN(1, KERN_ERR "BUG: Dentry %p{i=%lx,n=%pd} " > + WARN(1, "BUG: Dentry %p{i=%lx,n=%pd} "