Received: by 2002:a05:6a10:8c0a:0:0:0:0 with SMTP id go10csp1163783pxb; Fri, 26 Feb 2021 04:17:56 -0800 (PST) X-Google-Smtp-Source: ABdhPJx5NZVenRLNNbIlItQ2ADJr5kPP+58OBiiwk2iWS1ye6s+uCCh4y1hUmxj3gfOZpr4tw3Y9 X-Received: by 2002:aa7:c84b:: with SMTP id g11mr2906589edt.169.1614341876198; Fri, 26 Feb 2021 04:17:56 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1614341876; cv=none; d=google.com; s=arc-20160816; b=ovKCxhMTffFQ0i2RNdOHAXcqo3Pcumr/Z1djwVLqgGyTTHGQlI3d4Q9QrV+aFCksOt uVbXiqdBwW8Yf5JR6p0c4liIsYGJwTTVXdAk+ZCIRrpCKPOYixtJWWMVb2fSJWEinSR0 SSeRxc3+mNvuQ0JKjIWU1FUHRNwLV0m6lztkeh21bOaFU9tc7WKw8tMr7ixQA5jQZh4x AGdCpHsRyLoEEyo70hKKiKU+XHFc7qpvyiV/Y+Clt6I5J4jzOom37+Tc8uXRoE/KXAKS ZNmTPZyY1nRswz+K9oKQvjfRDaKOLZrY59ejix/tByfsTBk1h8z7cnZ2tyHilz+XQxjT q25w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=W+BHG2rTIxJEd48HjrwhvEiIlo5wfdJwA+Qad46qFNo=; b=yh+ei+JfLeY0nQexpa9mdWqhI57pExPFuHyMjhfydqJ7pRN6SyNxAzK7B87FpJDiDR IDxQDLevApcg26VZT4muKKy/XSn3XlLe2H/Pqg24m0A8B7YNRBU/bF48Y9ZCCycAghRV 5SIA63dZTGYpXdvVA8/YXaxHUa3ZSAJI98XN9wmytBbSHXmJQyERzMUfgMKcc4ni+wp5 cScP9eUHx8Izmws25KFnsDfs7jb+kNpspw1Z+nT4EDOxXgVuEXl0XlaYVhDLcdYE5Gss K84Js9SX+zpHZ/pRMLMkjOqyZdO6eOOF4eT7Z0X82Z+VIZbbtUdlHr6bbBg3xv5BlOkh IjcQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@infradead.org header.s=casper.20170209 header.b=Yqx4Zk38; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id k18si899111eja.602.2021.02.26.04.17.33; Fri, 26 Feb 2021 04:17:56 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@infradead.org header.s=casper.20170209 header.b=Yqx4Zk38; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230022AbhBZMOs (ORCPT + 99 others); Fri, 26 Feb 2021 07:14:48 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50768 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230235AbhBZMOd (ORCPT ); Fri, 26 Feb 2021 07:14:33 -0500 Received: from casper.infradead.org (casper.infradead.org [IPv6:2001:8b0:10b:1236::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2A5D2C06178B for ; Fri, 26 Feb 2021 04:13:37 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=W+BHG2rTIxJEd48HjrwhvEiIlo5wfdJwA+Qad46qFNo=; b=Yqx4Zk38X8po2iPpxD21IYnw5q JiwCQiOlnWy8V33H9DnKo8WMuIGJuPGf/KJQ1n6K09aRWsQdsW2CRKebm89xlHrTi8wy5aJa16pj7 +yUhqvwa/J7HaO72DH6Y/4q+85xGe3TzjDyreMA2joUFI7fXuLN9lqBa0AYJV58U5u6gjdfWBb0VP 37nnyUaGwARo1F8zLA9lwoJZ48SjcNQ89uCRKp8Qgqq2qspncObQsdU48NPFsDqSGc38K2Kq4QRMK 84N3/UqkR7UwoRmJ06j0A6NLbNKp3M397qwZb2mLAqCD1noaUL3pTG1PUb2Az63fwJrC/B4G+DBHF lQ2Q9W5g==; Received: from willy by casper.infradead.org with local (Exim 4.94 #2 (Red Hat Linux)) id 1lFbze-00By35-2u; Fri, 26 Feb 2021 12:13:15 +0000 Date: Fri, 26 Feb 2021 12:13:14 +0000 From: Matthew Wilcox To: Yu Zhao Cc: akpm@linux-foundation.org, alex.shi@linux.alibaba.com, vbabka@suse.cz, guro@fb.com, hannes@cmpxchg.org, hughd@google.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org, mhocko@kernel.org, vdavydov.dev@gmail.com Subject: Re: [PATCH v2 3/3] mm: use PF_ONLY_HEAD for PG_active and PG_unevictable Message-ID: <20210226121314.GB2723601@casper.infradead.org> References: <20210224084807.2179942-1-yuzhao@google.com> <20210226091718.2927291-1-yuzhao@google.com> <20210226091718.2927291-4-yuzhao@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210226091718.2927291-4-yuzhao@google.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Feb 26, 2021 at 02:17:18AM -0700, Yu Zhao wrote: > All places but one test, set or clear PG_active and PG_unevictable on > small or head pages. Use compound_head() explicitly for that singleton > so the rest can rid of redundant compound_head(). How do you know it's only one place? I really wish you'd work with me on folios. They make the compiler prove that it's not a tail page.