Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Message-ID: <2cd72b01e143f8a6c07074bb6edf062ae2124b5b.camel@archlinux.org>
Subject: Re: [PATCH 1/2] HID: logitech-dj: add support for the new
 lightspeed receiver iteration
From:   Filipe =?ISO-8859-1?Q?La=EDns?= <lains@archlinux.org>
To:     Jiri Kosina <jikos@kernel.org>
Cc:     Benjamin Tissoires <benjamin.tissoires@redhat.com>,
        linux-input@vger.kernel.org, linux-kernel@vger.kernel.org
In-Reply-To: <nycvar.YFH.7.76.2102051614020.28696@cbobk.fhfr.pm>
References: <20210123180334.3062995-1-lains@archlinux.org>
         <nycvar.YFH.7.76.2102051614020.28696@cbobk.fhfr.pm>
Organization: Archlinux
Content-Type: multipart/signed; micalg="pgp-sha256";
        protocol="application/pgp-signature"; boundary="=-foESmcxkNMZuUk5FGgbJ"
Date:   Fri, 26 Feb 2021 14:08:06 +0000
MIME-Version: 1.0
User-Agent: Evolution 3.38.4 
Precedence: bulk


--=-foESmcxkNMZuUk5FGgbJ
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Fri, 2021-02-05 at 16:14 +0100, Jiri Kosina wrote:
> On Sat, 23 Jan 2021, Filipe La=C3=ADns wrote:
>=20
> > From: Filipe La=C3=ADns <lains@riseup.net>
> >=20
> > Tested with the G Pro X Superlight. libratbag sees the device, as
> > expected, and input events are passing trough.
> >=20
> > https://github.com/libratbag/libratbag/pull/1122
> >=20
> > The receiver has a quirk where the moused interface doesn't have a
> > report ID, I am not sure why, perhaps they forgot. All other interfaces
> > have report IDs so I am left scratching my head.
> > Since this driver doesn't have a quirk system, I simply implemented it
> > as a different receiver type, which is true, it just wouldn't be the
> > prefered approach :P
>=20
> Benjamin, do you have any other idea how to accomplish this without this=
=20
> kind of spaghetti-style conditions?
> If not, I am tempted to apply the patch as is.
>=20
> Thanks,
>=20

Hi Benjamin, Jiri,

Could we get an update on this?

Cheers,
Filipe La=C3=ADns

--=-foESmcxkNMZuUk5FGgbJ
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: This is a digitally signed message part

-----BEGIN PGP SIGNATURE-----

iQIzBAABCAAdFiEE0jW0leqs33gyftiw+JPGdIFqqV0FAmA5AMAACgkQ+JPGdIFq
qV3BiQ/9E2O3R+V6lbZ5/2WrDhYct1yLpK1ckMRDTQEgZbjr+dVn/HTDK54lbuIn
dGu6SxPeEa4DKCpUCVdPE7GnX1zPx13dvW/A7bsOBUdayy7fjo8/DGTWPGnBf0bV
wvodb2BotSPu9hXVBLU5Ye9sYvzViMiVnbGXL92yGb918pgD0uq00sM7Go7LvRCA
s8aUSS8sZla8d42GU7Sf2YTdbmNSgwHxnni0DxMCH3KFlHeeTLbGA17CpZyg/4iN
rIGyVUzfApdl7USnsbXSgrAoiwdIqMbofxL5RW/pez5K5PeJabLgOa3r13QsCwHN
blpmrAybEkYAfXbpI7/XMFIzNdvNXZmfvTJCLsyXvnFO4ImCzSFmmaImOhz+xtNZ
RX3GN+ZT6ibI1eqwKB2J+H7tH6cNE+tKIZK6Iguc3SGLjkYibBZna3lU82rcWXRP
F5uDruTnz2mbHlTj4UY5/XhZllPR9fk3HM0omsf88++NW1mbg5hRZsMP4/heobxE
HIYSCZbjgq685ryjB8U6qPLHCWD38MaAnLOp6vuRU5WMMc7czQ+gsw4jamXWFDbz
t+7cCOUEZWqAR2I3iPWTQIgR47s8TktmuXoGaCMt5iKThbgxcN+TdmaNgJ1kAFFP
iNBW1BSuQmB06FH4SCiU60zup6a5yeIlQaHRmP7s8Z9vkYNKevs=
=lKBP
-----END PGP SIGNATURE-----

--=-foESmcxkNMZuUk5FGgbJ--