Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Fri, 26 Feb 2021 14:33:36 +0000
From:   Chris Down <chris@chrisdown.name>
To:     Yang Shi <shy828301@gmail.com>
Cc:     hannes@cmpxchg.org, mhocko@suse.com, guro@fb.com,
        shakeelb@google.com, akpm@linux-foundation.org, corbet@lwn.net,
        linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] doc: memcontrol: add description for oom_kill
Message-ID: <YDkGwN2rQ5lI6LnE@chrisdown.name>
References: <20210226021254.3980-1-shy828301@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii; format=flowed
Content-Disposition: inline
In-Reply-To: <20210226021254.3980-1-shy828301@gmail.com>
User-Agent: Mutt/2.0.5 (da5e3282) (2021-01-21)
Precedence: bulk

Yang Shi writes:
>When debugging an oom issue, I found the oom_kill counter of memcg is
>confusing.  At the first glance without checking document, I thought it
>just counts for memcg oom, but it turns out it counts both global and
>memcg oom.
>
>The cgroup v2 documents it, but the description is missed for cgroup v1.
>
>Signed-off-by: Yang Shi <shy828301@gmail.com>

Thanks.

Acked-by: Chris Down <chris@chrisdown.name>

>---
> Documentation/admin-guide/cgroup-v1/memory.rst | 3 +++
> 1 file changed, 3 insertions(+)
>
>diff --git a/Documentation/admin-guide/cgroup-v1/memory.rst b/Documentation/admin-guide/cgroup-v1/memory.rst
>index 0936412e044e..44d5429636e2 100644
>--- a/Documentation/admin-guide/cgroup-v1/memory.rst
>+++ b/Documentation/admin-guide/cgroup-v1/memory.rst
>@@ -851,6 +851,9 @@ At reading, current status of OOM is shown.
> 	  (if 1, oom-killer is disabled)
> 	- under_oom	   0 or 1
> 	  (if 1, the memory cgroup is under OOM, tasks may be stopped.)
>+        - oom_kill         integer counter
>+          The number of processes belonging to this cgroup killed by any
>+          kind of OOM killer.
>
> 11. Memory Pressure
> ===================
>-- 
>2.26.2
>
>