Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
IronPort-SDR: QZF09YzAFh+JBm0yBW+2n0aQyRPwgx5PEC6WQWyO8qnkKx0Vo1NvGQpRlj9QckQlAekbLaMksi
 u5f112gOZdDQ==
IronPort-SDR: 9Xdd/lfQYg/zd3Y5RS/WTOp46Jmh+fWIfc1h0R0wWiIS+66yDH45mw0pG127GRDmAbnlMeKZwZ
 O17yNaVBO5Jw==
Date:   Fri, 26 Feb 2021 07:47:37 -0800
From:   Andi Kleen <ak@linux.intel.com>
To:     John Garry <john.garry@huawei.com>
Cc:     peterz@infradead.org, acme@kernel.org, mingo@redhat.com,
        mark.rutland@arm.com, jolsa@redhat.com, namhyung@kernel.org,
        irogers@google.com, kjain@linux.ibm.com,
        alexander.shishkin@linux.intel.com, linux-kernel@vger.kernel.org,
        will@kernel.org, linuxarm@huawei.com
Subject: Re: [PATCH] perf vendor events: Remove 'type' field from mapfiles
Message-ID: <20210226154737.GY472138@tassilo.jf.intel.com>
References: <1614344897-229717-1-git-send-email-john.garry@huawei.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1614344897-229717-1-git-send-email-john.garry@huawei.com>
Precedence: bulk

On Fri, Feb 26, 2021 at 09:08:17PM +0800, John Garry wrote:
> Included for each CPU entry in the per-arch mapfile.csv file is a 'type'
> field.

I don't like it because this will make the mapfile incompatible with
what download.01.org uses. We originally derived it from that.

It would be ok if it fixed something serious, but as it seems to be
more cosmetic I don't think there's a good reason to devivate.

-Andi