Received: by 2002:a05:6a10:8c0a:0:0:0:0 with SMTP id go10csp1436511pxb; Fri, 26 Feb 2021 10:34:26 -0800 (PST) X-Google-Smtp-Source: ABdhPJwrwI1Lzi2cTOXTkQSb2O/fWXkbLi7UKMc4NeWGmIN0svA0iYUsdv6i3NxHL0Vgd1fTVC67 X-Received: by 2002:a05:6402:c15:: with SMTP id co21mr4911684edb.115.1614364466227; Fri, 26 Feb 2021 10:34:26 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1614364466; cv=none; d=google.com; s=arc-20160816; b=AD+HwTd67HfhdgRaM1fH5aDyR4i05IHRDLsRteEnP+uRE7QTY+VM2nw5zzvPtETVbH H4jcgb3T/LrBTWBzeMcbA7M4KM7BB0gMnq2dBhUTnC1rDnMNxNhgQ6Urg2q0pzDZoOmL RBkMgh+3GjmbCmFkRVKWbvtgl7tqywmbKVTHlftEqwjxRew+CsOeOYJBY8LRBONj659p Jtwz3qmNGhMLaLHTzfs2kVnVAZIP1C2oz1sGW8r85Isp0rPoxa89YUs6vq95jBMP/NGW QUgVVcUHANF/YlyGVKBfA6ROAMvjKR0YBIA/j8q6MrLDPV2VUbXe89wYXpNTNgVFQh3+ PfyA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:message-id:date:in-reply-to:subject :cc:to:from:user-agent:references:ironport-sdr:ironport-sdr; bh=+sCorBfw9ltVbLdZiMaZDeHRdxuQBUcbSQZ/4dq2BLA=; b=RVh7/CsVzA4Ptxogc58gvamynbCnzLbKWxQFsGHXZxKUxLYbIsjCicR/sykjpm2uFJ pJy2lwcEuAXKLIwD+N3UjRHl+PhDolrdp9Js3apoauTj8M+eJs1lusTHON3zLRwV6/tT QRRrmXooplEDi50GL7u+f9Q4rkZs+sHa8LEwRHDnxKskgrleCKCHfC2c4jtPyImXEUFW LFuXYUOe0vmYcTjbY1Rosq8L4ZDQt17uHxjc/RZ19f0dsA7zXKZqnG1wAPfJuTaJ01Hr 9yI/zakv/fspPiGb2HO4ODogxMdiyn41cA9BIFdrbxejWfmuRokAhj5Pv86WxWQqHzHP tafw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id m10si6411274ejr.752.2021.02.26.10.34.02; Fri, 26 Feb 2021 10:34:26 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230194AbhBZSbo (ORCPT + 99 others); Fri, 26 Feb 2021 13:31:44 -0500 Received: from mga01.intel.com ([192.55.52.88]:24447 "EHLO mga01.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229967AbhBZSbm (ORCPT ); Fri, 26 Feb 2021 13:31:42 -0500 IronPort-SDR: 5SEavgwx7D6PmT+zkhHEcOe/MStSkl+Q6sJlMyXd6J2iZbQvAxDwAbfytF8YZnPGWltee20yrn 9c7bXNeMy9MQ== X-IronPort-AV: E=McAfee;i="6000,8403,9907"; a="205502798" X-IronPort-AV: E=Sophos;i="5.81,209,1610438400"; d="scan'208";a="205502798" Received: from orsmga008.jf.intel.com ([10.7.209.65]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 26 Feb 2021 10:29:46 -0800 IronPort-SDR: XduxGCmDmR6LTHB5zJHhF2YIG2jOE4ipOdQHfDupRL0Bde6Q+/XFfs/1n7j+l+PnPXzWjKMTIu xtshLmL9tlAg== X-IronPort-AV: E=Sophos;i="5.81,209,1610438400"; d="scan'208";a="405078296" Received: from gna-dev.igk.intel.com (HELO localhost) ([10.102.80.34]) by orsmga008-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 26 Feb 2021 10:29:43 -0800 References: <20210216160525.5028-1-maciej.kwapulinski@linux.intel.com> <20210216160525.5028-2-maciej.kwapulinski@linux.intel.com> User-agent: mu4e 1.4.13; emacs 26.3 From: Maciej Kwapulinski To: Andy Shevchenko Cc: Greg Kroah-Hartman , Arnd Bergmann , Jonathan Corbet , Derek Kiernan , Dragan Cvetic , Linux Kernel Mailing List , Linux Documentation List , Tomasz Jankowski , Savo Novakovic , Jianxun Zhang Subject: Re: [PATCH v1 01/12] gna: add driver module In-reply-to: Date: Fri, 26 Feb 2021 19:29:39 +0100 Message-ID: <85tupysmwc.fsf@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Andy Shevchenko writes: > On Tue, Feb 16, 2021 at 6:11 PM Maciej Kwapulinski > wrote: >> .... >> +#define GNA_DRV_VER "1.2.0" > > Nowadays the version is the Git SHA sum. > right, "version" is present in about 7% of all modules do You mean version should be skipped over (automatically generated) srcversion field? or maybe You suggest any (better) technique?